From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-il1-x135.google.com (mail-il1-x135.google.com [IPv6:2607:f8b0:4864:20::135]) by sourceware.org (Postfix) with ESMTPS id E1CE6385802D for ; Thu, 1 Feb 2024 16:39:21 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E1CE6385802D Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org E1CE6385802D Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::135 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1706805564; cv=none; b=nrXCW4f8NPFjbfJSIWXLYsNX0ukUXI3zqgKqTeaFtprPKzkR1vuh+/s+NqSZxkfQgrOHHhJ6pyy4WNFlGrUZpmd+M/+/0FIdD43qDuQjAl01NficvkbYq8CBBHPoQeUCAj+aByoscHDKdGWWHjXx2q/YA6/Pp2btujwH7KM43c8= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1706805564; c=relaxed/simple; bh=ioUwG3WdHjpd5zyEbLwTk8RTVTwMPPpM1JleFg6ghfQ=; h=DKIM-Signature:Message-ID:Date:MIME-Version:To:From:Subject; b=itWMKfyfa/u2opi7BvssdXWcCbXagR7Yuf+uqJT2W4GVgurWYRtFtVTsOWOPd4UFKoMjVLWIYkrUb0gtT3OWv9oRHHKE30aY2rIwycDLnTmRkqfz/OJdF8StgD/yKJ5e+IyBUxHfzOaENW/4Owc4/WrSrFH+a1k73ZBE/UTZTkE= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-il1-x135.google.com with SMTP id e9e14a558f8ab-363ac2149e2so356555ab.3 for ; Thu, 01 Feb 2024 08:39:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1706805561; x=1707410361; darn=sourceware.org; h=content-transfer-encoding:subject:from:cc:to:content-language :user-agent:mime-version:date:message-id:from:to:cc:subject:date :message-id:reply-to; bh=UATw/bR/QVppqh7eNeUd4o74JMHUB0sYNaSRZsffSXo=; b=aDbm8HpkYOiLMNOMlGyepj2j727N3FA2E2p0uUwbwVAqgHMXFHSWLi7ax5KUY+wVLQ 4h4V6qxcjikQxUvRxv0F24C8bdOomoaU7SVWDAFnFl1xKnXAiiza84o11daHUGBzh+W6 wT3VWKEGAehvHENcTj9aKNC/BEW7WFRelzAEuxj4mC1uRfVKTF2OIHUvDEOCG8jwp9JK 1Uj9/+x+epvdD3+yE1JwIB5iZ0ewTXxw4kfeGvr2lAR8s2ISnHPhYW95ib2/r3umT7U8 FTgnsy7DBt1jFAXYDDFtfeWZZiKyfcze0Y7GGQGgFgLJ4GlvSbDTLjTaq7PW6rQ9HC8U 2DFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706805561; x=1707410361; h=content-transfer-encoding:subject:from:cc:to:content-language :user-agent:mime-version:date:message-id:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=UATw/bR/QVppqh7eNeUd4o74JMHUB0sYNaSRZsffSXo=; b=WMcD+iERsSNnIJka2LOUqvrS9n0sr9K4pZARSlY5ZfWoubbK7DgxpqrmE7K1YHs/Sv m2LQ0+PlD7ZWXwJYMmkgnRMIYvoXTp2JNO5V6ZRSZcw7eOCcCcQwJBD3XP6umHjPTOiM 69Llzal/gjnCx9BukOXzMmIa1TkmLzh5cHz+QSz9VatxMCCX+OeEA+6KPMmTj2bOypJ8 JJtA611GiIvIgzD5vUreNi7MZjhFcL+9MNElH+b7zQagCSzZvE34rvxDCKqu1eitG2Du hKaZenrgyzBnKKbV5RA7LyTuknTEJhwPK9n4nSmBGOYYH3SaUUxgwbkxksQ/uMZFAbt7 pQSA== X-Gm-Message-State: AOJu0Yx3qSYSHAMh3YMSocmT7QLj5V9LXVMSmAtdhNJSxd6Af4bSx7RA QzKCTFPGVtLaYwAXRJMK0dgjlLrfVLOr7sHkWyAcgBx6VqCNKwR6akjmMEvA X-Google-Smtp-Source: AGHT+IGNNJ5ITdbBqHm23HWyfcSHBi2ris079/D8eJ9FNyOh6baqaceOV3ZMPaGAd/dKWG6ETjll0A== X-Received: by 2002:a92:ca8e:0:b0:363:869e:c5e4 with SMTP id t14-20020a92ca8e000000b00363869ec5e4mr5240190ilo.9.1706805561090; Thu, 01 Feb 2024 08:39:21 -0800 (PST) Received: from [172.31.0.109] ([136.36.72.243]) by smtp.gmail.com with ESMTPSA id w188-20020a6362c5000000b005d8e30897e4sm6148412pgb.69.2024.02.01.08.39.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 01 Feb 2024 08:39:20 -0800 (PST) Message-ID: Date: Thu, 1 Feb 2024 09:39:19 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: corinna@vinsched.de Cc: newlib@sourceware.org From: Jeff Law Subject: Problem with recent change to getlocalename_l Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: We're seeing a few ports fail to build newlib after this change: > commit 71511d4ac8686c2220093cc01525311d9c88bc4e > Author: Corinna Vinschen > Date: Sun Jan 21 13:23:09 2024 +0100 > > getlocalename_l: implement per SUS Base Specifications Issue 8 draft > > #include > const char *getlocalename_l(int category, locale_t locobj); > > Most notably, we need a per-thread space to store the string > returned if locobj is LC_GLOBAL_LOCALE. No errors are defined > for getlocalename_l. So we can't use buffer allocation which > might lead to an ENOMEM error. We have to use a "static" buffer > in the per-thread state. > > Note that the feature test macro in locale.h is not quite correct. > This needs to be fixed as soon as the pru-elf shows this failure: CC libc/stdlib/libc_a-btowc.o In file included from /home/jlaw/test/newlib-cygwin/newlib/libc/include/wchar.h:6, from /home/jlaw/test/newlib-cygwin/newlib/libc/stdlib/btowc.c:1: /home/jlaw/test/newlib-cygwin/newlib/libc/stdlib/btowc.c: In function 'btowc': /home/jlaw/test/newlib-cygwin/newlib/libc/stdlib/btowc.c:24:3: error: 'struct _misc_reent' has no member named '_getlocale_l_buf' 24 | _REENT_CHECK_MISC(_REENT); | ^~~~~~~~~~~~~~~~~ The tester is also seeing xstormy16-elf and msp430-elf fail in the same manner. Jeff