From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from sa-prd-fep-047.btinternet.com (mailomta27-sa.btinternet.com [213.120.69.33]) by sourceware.org (Postfix) with ESMTPS id E98A8385840B for ; Mon, 31 Jan 2022 14:59:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org E98A8385840B Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=dronecode.org.uk Authentication-Results: sourceware.org; spf=none smtp.mailfrom=dronecode.org.uk Received: from sa-prd-rgout-002.btmx-prd.synchronoss.net ([10.2.38.5]) by sa-prd-fep-047.btinternet.com with ESMTP id <20220131145919.GPGU16049.sa-prd-fep-047.btinternet.com@sa-prd-rgout-002.btmx-prd.synchronoss.net>; Mon, 31 Jan 2022 14:59:19 +0000 Authentication-Results: btinternet.com; auth=pass (PLAIN) smtp.auth=jonturney@btinternet.com; bimi=skipped X-SNCR-Rigid: 6139417C13897677 X-Originating-IP: [81.129.146.209] X-OWM-Source-IP: 81.129.146.209 (GB) X-OWM-Env-Sender: jonturney@btinternet.com X-VadeSecure-score: verdict=clean score=0/300, class=clean X-RazorGate-Vade: gggruggvucftvghtrhhoucdtuddrgedvvddrgedugdejudcutefuodetggdotefrodftvfcurfhrohhfihhlvgemuceutffkvffkuffjvffgnffgvefqofdpqfgfvfenuceurghilhhouhhtmecufedtudenucenucfjughrpefkffggfgfuvfhfhfgjtgfgsehtjeertddtfeejnecuhfhrohhmpeflohhnucfvuhhrnhgvhicuoehjohhnrdhtuhhrnhgvhiesughrohhnvggtohguvgdrohhrghdruhhkqeenucggtffrrghtthgvrhhnpeffkeeigfdujeehteduiefgjeeltdelgeelteekudetfedtffefhfeufefgueettdenucfkphepkedurdduvdelrddugeeirddvtdelnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehhvghloheplgduledvrdduieekrddurddutdefngdpihhnvghtpeekuddruddvledrudegiedrvddtledpmhgrihhlfhhrohhmpehjohhnrdhtuhhrnhgvhiesughrohhnvggtohguvgdrohhrghdruhhkpdhnsggprhgtphhtthhopedvpdhrtghpthhtohepnhgvfihlihgssehsohhurhgtvgifrghrvgdrohhrghdprhgtphhtthhopehvrghpihgvrhesghgvnhhtohhordhorhhg X-RazorGate-Vade-Verdict: clean 0 X-RazorGate-Vade-Classification: clean Received: from [192.168.1.103] (81.129.146.209) by sa-prd-rgout-002.btmx-prd.synchronoss.net (5.8.716.04) (authenticated as jonturney@btinternet.com) id 6139417C13897677; Mon, 31 Jan 2022 14:59:19 +0000 Message-ID: Date: Mon, 31 Jan 2022 14:58:54 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.5.1 Subject: Re: [PATCH 1/5 v2] newlib: libm: move manual into top-level build Content-Language: en-GB To: Mike Frysinger , "newlib@sourceware.org" References: <20220122043208.21962-1-vapier@gentoo.org> <20220128075826.1813-1-vapier@gentoo.org> From: Jon Turney In-Reply-To: <20220128075826.1813-1-vapier@gentoo.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-1198.4 required=5.0 tests=BAYES_00, FORGED_SPF_HELO, GIT_PATCH_0, KAM_DMARC_STATUS, KAM_LAZY_DOMAIN_SECURITY, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: newlib@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Newlib mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 31 Jan 2022 14:59:22 -0000 On 28/01/2022 07:58, Mike Frysinger wrote: > This doesn't migrate all the docs, just the libm's manual (pdf/info). > This is to show the basic form of migrating the chew files. [...] > diff --git a/newlib/libm/Makefile.inc b/newlib/libm/Makefile.inc > new file mode 100644 > index 000000000000..9aa5a5c93519 > --- /dev/null > +++ b/newlib/libm/Makefile.inc > @@ -0,0 +1,26 @@ > +info_TEXINFOS += %D%/libm.texi > +%C%_libm_TEXINFOS = %D%/targetdep.tex $(LIBM_CHEWOUT_FILES) > + > +LIBM_CHEWOUT_FILES = > + > +LIBM_CHAPTERS = > + > +%D%/libm.dvi: %D%/targetdep.tex $(LIBM_CHEWOUT_FILES) > + > +%D%/targetdep.tex: $(LIBM_CHAPTERS) > + $(AM_V_GEN)cat $^ > $@.tmp > + $(AM_V_at)$(SHELL) $(newlib_basedir)/../move-if-change $@.tmp $@ > + $(AM_V_at)touch $@ We carefully only update $@ if it's changed, then touch it anyhow? This seems like a transcription error, since originally we were touching a timestamp file, or perhaps leftover from testing? The same pattern occurs later, as well. > --- a/newlib/libm/common/Makefile.am > +++ b/newlib/libm/common/Makefile.am > @@ -59,15 +59,11 @@ endif # USE_LIBTOOL > > include $(srcdir)/../../Makefile.shared > > -CHEWOUT_FILES = s_cbrt.def s_copysign.def s_exp10.def s_expm1.def s_ilogb.def \ > - s_infinity.def s_isnan.def s_log1p.def s_modf.def \ > - s_nan.def s_nextafter.def s_pow10.def s_scalbn.def \ > - s_fdim.def s_fma.def s_fmax.def s_fmin.def \ > - s_logb.def s_log2.def s_lrint.def s_lround.def s_nearbyint.def \ > - s_remquo.def s_rint.def s_round.def s_signbit.def s_trunc.def \ > - isgreater.def > - > -CHAPTERS = > +LIBM_CHEWOUT_FILES = > +LIBM_CHAPTERS = > +include ./Makefile.inc Is this boilerplate really needed before including the makefile fragment, since '+=' should work even if the variable isn't already defined? > +CHEWOUT_FILES = $(LIBM_CHEWOUT_FILES) > +CHAPTERS = $(LIBM_CHAPTERS) > > # A partial dependency list. >