From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dedi548.your-server.de (dedi548.your-server.de [85.10.215.148]) by sourceware.org (Postfix) with ESMTPS id 1199138582A3 for ; Thu, 23 Jun 2022 10:55:32 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 1199138582A3 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=embedded-brains.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=embedded-brains.de Received: from sslproxy02.your-server.de ([78.47.166.47]) by dedi548.your-server.de with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1o4KUj-000Bd3-TM; Thu, 23 Jun 2022 12:55:30 +0200 Received: from [82.100.198.138] (helo=mail.embedded-brains.de) by sslproxy02.your-server.de with esmtpsa (TLSv1.3:TLS_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o4KUk-000ViZ-3c; Thu, 23 Jun 2022 12:55:30 +0200 Received: from localhost (localhost [127.0.0.1]) by mail.embedded-brains.de (Postfix) with ESMTP id CBBBE48007B; Thu, 23 Jun 2022 12:55:29 +0200 (CEST) Received: from mail.embedded-brains.de ([127.0.0.1]) by localhost (zimbra.eb.localhost [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id SfRoIkJzA6iR; Thu, 23 Jun 2022 12:55:29 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by mail.embedded-brains.de (Postfix) with ESMTP id 7929E4800AC; Thu, 23 Jun 2022 12:55:29 +0200 (CEST) X-Virus-Scanned: amavisd-new at zimbra.eb.localhost Received: from mail.embedded-brains.de ([127.0.0.1]) by localhost (zimbra.eb.localhost [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id t2eprmG9aMKa; Thu, 23 Jun 2022 12:55:29 +0200 (CEST) Received: from [10.10.171.14] (unknown [10.10.171.14]) by mail.embedded-brains.de (Postfix) with ESMTPSA id 1044A48007B; Thu, 23 Jun 2022 12:55:29 +0200 (CEST) Message-ID: Date: Thu, 23 Jun 2022 12:55:27 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: Fw: [PATCH 03/14] Add _REENT_ERRNO(ptr) Content-Language: en-US To: C Howland , newlib@sourceware.org References: <20220621124931.36450-1-sebastian.huber@embedded-brains.de> <20220621124931.36450-4-sebastian.huber@embedded-brains.de> From: Sebastian Huber In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Authenticated-Sender: smtp-embedded@poldinet.de X-Virus-Scanned: Clear (ClamAV 0.103.6/26581/Thu Jun 23 10:07:07 2022) X-Spam-Status: No, score=-5.4 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, NICE_REPLY_A, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: newlib@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Newlib mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Jun 2022 10:55:33 -0000 On 21/06/2022 16:41, C Howland wrote: >> >> ------------------------------ >> *From:* Newlib= on >> behalf of Sebastian Huber >> *Sent:* Tuesday, June 21, 2022 8:49 AM >> *To:*newlib@sourceware.org >> *Subject:* [PATCH 03/14] Add _REENT_ERRNO(ptr) >> >> >> >> From: Matt Joyce >> >> Add a _REENT_ERRNO() macro to encapsulate the access to the >> _errno member of struct reent. This will help to replace the >> structure member with a thread-local storage object in a follow >> up patch. >> --- >> > There already exists an __errno_r() macro that does the very same funct= ion > (defined in sys/errno.h). (Its use, however, is limited, only being us= ed > in files under iconv/lib.) Having the same thing done both ways probab= ly > doesn't make sense. The new name is more consistent with the rest of t= he > things being done, while the old name is established and errno is a mor= e > specialized case. It probably would be a good idea to either > 1) use __errno_r() instead of creating _REENT_ERRNO() or > 2) replace __errno_r() with _REENT_ERRNO() as part of adding the latte= r. I would not remove an existing macro, so option 1) would be preferred by = me. --=20 embedded brains GmbH Herr Sebastian HUBER Dornierstr. 4 82178 Puchheim Germany email: sebastian.huber@embedded-brains.de phone: +49-89-18 94 741 - 16 fax: +49-89-18 94 741 - 08 Registergericht: Amtsgericht M=C3=BCnchen Registernummer: HRB 157899 Vertretungsberechtigte Gesch=C3=A4ftsf=C3=BChrer: Peter Rasmussen, Thomas= D=C3=B6rfler Unsere Datenschutzerkl=C3=A4rung finden Sie hier: https://embedded-brains.de/datenschutzerklaerung/