public inbox for newlib@sourceware.org
 help / color / mirror / Atom feed
From: Andoni Arregi <andoni.arregui@gtd-gmbh.de>
To: Paul Zimmermann <Paul.Zimmermann@inria.fr>, newlib@sourceware.org
Subject: [PATCH] Improve lgammaf range for very small cases
Date: Fri, 11 Feb 2022 12:16:00 +0100	[thread overview]
Message-ID: <c4a89048b42db222bae84ca6b30b225ea287e672.camel@gtd-gmbh.de> (raw)
In-Reply-To: <mw35kxbyxz.fsf@tomate.loria.fr>

The original cut for small arguments at |x|<2**-70 (copied from the
double version) produces that when computing nadj we get a subnormal
number for t*x and thus, the division of pi/subnormal will be INF and
the logarithm of it too, which is wrong as a result for lgammaf in this
range.
The proposed new limit seems to be safe and has been tested to
produce accurate results.
(Courtesy of Andreas Jung, ESA)
---
 newlib/libm/math/erf_lgamma.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/newlib/libm/math/erf_lgamma.c b/newlib/libm/math/erf_lgamma.c
index f88f63092..84d02159b 100644
--- a/newlib/libm/math/erf_lgamma.c
+++ b/newlib/libm/math/erf_lgamma.c
@@ -168,7 +168,7 @@ static float zero=  0.0000000000e+00;
 	       *signgamp = -1;
 	   return one/(x-x);
 	}
-	if(ix<0x1c800000) {	/* |x|<2**-70, return -log(|x|) */
+	if(ix<0x30800000) {	/* |x|<2**-30, return -log(|x|) */
 	   if(hx<0) {
 	       *signgamp = -1;
 	       return -__ieee754_logf(-x);
-- 
2.35.1



  parent reply	other threads:[~2022-02-11 11:17 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-05  6:38 regression in Newlib 4.2.0 (lgammaf) Paul Zimmermann
2022-02-09 16:28 ` [PATCH 1/2] Improve lgammaf range for very small cases Andoni Arregi
2022-02-10 14:58   ` Corinna Vinschen
2022-02-10 16:07     ` [PATCH 0/2] Fix lgammaf and lgamma for small ranges and in [2, 3[ Andoni Arregi
2022-02-10 16:10     ` [PATCH 1/2] Improve lgammaf range for very small cases Andoni Arregi
2022-02-10 16:21       ` Paul Zimmermann
2022-02-10 16:12     ` [PATCH 2/2] Add a missing default case in lgamma Andoni Arregi
2022-02-10 17:29       ` Paul Zimmermann
2022-02-11 11:14         ` Andoni Arregi
2022-02-10 16:16     ` [PATCH 1/2] Improve lgammaf range for very small cases Andoni Arregi
2022-02-11 11:19     ` Andoni Arregi
2022-02-09 16:30 ` [PATCH 2/2] Add a missing default case in lgamma Andoni Arregi
2022-02-09 16:49 ` regression in Newlib 4.2.0 (lgammaf) Andoni Arregi
2022-02-11 11:16 ` Andoni Arregi [this message]
2022-02-14 13:46   ` [PATCH] Improve lgammaf range for very small cases Corinna Vinschen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c4a89048b42db222bae84ca6b30b225ea287e672.camel@gtd-gmbh.de \
    --to=andoni.arregui@gtd-gmbh.de \
    --cc=Paul.Zimmermann@inria.fr \
    --cc=newlib@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).