From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27365 invoked by alias); 14 Jun 2017 05:43:33 -0000 Mailing-List: contact newlib-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: newlib-owner@sourceware.org Received: (qmail 25028 invoked by uid 89); 14 Jun 2017 05:42:52 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-19.1 required=5.0 tests=AWL,BAYES_00,FOREIGN_BODY,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,SPF_PASS,T_FILL_THIS_FORM_SHORT autolearn=ham version=3.3.2 spammy=H*M:45f0 X-HELO: dedi548.your-server.de Received: from dedi548.your-server.de (HELO dedi548.your-server.de) (85.10.215.148) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 14 Jun 2017 05:42:50 +0000 Received: from [78.47.166.52] (helo=sslproxy04.your-server.de) by dedi548.your-server.de with esmtpsa (TLSv1.2:DHE-RSA-AES256-GCM-SHA384:256) (Exim 4.85_2) (envelope-from ) id 1dL14u-0007lj-VU; Wed, 14 Jun 2017 07:42:52 +0200 Received: from [82.135.62.35] (helo=mail.embedded-brains.de) by sslproxy04.your-server.de with esmtpsa (TLSv1.2:DHE-RSA-AES256-GCM-SHA384:256) (Exim 4.84_2) (envelope-from ) id 1dL14u-0006cJ-4n; Wed, 14 Jun 2017 07:42:52 +0200 Received: from localhost (localhost.localhost [127.0.0.1]) by mail.embedded-brains.de (Postfix) with ESMTP id 0E3602A004F; Wed, 14 Jun 2017 07:43:01 +0200 (CEST) Received: from mail.embedded-brains.de ([127.0.0.1]) by localhost (zimbra.eb.localhost [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id 6dIO-zXkwgFF; Wed, 14 Jun 2017 07:42:58 +0200 (CEST) Received: from localhost (localhost.localhost [127.0.0.1]) by mail.embedded-brains.de (Postfix) with ESMTP id C62BC2A160A; Wed, 14 Jun 2017 07:42:58 +0200 (CEST) Received: from mail.embedded-brains.de ([127.0.0.1]) by localhost (zimbra.eb.localhost [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id nfkroDHTEymO; Wed, 14 Jun 2017 07:42:58 +0200 (CEST) Received: from [192.168.96.129] (unknown [192.168.96.129]) by mail.embedded-brains.de (Postfix) with ESMTPSA id 80E542A004F; Wed, 14 Jun 2017 07:42:58 +0200 (CEST) Subject: Re: Adding Methods related to inttypes.h To: aditya upadhyay , newlib@sourceware.org, joel@rtems.org, Gedare Bloom References: From: Sebastian Huber Message-ID: Date: Wed, 14 Jun 2017 05:43:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2017/txt/msg00412.txt.bz2 On 13/06/17 21:03, aditya upadhyay wrote: > Hello Developers, > > I have ported the methods what are declared inside the inttypes.h > header file from freebsd. I am requesting you to please review the > code. > > I am not able to push the code of ccoshl.c in my forked repo. It is > saying fatal error. I do not know how to apply the signature.asc file. > Please have a look on my issue. > > > Thanks & Regards, > Aditya Upadhyay > > 0001-Porting-the-methods-declared-inside-inttypes.h-from-.patch > > > From b1eca6d665fc82eead745c49be9c7ccb27719483 Mon Sep 17 00:00:00 2001 > From: Aditya Upadhyay > Date: Wed, 14 Jun 2017 00:26:39 +0530 > Subject: [PATCH] Porting the methods declared inside inttypes.h from free= bsd. > > --- > newlib/libc/Makefile.am | 4 +- > newlib/libc/inttypes/Makefile.am | 24 +++++++ > newlib/libc/inttypes/imaxabs.c | 44 ++++++++++++ > newlib/libc/inttypes/imaxdiv.c | 53 ++++++++++++++ > newlib/libc/inttypes/strtoimax.c | 144 ++++++++++++++++++++++++++++++++= +++++ > newlib/libc/inttypes/strtoumax.c | 135 ++++++++++++++++++++++++++++++++= ++ > newlib/libc/inttypes/wcstoimax.c | 151 ++++++++++++++++++++++++++++++++= +++++++ > newlib/libc/inttypes/wcstoumax.c | 144 ++++++++++++++++++++++++++++++++= +++++ These functions should probably go into "newlib/libc/stdlib" just like=20 on FreeBSD and NetBSD. Where does this "inttypes" directory come from? [...] > diff --git a/newlib/libc/inttypes/imaxabs.c b/newlib/libc/inttypes/imaxab= s.c > new file mode 100644 > index 0000000..e803869 > --- /dev/null > +++ b/newlib/libc/inttypes/imaxabs.c > @@ -0,0 +1,44 @@ > +/*- > + * Copyright (c) 2001 Mike Barcroft > + * All rights reserved. > + * > + * Redistribution and use in source and binary forms, with or without > + * modification, are permitted provided that the following conditions > + * are met: > + * 1. Redistributions of source code must retain the above copyright > + * notice, this list of conditions and the following disclaimer. > + * 2. Redistributions in binary form must reproduce the above copyright > + * notice, this list of conditions and the following disclaimer in t= he > + * documentation and/or other materials provided with the distributi= on. > + * > + * THIS SOFTWARE IS PROVIDED BY THE AUTHOR AND CONTRIBUTORS ``AS IS'' A= ND > + * ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE > + * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR P= URPOSE > + * ARE DISCLAIMED. IN NO EVENT SHALL THE AUTHOR OR CONTRIBUTORS BE LIA= BLE > + * FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQU= ENTIAL > + * DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GO= ODS > + * OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) > + * HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, = STRICT > + * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN AN= Y WAY > + * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY = OF > + * SUCH DAMAGE. > + */ > + > +#if HAVE_CONFIG_H > +#include "config.h" > +#endif We don't have this HAVE_CONFIG_H stuff in Newlib. Please do not change the format for these files (white space changes).=20 For imports from FreeBSD please use the SVN checkout to get the revision=20 numbers. This makes it easier to figure out the origin of files. --=20 Sebastian Huber, embedded brains GmbH Address : Dornierstr. 4, D-82178 Puchheim, Germany Phone : +49 89 189 47 41-16 Fax : +49 89 189 47 41-09 E-Mail : sebastian.huber@embedded-brains.de PGP : Public key available on request. Diese Nachricht ist keine gesch=C3=A4ftliche Mitteilung im Sinne des EHUG.