From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dedi548.your-server.de (dedi548.your-server.de [85.10.215.148]) by sourceware.org (Postfix) with ESMTPS id B99FF385803E for ; Fri, 13 May 2022 05:44:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org B99FF385803E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=embedded-brains.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=embedded-brains.de Received: from sslproxy02.your-server.de ([78.47.166.47]) by dedi548.your-server.de with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1npO6B-0001IE-St for newlib@sourceware.org; Fri, 13 May 2022 07:44:24 +0200 Received: from [82.100.198.138] (helo=mail.embedded-brains.de) by sslproxy02.your-server.de with esmtpsa (TLSv1.3:TLS_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1npO6C-000Szq-14 for newlib@sourceware.org; Fri, 13 May 2022 07:44:24 +0200 Received: from localhost (localhost [127.0.0.1]) by mail.embedded-brains.de (Postfix) with ESMTP id B68CD480175 for ; Fri, 13 May 2022 07:44:23 +0200 (CEST) Received: from mail.embedded-brains.de ([127.0.0.1]) by localhost (zimbra.eb.localhost [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id 6qMqh8vTJpkA for ; Fri, 13 May 2022 07:44:23 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by mail.embedded-brains.de (Postfix) with ESMTP id 5F50F48015A for ; Fri, 13 May 2022 07:44:23 +0200 (CEST) X-Virus-Scanned: amavisd-new at zimbra.eb.localhost Received: from mail.embedded-brains.de ([127.0.0.1]) by localhost (zimbra.eb.localhost [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id qoGrYEdc7p4j for ; Fri, 13 May 2022 07:44:23 +0200 (CEST) Received: from [10.10.171.14] (unknown [10.10.171.14]) by mail.embedded-brains.de (Postfix) with ESMTPSA id 25E64480142 for ; Fri, 13 May 2022 07:44:23 +0200 (CEST) Message-ID: Date: Fri, 13 May 2022 07:44:21 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [PATCH v2 00/11] Decouple global file object list from _GLOBAL_REENT Content-Language: en-US To: newlib@sourceware.org References: <20220512121143.21473-1-matthew.joyce@embedded-brains.de> From: Sebastian Huber In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Authenticated-Sender: smtp-embedded@poldinet.de X-Virus-Scanned: Clear (ClamAV 0.103.5/26539/Thu May 12 10:04:41 2022) X-Spam-Status: No, score=-12.6 required=5.0 tests=BAYES_00, GIT_PATCH_0, KAM_DMARC_STATUS, NICE_REPLY_A, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: newlib@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Newlib mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 May 2022 05:44:27 -0000 On 12/05/2022 21:44, Corinna Vinschen wrote: > diff --git a/winsup/cygwin/cygtls.cc b/winsup/cygwin/cygtls.cc > index c8352adf9f25..0fd5509d2306 100644 > --- a/winsup/cygwin/cygtls.cc > +++ b/winsup/cygwin/cygtls.cc > @@ -55,16 +55,8 @@ _cygtls::init_thread (void *x, DWORD (*func) (void *= , void *)) > _REENT_INIT_PTR (&local_clib); > stackptr =3D stack; > altstack.ss_flags =3D SS_DISABLE; > - if (_GLOBAL_REENT) > - { > - local_clib._stdin =3D _GLOBAL_REENT->_stdin; > - local_clib._stdout =3D _GLOBAL_REENT->_stdout; > - local_clib._stderr =3D _GLOBAL_REENT->_stderr; > - if (_GLOBAL_REENT->__cleanup) > - local_clib.__cleanup =3D _cygtls::cleanup_early; > - local_clib.__sglue._niobs =3D 3; > - local_clib.__sglue._iobs =3D &_GLOBAL_REENT->__sf[0]; > - } > + if (_GLOBAL_REENT && _GLOBAL_REENT->__cleanup) > + local_clib.__cleanup =3D _cygtls::cleanup_early; We have: #define _GLOBAL_REENT (&_impure_data) So, the NULL pointer check is superfluous. --=20 embedded brains GmbH Herr Sebastian HUBER Dornierstr. 4 82178 Puchheim Germany email: sebastian.huber@embedded-brains.de phone: +49-89-18 94 741 - 16 fax: +49-89-18 94 741 - 08 Registergericht: Amtsgericht M=C3=BCnchen Registernummer: HRB 157899 Vertretungsberechtigte Gesch=C3=A4ftsf=C3=BChrer: Peter Rasmussen, Thomas= D=C3=B6rfler Unsere Datenschutzerkl=C3=A4rung finden Sie hier: https://embedded-brains.de/datenschutzerklaerung/