From: Sebastian Huber <sebastian.huber@embedded-brains.de>
To: newlib@sourceware.org
Subject: Re: [PATCH 1/6] Add --enable-newlib-reent-binary-compat
Date: Mon, 16 May 2022 13:54:59 +0200 [thread overview]
Message-ID: <cdb489a7-8120-7bd0-38ee-93adace78abe@embedded-brains.de> (raw)
In-Reply-To: <YoIzFc7MySI68+8E@calimero.vinschen.de>
On 16/05/2022 13:18, Corinna Vinschen wrote:
> On May 16 08:55, Sebastian Huber wrote:
>> Add the --enable-newlib-reent-binary-compat configure option. This option is
>> disabled by default. If enabled, then unused members in struct _reent are
>> preserved to maintain the structure layout.
> Given these members are unused, we can reuse them for other purposes.
> The only interesting thing is to keep the existing and still used
> members in the same offset. Along these lines, wouldn't it
> be great for potential future stuff we would like to add
> to _reent, if we take the chance and rename the unused members to
>
> int _reserved1;
> [...]
> int _reserved2[2];
>
> etc.? The latter array style would be possible, for instance, with
> _unused_sdidinit and _unspecified_locale_info, because they happen to
> clump together. The old comments describeing what has been at one
> point, could go away, and the layout may become just this teeny little
> bit cleaner...
>
> What do you think?
Yes, this sounds good. I will update the patch set.
--
embedded brains GmbH
Herr Sebastian HUBER
Dornierstr. 4
82178 Puchheim
Germany
email: sebastian.huber@embedded-brains.de
phone: +49-89-18 94 741 - 16
fax: +49-89-18 94 741 - 08
Registergericht: Amtsgericht München
Registernummer: HRB 157899
Vertretungsberechtigte Geschäftsführer: Peter Rasmussen, Thomas Dörfler
Unsere Datenschutzerklärung finden Sie hier:
https://embedded-brains.de/datenschutzerklaerung/
next prev parent reply other threads:[~2022-05-16 11:55 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-16 6:55 [PATCH 0/6] Add --enable-newlib-reent-binary-compat configure option Sebastian Huber
2022-05-16 6:55 ` [PATCH 1/6] Add --enable-newlib-reent-binary-compat Sebastian Huber
2022-05-16 11:18 ` Corinna Vinschen
2022-05-16 11:54 ` Sebastian Huber [this message]
2022-05-16 6:55 ` [PATCH 2/6] Optional struct _reent::__unused_sdidinit Sebastian Huber
2022-05-16 6:55 ` [PATCH 3/6] Optional struct _reent::_unspecified_locale_info Sebastian Huber
2022-05-16 6:55 ` [PATCH 4/6] Optional struct _reent::_new::_unused Sebastian Huber
2022-05-16 6:55 ` [PATCH 5/6] Optional struct _reent::_new::_reent::_unused_rand Sebastian Huber
2022-05-16 6:55 ` [PATCH 6/6] Use global atexit data for all configurations Sebastian Huber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cdb489a7-8120-7bd0-38ee-93adace78abe@embedded-brains.de \
--to=sebastian.huber@embedded-brains.de \
--cc=newlib@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).