From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dedi548.your-server.de (dedi548.your-server.de [85.10.215.148]) by sourceware.org (Postfix) with ESMTPS id 4E4573858C50 for ; Mon, 16 May 2022 11:55:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 4E4573858C50 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=embedded-brains.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=embedded-brains.de Received: from sslproxy01.your-server.de ([78.46.139.224]) by dedi548.your-server.de with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1nqZJX-000JVk-N5 for newlib@sourceware.org; Mon, 16 May 2022 13:55:03 +0200 Received: from [82.100.198.138] (helo=mail.embedded-brains.de) by sslproxy01.your-server.de with esmtpsa (TLSv1.3:TLS_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nqZJX-0007GQ-E6 for newlib@sourceware.org; Mon, 16 May 2022 13:55:03 +0200 Received: from localhost (localhost [127.0.0.1]) by mail.embedded-brains.de (Postfix) with ESMTP id 0EB484800F0 for ; Mon, 16 May 2022 13:55:03 +0200 (CEST) Received: from mail.embedded-brains.de ([127.0.0.1]) by localhost (zimbra.eb.localhost [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id GN0toXbk76NQ for ; Mon, 16 May 2022 13:55:02 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by mail.embedded-brains.de (Postfix) with ESMTP id B6CA548013A for ; Mon, 16 May 2022 13:55:02 +0200 (CEST) X-Virus-Scanned: amavisd-new at zimbra.eb.localhost Received: from mail.embedded-brains.de ([127.0.0.1]) by localhost (zimbra.eb.localhost [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id A_MhZg1YndPF for ; Mon, 16 May 2022 13:55:02 +0200 (CEST) Received: from [10.10.171.14] (unknown [10.10.171.14]) by mail.embedded-brains.de (Postfix) with ESMTPSA id 85BC24800F0 for ; Mon, 16 May 2022 13:55:02 +0200 (CEST) Message-ID: Date: Mon, 16 May 2022 13:54:59 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [PATCH 1/6] Add --enable-newlib-reent-binary-compat Content-Language: en-US To: newlib@sourceware.org References: <20220516065557.78164-1-sebastian.huber@embedded-brains.de> <20220516065557.78164-2-sebastian.huber@embedded-brains.de> From: Sebastian Huber In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Authenticated-Sender: smtp-embedded@poldinet.de X-Virus-Scanned: Clear (ClamAV 0.103.5/26543/Mon May 16 10:03:34 2022) X-Spam-Status: No, score=-5.5 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, NICE_REPLY_A, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: newlib@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Newlib mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 May 2022 11:55:06 -0000 On 16/05/2022 13:18, Corinna Vinschen wrote: > On May 16 08:55, Sebastian Huber wrote: >> Add the --enable-newlib-reent-binary-compat configure option. This op= tion is >> disabled by default. If enabled, then unused members in struct _reent= are >> preserved to maintain the structure layout. > Given these members are unused, we can reuse them for other purposes. > The only interesting thing is to keep the existing and still used > members in the same offset. Along these lines, wouldn't it > be great for potential future stuff we would like to add > to _reent, if we take the chance and rename the unused members to >=20 > int _reserved1; > [...] > int _reserved2[2]; >=20 > etc.? The latter array style would be possible, for instance, with > _unused_sdidinit and _unspecified_locale_info, because they happen to > clump together. The old comments describeing what has been at one > point, could go away, and the layout may become just this teeny little > bit cleaner... >=20 > What do you think? Yes, this sounds good. I will update the patch set. --=20 embedded brains GmbH Herr Sebastian HUBER Dornierstr. 4 82178 Puchheim Germany email: sebastian.huber@embedded-brains.de phone: +49-89-18 94 741 - 16 fax: +49-89-18 94 741 - 08 Registergericht: Amtsgericht M=C3=BCnchen Registernummer: HRB 157899 Vertretungsberechtigte Gesch=C3=A4ftsf=C3=BChrer: Peter Rasmussen, Thomas= D=C3=B6rfler Unsere Datenschutzerkl=C3=A4rung finden Sie hier: https://embedded-brains.de/datenschutzerklaerung/