From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 38353 invoked by alias); 22 Aug 2016 16:19:19 -0000 Mailing-List: contact newlib-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: newlib-owner@sourceware.org Received: (qmail 36632 invoked by uid 89); 22 Aug 2016 16:19:19 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-spam-relays-external:10.7.209.27, H*RU:10.7.209.27, Hx-languages-length:1557, H*MI:sk:e790744 X-HELO: mga03.intel.com Received: from mga03.intel.com (HELO mga03.intel.com) (134.134.136.65) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 22 Aug 2016 16:19:09 +0000 Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga103.jf.intel.com with ESMTP; 22 Aug 2016 09:19:07 -0700 X-ExtLoop1: 1 Received: from ajross-dev.jf.intel.com (HELO cheshire.plausible.org) ([10.7.199.81]) by orsmga003.jf.intel.com with ESMTP; 22 Aug 2016 09:19:07 -0700 Received: from ajross-mobl.amr.corp.intel.com (c-67-171-181-56.hsd1.or.comcast.net [67.171.181.56]) by cheshire.plausible.org (Postfix) with ESMTPSA id 267565FD08; Mon, 22 Aug 2016 09:19:07 -0700 (PDT) Subject: Re: [PATCH] newlib-stdint.h: Remove 32 bit longs To: gcc-patches@gcc.gnu.org References: Cc: newlib@sourceware.org From: Andy Ross Message-ID: Date: Mon, 22 Aug 2016 16:19:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2016/txt/msg00992.txt.bz2 Same code. Includes an attempt to format a change log entry in a more gcc-friendly way. I'm new here. >From c208b51fb55c6758c1059dfaee398c27da398e9d Mon Sep 17 00:00:00 2001 From: Andy Ross Date: Fri, 19 Aug 2016 09:40:42 -0700 Subject: [PATCH] newlib-stdint.h: Remove 32 bit longs This would make __INT32_TYPE__ a "long" instead of an "int", which would then percolate down in newlib's own headers into a typedef for int32_t. Which is wrong. Newlib's headers, if __INT32_TYPE__ were not defined, actually would chose an int for this type. The comment that newlib uses a 32 bit long appears to be a lie, perhaps historical. * gcc/config/newlib-stdint.h: synchronize 32 bit type macros with newlib's own headers. Signed-off-by: Andy Ross --- gcc/config/newlib-stdint.h | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/gcc/config/newlib-stdint.h b/gcc/config/newlib-stdint.h index eb99556..0275948 100644 --- a/gcc/config/newlib-stdint.h +++ b/gcc/config/newlib-stdint.h @@ -22,10 +22,9 @@ a copy of the GCC Runtime Library Exception along with this program; see the files COPYING3 and COPYING.RUNTIME respectively. If not, see . */ -/* newlib uses 32-bit long in certain cases for all non-SPU - targets. */ +/* newlib used to use a 32-bit long, no longer */ #ifndef STDINT_LONG32 -#define STDINT_LONG32 (LONG_TYPE_SIZE == 32) +#define STDINT_LONG32 0 #endif #define SIG_ATOMIC_TYPE "int" -- 2.7.4