From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 44531 invoked by alias); 24 May 2017 14:51:36 -0000 Mailing-List: contact newlib-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: newlib-owner@sourceware.org Received: (qmail 44497 invoked by uid 89); 24 May 2017 14:51:36 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 spammy=H*f:sk:63f3609, howland, Howland, freebsd-hackers X-HELO: mail02.lgsinnovations.com Received: from mail02.lgsinnovations.com (HELO mail02.lgsinnovations.com) (63.149.110.42) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 24 May 2017 14:51:34 +0000 Subject: Re: [PATCH] Use __BSD_VISIBLE for RTEMS To: Sebastian Huber , References: <20170523082353.1793-1-sebastian.huber@embedded-brains.de> <63f3609c-9556-f093-5b0d-98da23faa293@LGSInnovations.com> <779f4e8d-840a-2887-b432-a8bad9bbc93a@embedded-brains.de> From: Craig Howland Message-ID: Date: Wed, 24 May 2017 14:51:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LGS-EX05.lgsdirect.com (135.22.48.227) To LGS-EX01.lgsdirect.com (135.22.77.164) X-IsSubscribed: yes X-SW-Source: 2017/txt/msg00365.txt.bz2 On 05/24/2017 05:29 AM, Sebastian Huber wrote: > On 24/05/17 07:42, Sebastian Huber wrote: > >> On 23/05/17 17:16, Craig Howland wrote: >>> On 05/23/2017 04:23 AM, Sebastian Huber wrote: >>>> The Termios header used _POSIX_SOURCE directly to >>>> determine if a thing should be exposed to the user. This circumvented >>>> the feature mechanisms of . >>> Would you please explain why !_POSIX_SOURCE being replaced with >>> __BSD_VISIBLE rather than, for example, !__POSIX_VISIBLE? >> >> A negation of visibility define makes no sense. >> >>> That is, you seem to not only be updating to sys/features.h macro names, but >>> also shifting exactly how the gate is done. (I'm not saying it is >>> necessarily incorrect, just that the explanation does not mention the logic >>> change. The two are not logical opposites, so an implication is that the >>> original gate of POSIX is not really the right one.) >> >> This is an import from FreeBSD. To me this looks like FreeBSD forgot to >> update the Termios headers to use the visibility defines. >> >> https://lists.freebsd.org/pipermail/freebsd-hackers/2017-May/051069.html >> > > I changed this in FreeBSD: > > https://svnweb.freebsd.org/base?view=revision&revision=318780 > > I will send a v2 of the patch set for Newlib. > Yaakov agreed with BSD as the gate, and I also independently found a source which says VEOL2, VWERASE, etc. are BSD extensions; __BSD_VISIBLE is good.