From: "Richard Earnshaw (lists)" <Richard.Earnshaw@arm.com>
To: Wilco Dijkstra <Wilco.Dijkstra@arm.com>,
"newlib@sourceware.org" <newlib@sourceware.org>
Cc: nd <nd@arm.com>
Subject: Re: [PATCH][AArch64] Fix issue with dst bias in memset
Date: Mon, 12 Nov 2018 18:03:00 -0000 [thread overview]
Message-ID: <d07ead50-70c9-b515-6502-cc718124abeb@arm.com> (raw)
In-Reply-To: <DB5PR08MB103019058A406665BF08BCB883C50@DB5PR08MB1030.eurprd08.prod.outlook.com>
On 08/11/2018 15:50, Wilco Dijkstra wrote:
> This patch fixes an issue in the previous memset loop change. If the
> zva size is >= 256 and there are more than 64 bytes left, we could enter
> the loop and thus need to rebias dst by 32 as well.
>
> Since no known CPUs use this size this can't be tested natively, so I've
> tested it on a simulator initialized with a large zva size.
>
> --
>
> diff --git a/newlib/libc/machine/aarch64/memset.S b/newlib/libc/machine/aarch64/memset.S
> index 7c8fe583bf88722d73b90ec470c72b509e5be137..103e3f8bb0f20a5d02578f2379620687eae10a52 100644
> --- a/newlib/libc/machine/aarch64/memset.S
> +++ b/newlib/libc/machine/aarch64/memset.S
> @@ -233,6 +233,7 @@ L(zva_other):
> subs count, count, zva_len
> b.hs 3b
> 4: add count, count, zva_len
> + sub dst, dst, 32 /* Bias dst for tail loop. */
> b L(tail64)
>
> .size memset, . - memset
>
Pushed
prev parent reply other threads:[~2018-11-08 16:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-08 16:46 Wilco Dijkstra
2018-11-12 18:03 ` Richard Earnshaw (lists) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d07ead50-70c9-b515-6502-cc718124abeb@arm.com \
--to=richard.earnshaw@arm.com \
--cc=Wilco.Dijkstra@arm.com \
--cc=nd@arm.com \
--cc=newlib@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).