From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 93611 invoked by alias); 26 Jun 2017 06:24:26 -0000 Mailing-List: contact newlib-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: newlib-owner@sourceware.org Received: (qmail 92095 invoked by uid 89); 26 Jun 2017 06:23:08 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: Yes, score=6.8 required=5.0 tests=BAYES_50,FOREIGN_BODY,RCVD_IN_DNSWL_NONE,SPF_PASS,TIME_LIMIT_EXCEEDED,T_FILL_THIS_FORM_SHORT autolearn=unavailable version=3.3.2 spammy=Nachricht, nachricht, brains, d-82178 X-HELO: dedi548.your-server.de Received: from dedi548.your-server.de (HELO dedi548.your-server.de) (85.10.215.148) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 26 Jun 2017 06:17:42 +0000 Received: from [88.198.220.130] (helo=sslproxy01.your-server.de) by dedi548.your-server.de with esmtpsa (TLSv1.2:DHE-RSA-AES256-GCM-SHA384:256) (Exim 4.85_2) (envelope-from ) id 1dPNLA-0006ZU-T4 for newlib@sourceware.org; Mon, 26 Jun 2017 08:17:40 +0200 Received: from [82.135.62.35] (helo=mail.embedded-brains.de) by sslproxy01.your-server.de with esmtpsa (TLSv1.2:DHE-RSA-AES256-GCM-SHA384:256) (Exim 4.84_2) (envelope-from ) id 1dPNLA-0005mJ-LP for newlib@sourceware.org; Mon, 26 Jun 2017 08:17:40 +0200 Received: from localhost (localhost.localhost [127.0.0.1]) by mail.embedded-brains.de (Postfix) with ESMTP id 788D32A004F for ; Mon, 26 Jun 2017 08:17:38 +0200 (CEST) Received: from mail.embedded-brains.de ([127.0.0.1]) by localhost (zimbra.eb.localhost [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id KDszpsF4ZTvi for ; Mon, 26 Jun 2017 08:17:38 +0200 (CEST) Received: from localhost (localhost.localhost [127.0.0.1]) by mail.embedded-brains.de (Postfix) with ESMTP id 065652A160A for ; Mon, 26 Jun 2017 08:17:38 +0200 (CEST) Received: from mail.embedded-brains.de ([127.0.0.1]) by localhost (zimbra.eb.localhost [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id 6qP_3EUGNOrn for ; Mon, 26 Jun 2017 08:17:37 +0200 (CEST) Received: from [192.168.96.129] (unknown [192.168.96.129]) by mail.embedded-brains.de (Postfix) with ESMTPSA id A27CA2A004F for ; Mon, 26 Jun 2017 08:17:37 +0200 (CEST) Subject: Re: [PATCH 2/3] Add stdin_init(), stdout_init() and stderr_init() From: Sebastian Huber To: newlib@sourceware.org References: <20170623092259.29325-1-sebastian.huber@embedded-brains.de> <20170623092259.29325-2-sebastian.huber@embedded-brains.de> <20170623140231.GE18863@calimero.vinschen.de> <0ae11f4a-ddbb-c74e-bdc5-f80d259d4733@embedded-brains.de> Message-ID: Date: Mon, 26 Jun 2017 06:24:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: <0ae11f4a-ddbb-c74e-bdc5-f80d259d4733@embedded-brains.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2017/txt/msg00475.txt.bz2 On 26/06/17 08:15, Sebastian Huber wrote: > On 23/06/17 16:02, Corinna Vinschen wrote: > >>> +static void >>> +stderr_init(FILE *ptr) >>> +{ >>> + /* POSIX requires stderr to be opened for reading and writing, even >>> + when the underlying fd 2 is write-only. */ >>> + std (ptr, __SRW | __SNBF, 2); >>> +} >>> . + >> Perhaps these func should be inline? > > Ok, I change them to "static __inline void".=20 Or simply "static inline void"? Is it time to assume at least a C99=20 compiler for the Newlib sources? --=20 Sebastian Huber, embedded brains GmbH Address : Dornierstr. 4, D-82178 Puchheim, Germany Phone : +49 89 189 47 41-16 Fax : +49 89 189 47 41-09 E-Mail : sebastian.huber@embedded-brains.de PGP : Public key available on request. Diese Nachricht ist keine gesch=C3=A4ftliche Mitteilung im Sinne des EHUG.