From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out-so.shaw.ca (smtp-out-so.shaw.ca [64.59.136.138]) by sourceware.org (Postfix) with ESMTPS id BCC463851C35 for ; Wed, 13 May 2020 18:36:38 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org BCC463851C35 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=SystematicSw.ab.ca Authentication-Results: sourceware.org; spf=none smtp.mailfrom=brian.inglis@systematicsw.ab.ca Received: from [192.168.1.104] ([24.64.172.44]) by shaw.ca with ESMTP id YwFAjfclzYYpxYwFCj3LDD; Wed, 13 May 2020 12:36:38 -0600 X-Authority-Analysis: v=2.3 cv=OubUNx3t c=1 sm=1 tr=0 a=kiZT5GMN3KAWqtYcXc+/4Q==:117 a=kiZT5GMN3KAWqtYcXc+/4Q==:17 a=IkcTkHD0fZMA:10 a=43urv026VvcPvTJ2kdYA:9 a=QEXdDO2ut3YA:10 Reply-To: newlib@sourceware.org Subject: Re: arm fenv support - static inline of methods To: newlib@sourceware.org References: <57210fe5-27e7-f212-b9fd-158fe2c0c8e8@SystematicSw.ab.ca> From: Brian Inglis Autocrypt: addr=Brian.Inglis@SystematicSw.ab.ca; prefer-encrypt=mutual; keydata= mDMEXopx8xYJKwYBBAHaRw8BAQdAnCK0qv/xwUCCZQoA9BHRYpstERrspfT0NkUWQVuoePa0 LkJyaWFuIEluZ2xpcyA8QnJpYW4uSW5nbGlzQFN5c3RlbWF0aWNTdy5hYi5jYT6IlgQTFggA PhYhBMM5/lbU970GBS2bZB62lxu92I8YBQJeinHzAhsDBQkJZgGABQsJCAcCBhUKCQgLAgQW AgMBAh4BAheAAAoJEB62lxu92I8Y0ioBAI8xrggNxziAVmr+Xm6nnyjoujMqWcq3oEhlYGAO WacZAQDFtdDx2koSVSoOmfaOyRTbIWSf9/Cjai29060fsmdsDLg4BF6KcfMSCisGAQQBl1UB BQEBB0Awv8kHI2PaEgViDqzbnoe8B9KMHoBZLS92HdC7ZPh8HQMBCAeIfgQYFggAJhYhBMM5 /lbU970GBS2bZB62lxu92I8YBQJeinHzAhsMBQkJZgGAAAoJEB62lxu92I8YZwUBAJw/74rF IyaSsGI7ewCdCy88Lce/kdwX7zGwid+f8NZ3AQC/ezTFFi5obXnyMxZJN464nPXiggtT9gN5 RSyTY8X+AQ== Organization: Systematic Software Message-ID: Date: Wed, 13 May 2020 12:36:36 -0600 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-CA Content-Transfer-Encoding: 7bit X-CMAE-Envelope: MS4wfOFBiqwSaHiApp6UpM2u8bQBvYwMoanTOzkk9WBkRmeCG5xhW5OUVuP7KY702If0OZDQD6u6JXawLrG+MMPcpoa5K4GWzFp3Z6d20D+19nH6Nr8sJCd0 E7Xv5ydfRMxfWmZYMuiRmimHoJg20EoLTmauKncw6UWPOsmX/X6klDvLMJ8A9D12qGqjVkz0/ikAEA== X-Spam-Status: No, score=-14.8 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, KAM_LAZY_DOMAIN_SECURITY, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: newlib@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Newlib mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 May 2020 18:36:39 -0000 On 2020-05-13 12:22, Joel Sherrill wrote: > On Wed, May 13, 2020 at 1:17 PM, Brian Inglis wrote: >> On 2020-05-13 08:11, Joel Sherrill wrote: >>> Eshan Dhawan is an RTEMS GSoC 2020 student working on adding more POSIX >>> methods to RTEMS and newlib if appropriate. He is currently looking at >>> adding more >>> fenv.h implementations. >>> >>> The FreeBSD implementation of arm fenv.h has static inlines for all the >>> methods in sys/fenv.h. Is this OK? Or should they be turned into real >>> bodies in a C file? >> Don't all functions need to be provided as linkable implementations for >> cases where they are invoked using their address directly or indirectly, >> unless the standards agree they don't need to be? > That's what I think also but that's not how FreeBSD has implemented it. > IMO the static inline implementations from them need to move to .c files. I'm pretty sure I've seen somewhere in the sources, that the library has a standard approach for doing this, as most libraries do for such common cases. -- Take care. Thanks, Brian Inglis, Calgary, Alberta, Canada This email may be disturbing to some readers as it contains too much technical detail. Reader discretion is advised. [Data in IEC units and prefixes, physical quantities in SI.]