public inbox for newlib@sourceware.org
 help / color / mirror / Atom feed
From: Sebastian Huber <sebastian.huber@embedded-brains.de>
To: Newlib <newlib@sourceware.org>
Subject: Re: fenv() support broken with GCC 10 on ARM
Date: Wed, 8 Jul 2020 19:41:00 +0200	[thread overview]
Message-ID: <d757c76b-48f2-33ad-7641-7e84bf76116e@embedded-brains.de> (raw)
In-Reply-To: <f31356bf-5709-b9e5-fe1c-a7634b761726@embedded-brains.de>

On 08/07/2020 19:26, Sebastian Huber wrote:

> On 08/07/2020 15:00, Sebastian Huber wrote:
>
>> Hello,
>>
>> I get the following linker errors with GCC and the latest Newlib on ARM:
>>
>> /build/rtems/6/lib/gcc/arm-rtems6/10.1.1/../../../../arm-rtems6/bin/ld: 
>> /build/rtems/6/lib/gcc/arm-rtems6/10.1.1/../../../../arm-rtems6/lib/thumb/cortex-m3/libm.a(lib_a-fenv-vfp.o):/scratch/git-rtems-source-builder/rtems/build/arm-rtems6-gcc-50666d2-newlib-f095752-x86_64-linux-gnu-1/build/arm-rtems6/thumb/cortex-m3/newlib/targ-include/machine/fenv-softfloat.h:61: 
>> multiple definition of `__softfloat_float_rounding_mode'; 
>> /build/rtems/6/lib/gcc/arm-rtems6/10.1.1/../../../../arm-rtems6/lib/thumb/cortex-m3/libm.a(lib_a-fenv-softfp.o):/scratch/git-rtems-source-builder/rtems/build/arm-rtems6-gcc-50666d2-newlib-f095752-x86_64-linux-gnu-1/build/arm-rtems6/thumb/cortex-m3/newlib/targ-include/machine/fenv-softfloat.h:61: 
>> first defined here
>> /build/rtems/6/lib/gcc/arm-rtems6/10.1.1/../../../../arm-rtems6/bin/ld: 
>> /build/rtems/6/lib/gcc/arm-rtems6/10.1.1/../../../../arm-rtems6/lib/thumb/cortex-m3/libm.a(lib_a-fenv-vfp.o):/scratch/git-rtems-source-builder/rtems/build/arm-rtems6-gcc-50666d2-newlib-f095752-x86_64-linux-gnu-1/build/arm-rtems6/thumb/cortex-m3/newlib/targ-include/machine/fenv-softfloat.h:60: 
>> multiple definition of `__softfloat_float_exception_mask'; 
>> /build/rtems/6/lib/gcc/arm-rtems6/10.1.1/../../../../arm-rtems6/lib/thumb/cortex-m3/libm.a(lib_a-fenv-softfp.o):/scratch/git-rtems-source-builder/rtems/build/arm-rtems6-gcc-50666d2-newlib-f095752-x86_64-linux-gnu-1/build/arm-rtems6/thumb/cortex-m3/newlib/targ-include/machine/fenv-softfloat.h:60: 
>> first defined here
>> /build/rtems/6/lib/gcc/arm-rtems6/10.1.1/../../../../arm-rtems6/bin/ld: 
>> /build/rtems/6/lib/gcc/arm-rtems6/10.1.1/../../../../arm-rtems6/lib/thumb/cortex-m3/libm.a(lib_a-fenv-vfp.o):/scratch/git-rtems-source-builder/rtems/build/arm-rtems6-gcc-50666d2-newlib-f095752-x86_64-linux-gnu-1/build/arm-rtems6/thumb/cortex-m3/newlib/targ-include/machine/fenv-softfloat.h:59: 
>> multiple definition of `__softfloat_float_exception_flags'; 
>> /build/rtems/6/lib/gcc/arm-rtems6/10.1.1/../../../../arm-rtems6/lib/thumb/cortex-m3/libm.a(lib_a-fenv-softfp.o):/scratch/git-rtems-source-builder/rtems/build/arm-rtems6-gcc-50666d2-newlib-f095752-x86_64-linux-gnu-1/build/arm-rtems6/thumb/cortex-m3/newlib/targ-include/machine/fenv-softfloat.h:59: 
>> first defined here
>
> Affected are ARM and MIPS:
>
> grep -r 'int __softfloat_float_' .
> newlib/libc/machine/arm/machine/fenv-softfloat.h:int 
> __softfloat_float_exception_flags;
> newlib/libc/machine/arm/machine/fenv-softfloat.h:int 
> __softfloat_float_exception_mask;
> newlib/libc/machine/arm/machine/fenv-softfloat.h:int 
> __softfloat_float_rounding_mode;
> newlib/libc/machine/mips/machine/fenv-softfloat.h:int 
> __softfloat_float_exception_flags;
> newlib/libc/machine/mips/machine/fenv-softfloat.h:int 
> __softfloat_float_exception_mask;
> newlib/libc/machine/mips/machine/fenv-softfloat.h:int 
> __softfloat_float_rounding_mode;
>
> There needs to be a declaration only in the header file and a 
> definition somewhere else. 

No, this is a different issue. These header files are only included in 
source files:

newlib/libm/machine/arm/fenv.c:#include <machine/fenv-softfloat.h>
newlib/libm/machine/mips/fenv.c:#include <machine/fenv-softfloat.h>

On ARM (not in MIPS) this source file is included in two source files:

newlib/libm/machine/arm/fenv-vfp.c:#include "fenv.c"
newlib/libm/machine/arm/fenv-softfp.c:#include "fenv.c"

Does this make sense? I am not sure what the overall logic is supposed 
to be.


  reply	other threads:[~2020-07-08 17:41 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-08 13:00 Sebastian Huber
2020-07-08 13:19 ` Joel Sherrill
2020-07-08 17:26 ` Sebastian Huber
2020-07-08 17:41   ` Sebastian Huber [this message]
     [not found]     ` <CAH5ZSWo_nqnALqjgUDxUX_9B8pNLHK3kwTktXYQ_Lh+d4aJDfw@mail.gmail.com>
     [not found]       ` <bcb3c1cd-32d8-b726-fcdd-5bcc7c6d944f@embedded-brains.de>
     [not found]         ` <CAH5ZSWpcBh=EEjvcz3c956CbR9JvHA_UTfxyGJCG4B4jhWtt2w@mail.gmail.com>
2020-07-09 18:07           ` Sebastian Huber
2020-07-08 17:42   ` Eshan Dhawan
2020-07-08 17:45     ` Sebastian Huber

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d757c76b-48f2-33ad-7641-7e84bf76116e@embedded-brains.de \
    --to=sebastian.huber@embedded-brains.de \
    --cc=newlib@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).