public inbox for newlib@sourceware.org
 help / color / mirror / Atom feed
From: Yaakov Selkowitz <yselkowitz@cygwin.com>
To: newlib@sourceware.org
Subject: Re: Long double complex methods
Date: Thu, 29 Jun 2017 19:38:00 -0000	[thread overview]
Message-ID: <d7b7bbb4-d9f8-bf3f-334a-bccf115ca34d@cygwin.com> (raw)
In-Reply-To: <20170629120417.GV6201@calimero.vinschen.de>

On 2017-06-29 07:04, Corinna Vinschen wrote:
> On Jun 29 13:53, Corinna Vinschen wrote:
>> On Jun 29 12:41, Aditya Upadhyay wrote:
>>> Hello Developers,
>>>
>>> This is the modified patch for csinl.c which reflects changes in Makefile.am.
>>
>> Uhm... this patch now contains *only* the Makefile.am change, but
>> not the expected csinl.c file.
>>
>> v3? ;)
> 
> Never mind, I'm going to apply v1 and v2 of patch 18.  However, usually
> a v2 (or v3, v4, ...) of a patch is expected to replace the v1 of the
> patch entirely, not that it just contains a diff to v1.
> 
> I pushed the set now and regenerated complex/Makefile.in.

This patchset is causing errors when building Cygwin:

newlib/libm/complex/cargl.c: In function  cargl’:
newlib/libm/complex/cargl.c:16:25: error: implicit declaration of 
function ‘imag’ [-Werror=implicit-function-declaration]
           return atan2l (imag (z), real (z));
                          ^
newlib/libm/complex/cargl.c:16:35: error: implicit declaration of 
function ‘real’ [-Werror=implicit-function-declaration]
           return atan2l (imag (z), real (z));
                                    ^

-- 
Yaakov

  reply	other threads:[~2017-06-29 19:38 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-28 20:35 Aditya Upadhyay
2017-06-28 21:36 ` Dionna Amalie Glaze via newlib
2017-06-28 21:57   ` Joel Sherrill
2017-06-29 16:18     ` Joseph Myers
2017-06-29 16:31       ` Joel Sherrill
2017-06-29  6:39 ` Corinna Vinschen
2017-06-29  7:11   ` Aditya Upadhyay
2017-06-29 11:53     ` Corinna Vinschen
2017-06-29 12:04       ` Corinna Vinschen
2017-06-29 19:38         ` Yaakov Selkowitz [this message]
2017-06-29 21:17           ` Joel Sherrill
2017-06-30  9:11             ` Aditya Upadhyay
2017-07-04 21:31               ` Aditya Upadhyay
2017-07-04 21:56                 ` Aditya Upadhyay
2017-07-05  8:27                   ` Corinna Vinschen
2017-07-05  9:02                     ` Aditya Upadhyay
2017-07-05 12:40                       ` Corinna Vinschen
2022-11-08 18:31                       ` [newlib] Generally make all 'long double complex' methods available in <complex.h> Thomas Schwinge
2022-11-08 20:24                         ` Jeff Johnston
2017-06-29 13:47   ` Long double complex methods Joel Sherrill
  -- strict thread matches above, loose matches on Subject: below --
2017-06-28 13:53 Aditya Upadhyay

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d7b7bbb4-d9f8-bf3f-334a-bccf115ca34d@cygwin.com \
    --to=yselkowitz@cygwin.com \
    --cc=newlib@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).