From: Jon Turney <jon.turney@dronecode.org.uk>
To: joel@rtems.org
Cc: "newlib@sourceware.org" <newlib@sourceware.org>
Subject: Re: [PATCH v6 2/3] Add default implementation of fenv.h and all methods
Date: Mon, 12 Aug 2019 20:37:00 -0000 [thread overview]
Message-ID: <dc21a912-8642-6a82-85db-1df436f1671a@dronecode.org.uk> (raw)
In-Reply-To: <CAF9ehCWM0tL_TnoY-52T3M1yC7NT6fvb5tymTw=guL0LJ_6Mkw@mail.gmail.com>
On 12/08/2019 19:50, Joel Sherrill wrote:
> On Mon, Aug 12, 2019 at 1:31 PM Jon Turney <jon.turney@dronecode.org.uk>
> wrote:
>
>> On 08/08/2019 17:27, joel@rtems.org wrote:
>>> diff --git a/newlib/libm/fenv/Makefile.am b/newlib/libm/fenv/Makefile.am
>>> new file mode 100644
>>> index 0000000..fef5c36
>>> --- /dev/null
>>> +++ b/newlib/libm/fenv/Makefile.am
>> [...]
>>> +
>>> +CHEWOUT_FILES = feclearexcept.def fe_dfl_env.def fegetenv.def \
>>> + fegetexceptflag.def fegetround.def feholdexcept.def \
>>> + feraiseexcept.def fesetenv.def fesetexceptflag.def fesetround.def \
>>> + fetestexcept.def feupdateenv.def
>>> +
>>> +CHAPTERS =
>> [...]
>>
>> I'm not sure it totally makes sense to write this.
>>
>> This defines a bunch of source files which are chewed on with makedoc to
>> produce some texinfo fragments, but because there is no chapter which
>> includes them (not sure if that should be a new fenv.tex included by
>> libm.tex, or one of the existing chapters), the nodes defined by those
>> fragments are not navigable to from the libm root node (and I think
I think I should have written 'the nodes defined by those fragments are
not included in the generated libm.info file'
>> likewise in the html documentation)
>>
>
> Using complex.h as precedence, I would lean to making an fenv.tex file.
>
> Do you mind adding it or do you want me to take a stab and it and email it
> to you privately to test?
Please go ahead.
I don't mind testing it, but it will just involve running 'make info' or
'make html' and reading the generated files :)
prev parent reply other threads:[~2019-08-12 20:37 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-08 16:27 joel
2019-08-08 19:05 ` Corinna Vinschen
2019-08-08 20:04 ` Joel Sherrill
2019-08-09 7:50 ` Corinna Vinschen
2019-08-09 7:56 ` Corinna Vinschen
2019-08-12 8:21 ` Corinna Vinschen
2019-08-12 13:50 ` Joel Sherrill
2019-08-12 18:31 ` Jon Turney
2019-08-12 18:50 ` Joel Sherrill
2019-08-12 20:37 ` Jon Turney [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dc21a912-8642-6a82-85db-1df436f1671a@dronecode.org.uk \
--to=jon.turney@dronecode.org.uk \
--cc=joel@rtems.org \
--cc=newlib@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).