From: Brian Inglis <Brian.Inglis@SystematicSw.ab.ca>
To: newlib@sourceware.org
Subject: Re: Cygwin strptime() is missing "%s" which strftime() has
Date: Mon, 21 Aug 2017 03:09:00 -0000 [thread overview]
Message-ID: <e1e4cbb1-6a5d-9af9-afb3-d713f7009ebd@SystematicSw.ab.ca> (raw)
In-Reply-To: <09a4309f-a47c-5056-16bf-fe81e9ad483a@SystematicSw.ab.ca>
On 2017-08-18 14:00, Brian Inglis wrote:
> On 2017-07-31 03:55, Corinna Vinschen wrote:
>> On Jul 28 14:50, Brian Inglis wrote:
>>> On 2017-07-26 13:34, Corinna Vinschen wrote:
>>>> On Jul 26 11:27, Brian Inglis wrote:
>>>>> On 2017-07-26 04:49, Corinna Vinschen wrote:
>>>>>> On Jul 25 14:13, Brian Inglis wrote:
>>>>>>> On 2017-07-25 12:52, Corinna Vinschen wrote:
>>>>>>>> Well... on *third* thought, targets may redefine time_t via redefining
>>>>>>>> _TIME_T_. Targets not doing that will get long, so yeah, you're right.
>>>>>>>> Maybe it is safer to use always strtoll_l and just break this down to
>>>>>>>> time_t on the way.
>>>>>>>
>>>>>>> My concern has always been do all newlib RTEMS targets support long
>>>>>>> long, even if same as long, and stroll_l?
>>>>>>
>>>>>> Yes. The long long functions are not excluded like we do with long
>>>>>> double stuff.
>>>>>>
>>>>>>> Trying to build standalone or combined STC for this with changed strptime.c
>>>>>>> ld/collect2 fails to resolve ...global_locale.
>>>>>>
>>>>>> Yeah, it's an internal function to newlib. You need to include
>>>>>> libc/locale/setlocale.h somehow to accomplish that. STC from Cygwin
>>>>>> userspace will do.
>>>>>
>>>>> Not doing it for me: that's why I asked if there were undistributed locale
>>>>> changes in the tree, and maybe in a dev snapshot?
>>>>
>>>> No, it's an *internal* function, it doesn't get exported. There's no
>>>> (easy) way to build strptime.c outside the newlib tree as part of the
>>>> lib. That's why I said a userspace STC is enough. Don't try to build
>>>> strptime.c as standalone. Just build it as part of newlib/Cygwin and
>>>> test it from userspace by calling it.
>>>
>>> Finally got all the prereqs installed and a clean build.
>>> My configure uses the default prefix /usr/local, which is at the head of my
>>> personal path.
>>> Is that enough for a test build, and how do I do that, or do I have to replace
>>> the current release, with configure --prefix=/, make install into /bin/?
>>
>> The configured paths don't matter for the Cygwin DLL itself, and your
>> patch doesn't change any headers or entry points of the lib. So just exit
>> from Cygwin, replace the DLL in Explorer, start a shell and go ahead.
>
> Test still won't run as expected after DLL replacement, nor coreutils strptime.
> Aren't there lib import files or maps or anything I also have to move?
> Attached slightly redacted build config and make logs.
>
> Resending without attachments to see if this makes it to the list.
Doh! Cygwin has its own strptime.cc whereas it uses strftime.c from newlib.
Guess I should also patch Cygwin strptime.cc in a similar manner.
--
Take care. Thanks, Brian Inglis, Calgary, Alberta, Canada
next prev parent reply other threads:[~2017-08-19 20:53 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <BY1PR09MB0343663DE41D927E67CF0CCEA5BB0@BY1PR09MB0343.namprd09.prod.outlook.com>
[not found] ` <acc19ec5-055b-1bd4-997d-a247755163bf@SystematicSw.ab.ca>
2017-07-24 20:42 ` Brian Inglis
2017-07-24 21:36 ` Craig Howland
2017-07-24 23:04 ` Brian Inglis
2017-07-25 9:19 ` Corinna Vinschen
2017-07-25 9:16 ` Corinna Vinschen
2017-07-25 16:47 ` Brian Inglis
2017-07-25 17:38 ` Craig Howland
2017-07-25 18:52 ` Corinna Vinschen
2017-07-25 20:13 ` Brian Inglis
2017-07-26 10:49 ` Corinna Vinschen
2017-07-26 17:27 ` Brian Inglis
2017-07-26 19:34 ` Corinna Vinschen
2017-07-28 20:50 ` Brian Inglis
2017-07-31 9:55 ` Corinna Vinschen
2017-08-18 18:53 ` Corinna Vinschen
2017-08-18 19:38 ` Brian Inglis
2017-08-18 19:38 ` Brian Inglis
2017-08-18 20:01 ` Brian Inglis
2017-08-19 14:01 ` Brian Inglis
2017-08-21 3:09 ` Brian Inglis [this message]
2017-08-21 9:10 ` Corinna Vinschen
2017-08-24 2:14 ` [PATCH] newlib/libc/time/strptime.c(strptime_l) add strptime %F %s Brian Inglis
2017-08-24 8:50 ` Corinna Vinschen
2017-08-25 5:30 ` Brian Inglis
2017-08-25 12:06 ` Corinna Vinschen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e1e4cbb1-6a5d-9af9-afb3-d713f7009ebd@SystematicSw.ab.ca \
--to=brian.inglis@systematicsw.ab.ca \
--cc=newlib@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).