From: Eric Blake <eblake@redhat.com>
To: Alexander Fedotov <alfedotov@gmail.com>,
Richard.Earnshaw@arm.com, newlib@sourceware.org
Subject: Re: [PATCH v1 1/3] Reflect commits: 1. 8d98f95 (https://cygwin.com/git/gitweb.cgi?p=newlib-cygwin.git;a=commit;h=8d98f956cc398d086794e19051c3380d599022da) 2. 5c9403e (https://cygwin.com/git/gitweb.cgi?p=newlib-cygwin.git;a=commit;h=5c9403eaf40951f8a4f55ed65f661b485ff44be7)
Date: Wed, 31 Jul 2019 17:13:00 -0000 [thread overview]
Message-ID: <e5061ff4-f813-e52c-52df-6542d6b16a3a@redhat.com> (raw)
In-Reply-To: <20190731163805.28834-1-alfedotov@gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 932 bytes --]
On 7/31/19 11:38 AM, Alexander Fedotov wrote:
Way too long for the subject line (which should ideally be less than 70
characters, and should be a one-line summary of what is changing), and
missing a commit message body (that's where you can go into the details,
including why the change is worthwhile, rather than just pointing to a URL).
> ---
> libgloss/arm/syscalls.c | 12 ++++++------
> newlib/libc/sys/arm/crt0.S | 7 +++++++
> newlib/libc/sys/arm/syscalls.c | 9 +++++++--
> 3 files changed, 20 insertions(+), 8 deletions(-)
I should know what the patch is intended to do by the time I get to this
point in the email, but "Reflect commits" with two URLs as an
overly-long subject has failed to do that. Can you please resubmit with
a better commit message?
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2019-07-31 17:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-31 16:38 Alexander Fedotov
2019-07-31 16:38 ` [PATCH v1 3/3] Minor fixes, alignments and cleanup Alexander Fedotov
2019-07-31 16:38 ` [PATCH v1 2/3] Reflect commit 2404223 (https://cygwin.com/git/gitweb.cgi?p=newlib-cygwin.git;a=commit;h=2404223df651ceef42c6e2f2c9fa42fb7963db10) Alexander Fedotov
2019-07-31 17:13 ` Eric Blake [this message]
2019-07-31 17:15 ` [PATCH v1 1/3] Reflect commits: 1. 8d98f95 (https://cygwin.com/git/gitweb.cgi?p=newlib-cygwin.git;a=commit;h=8d98f956cc398d086794e19051c3380d599022da) 2. 5c9403e (https://cygwin.com/git/gitweb.cgi?p=newlib-cygwin.git;a=commit;h=5c9403eaf40951f8a4f55ed65f661b485ff44be7) Alexander Fedotov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e5061ff4-f813-e52c-52df-6542d6b16a3a@redhat.com \
--to=eblake@redhat.com \
--cc=Richard.Earnshaw@arm.com \
--cc=alfedotov@gmail.com \
--cc=newlib@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).