From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by sourceware.org (Postfix) with ESMTP id 6DF023892449 for ; Wed, 21 Apr 2021 15:20:17 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 6DF023892449 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=foss.arm.com Authentication-Results: sourceware.org; spf=none smtp.mailfrom=Richard.Earnshaw@foss.arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 2139911FB; Wed, 21 Apr 2021 08:20:17 -0700 (PDT) Received: from [10.57.58.32] (unknown [10.57.58.32]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 985373F774; Wed, 21 Apr 2021 08:20:16 -0700 (PDT) Subject: Re: [PATCH] fix some Arm FP routines not checking if floating point is enabled To: Ties Stuij , newlib@sourceware.org References: From: Richard Earnshaw Message-ID: Date: Wed, 21 Apr 2021 16:19:04 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3498.2 required=5.0 tests=BAYES_00, GIT_PATCH_0, KAM_DMARC_STATUS, KAM_LAZY_DOMAIN_SECURITY, NICE_REPLY_A, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: newlib@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Newlib mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Apr 2021 15:20:27 -0000 Pushed. R. On 21/04/2021 13:48, Ties Stuij wrote: > A lot of the Arm FP routines check for the availability of floating point by way > of `(__ARM_FP & 0x4)`. However some do not. This patch remedies this. > --- > newlib/libm/machine/arm/sf_ceil.c | 2 +- > newlib/libm/machine/arm/sf_floor.c | 2 +- > newlib/libm/machine/arm/sf_nearbyint.c | 2 +- > newlib/libm/machine/arm/sf_rint.c | 2 +- > newlib/libm/machine/arm/sf_round.c | 2 +- > newlib/libm/machine/arm/sf_trunc.c | 2 +- > 6 files changed, 6 insertions(+), 6 deletions(-) > > diff --git a/newlib/libm/machine/arm/sf_ceil.c b/newlib/libm/machine/arm/sf_ceil.c > index b6efbff0b..44fdf834a 100644 > --- a/newlib/libm/machine/arm/sf_ceil.c > +++ b/newlib/libm/machine/arm/sf_ceil.c > @@ -24,7 +24,7 @@ > NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS > SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. */ > > -#if __ARM_ARCH >= 8 && !defined (__SOFTFP__) > +#if __ARM_ARCH >= 8 && (__ARM_FP & 0x4) && !defined (__SOFTFP__) > #include > > float > diff --git a/newlib/libm/machine/arm/sf_floor.c b/newlib/libm/machine/arm/sf_floor.c > index 7bc95808c..44c38c42c 100644 > --- a/newlib/libm/machine/arm/sf_floor.c > +++ b/newlib/libm/machine/arm/sf_floor.c > @@ -24,7 +24,7 @@ > NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS > SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. */ > > -#if __ARM_ARCH >= 8 && !defined (__SOFTFP__) > +#if __ARM_ARCH >= 8 && (__ARM_FP & 0x4) && !defined (__SOFTFP__) > #include > > float > diff --git a/newlib/libm/machine/arm/sf_nearbyint.c b/newlib/libm/machine/arm/sf_nearbyint.c > index c70d84442..126673e97 100644 > --- a/newlib/libm/machine/arm/sf_nearbyint.c > +++ b/newlib/libm/machine/arm/sf_nearbyint.c > @@ -24,7 +24,7 @@ > NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS > SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. */ > > -#if __ARM_ARCH >= 8 && !defined (__SOFTFP__) > +#if __ARM_ARCH >= 8 && (__ARM_FP & 0x4) && !defined (__SOFTFP__) > #include > > float > diff --git a/newlib/libm/machine/arm/sf_rint.c b/newlib/libm/machine/arm/sf_rint.c > index d9c383a7e..5def21009 100644 > --- a/newlib/libm/machine/arm/sf_rint.c > +++ b/newlib/libm/machine/arm/sf_rint.c > @@ -24,7 +24,7 @@ > NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS > SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. */ > > -#if __ARM_ARCH >= 8 && !defined (__SOFTFP__) > +#if __ARM_ARCH >= 8 && (__ARM_FP & 0x4) && !defined (__SOFTFP__) > #include > > float > diff --git a/newlib/libm/machine/arm/sf_round.c b/newlib/libm/machine/arm/sf_round.c > index 232fc0848..88c53ba13 100644 > --- a/newlib/libm/machine/arm/sf_round.c > +++ b/newlib/libm/machine/arm/sf_round.c > @@ -24,7 +24,7 @@ > NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS > SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. */ > > -#if __ARM_ARCH >= 8 && !defined (__SOFTFP__) > +#if __ARM_ARCH >= 8 && (__ARM_FP & 0x4) && !defined (__SOFTFP__) > #include > > float > diff --git a/newlib/libm/machine/arm/sf_trunc.c b/newlib/libm/machine/arm/sf_trunc.c > index 64e4aeb9a..c08fa6fed 100644 > --- a/newlib/libm/machine/arm/sf_trunc.c > +++ b/newlib/libm/machine/arm/sf_trunc.c > @@ -24,7 +24,7 @@ > NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS > SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. */ > > -#if __ARM_ARCH >= 8 && !defined (__SOFTFP__) > +#if __ARM_ARCH >= 8 && (__ARM_FP & 0x4) && !defined (__SOFTFP__) > #include > > float >