From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from sonic307-53.consmr.mail.ir2.yahoo.com (sonic307-53.consmr.mail.ir2.yahoo.com [87.248.110.30]) by sourceware.org (Postfix) with ESMTPS id 7BF43385E83F for ; Wed, 16 Mar 2022 07:12:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 7BF43385E83F X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1647414728; bh=W/ZD1VTHP1dy+TcGTQZJC7etEsCG8JLAV1lNgWVtZl2=; h=X-Sonic-MF:Date:Subject:From:To:From:Subject; b=jnytiOiHaxCF3dPVmSt828YQOiB9OUYuePwzOx4/20cZEjpJkXlo2gA1BGG9pLhOWzUs48BsVk6DPxUKqR0rObbJQHjCbSZPSrDesXsszhWpm7973BraLLAECbFQLeShSO0qeVq6Epk03hGlQJyLsHkeTefRnFqCGwGlFxhg6Ii7IB4sNjkugaSMOIJdhy4i5TKu6/Q34YWDwPN9XZ3vPn6irQBzSykGfOCPJpWK6neuFfUmYkI0v+KWS4OWGEYG0HRkXQ6VnzhKaRkMK7qH+fqi3ck4FiukORNWZRpqUlEdukGSqns5ckgGDKIx+G2wvn3HTLZXU6gdyuVpD0tsJg== X-YMail-OSG: eHbKK9kVM1nOqgWRF95xk0VrPtsGlfC6z8fFu2_sR6S0rk5pJW31SwxGOJDZLFd SqrLj..6xOHsLA1qk0EXl8Ail073h66JsXFb3nsZTDOxuqTOvtwSv90o2atOY6t3cdA0QGiruK0M tP54tzq7zxcTbHIv5TlICbr5DOjSpM11uzO9HveYvtH8T.kfaokbBNIU1jaBLiLzdzWAC47z15Sv QEQxlogLXaGAe5JG0PuH81bk4jOHTSSKv3Ijp2bu1pqmMcWxb1hG2PSyJ.czQuP3NoDEDr.3KVfL 28b0w_lNyuB6x7EddV9lVLfZN5W.D5Ebx9ZT10fq6z79_ucHgga1VXi0LvC.1Dz_VLQ84Rj5naUg 5.mwrF2kr0h_wHfkYGaTh7Ny28z2KwuSLvdMmifeB2gWBB_86ZhsUkLPGFiq6Pi6mOueBfYQ3pau u.ECZJizoje6pYQ7XqDqvvfhcTTNlE_q7zRsUVFy_8It8sqNRi8DwBfe7Ftj95oEymxzyRNJRpem l6MTmyIyaHMTyiDimMUphkOYMCSqDRG4kYhN3SWDqnrKkDYWBGtGdHQ_lWpRt6Y5WJejEwBO4Beq Lt4i5Mk4GhET53RZLF3o_35bZ9Lqo.C3jkT8f8vxLij12aViySYbqFFE7e9BWU1mGyFY7N9FJKfs irla39lIjWEps7GPhX9eRUn.VfB6UelzsUoHprT1a8tUjQDW9hvClNQj0oKd6bR7z2Sq2rpCH.tj SUkYf8y.IZM07hJXoKJp1kS1Txk9gzdW5Gr81nzvSTCmZp1xpTMWh97TbKKCfKZZPFCvUQjD1XWh .8YKjqoWduZFy7LPHj7Lepa3jsajX8FVSRRECu2g9fhdXfbS5NlaR37dzuMhzZbQQ3ELHBWBB.jw ZuQwrezChhTmKFS6LEFvmhqXVm3ijLjNc8DLapHxRZ7wwOIYZrb512IoTianSPthOndb8_Ww70kC IBrm_bmPTJb52GRIM0V0VXudEPK455cqLCVCD7sQ0FVbmV88B7yob5zmylF8mDBNFhgcrNExV2Aw 59kSn.5x8oklZvaeN4lgNFaEO8G3K5j_DOVVr1POwIThUkbs4AA3e.RQmmB4pxYvn_ta19fEecDn 8_xPncxUfihqs7sRpUcxo7Oiv7mKa085keMU__x4vnjO7o36PeYjjz6dFnO4ItA1s7p05WgEdDR7 4mqHYZDNCrRhMxZsWvx.T782xcr4ZYAJr3JerNEsZbav8PBJl7aL9vrNtkAD63Liyu2GhycGE7zi eBcWbcW1yfgFBYDxRwS8CdfpZHLuCVL55e4T9fXG_AzKTBXfqycEWwh4i1W61ePiVlKK2lKXIRAi omsvcfe8_E2O3KJAAuFt7rlR0fiFjwDAfXEUPhUjzZa8KzjACjeTTLyifAoDqR4m9GjpkH_1TXeI GHKUVEsZHD9oodsy9H2gFlyoIJ9ZZJW.mY2nqpVddbsnOBG1qSK6ZFJ3l3xt1c0pnl.rqJ9KSuUb iTPz.3EZhtrDkSNm5x6dglGNAFzehsLfvB6wXxIF5w3ss7SbRNAyWVNYw7JDoyPXI10SPHevhEdW hcQPizVpvvRXxxzJIaO__RrKVLpyazOtuZpNh3xgFHML6vqxbQHDm7hmi35_25I011nI3PXSMzbK 74vmHNsGl8bYVrQP.YtqI8ParX3jUSibkSdsvAj8u2vSTgGxITunc6xU8HFR4M4N3XJRigQ3xI4x xKsF8mMIdhWmxBdGscjPJeMplX03IjrCwgaH.4DcPrBJ1HMlNbkI8U1Wsj4AV4efjGvkvuYTYipY 21j7lzqBSq8PFojXlohXtPIiHJ4NDslsgD.leP5lGRtDktjlL_Xz0n5tsnvJ0IAtlyeZCu8iOEZm lL6ZkDHzOz8cb7kxzBGNCLXvGgyOzxjN4emrE91eNjicPN0jqslX8oxbIL191aeii3fR0A0WQu3N 8OR.AL03Bi4Yy9CfwHcztemzStkkMo8M7bQgl9eRWTROR.lKK_8shAfPACQIsBTCgilksc9CAbA_ JI4q8FnBUlaTubanuQvi8vxmmOUP2HfpxcYnXOHqTmw.REdaY_gMb1C4kJjd.ocl47K0_r.CCtGT B.Q4THjkoAGW9UtrZ7HADFOr1HlmStTeWhFXvaTbv.M48bx1.iY473l_ns2lNGnjz1CxXn1O_lTv e3BOHYOwB6NVEvtvSm6CXcvQPzVJQ4wY5ZCko6GTNVgbaB5vWn4fVTmRCSJv08M_uf1TzrvJt5Uz hTYbQLobyBakhO5s_D7vpIUx0FS5eDQ4AhyhKkSphHE2MQSJdpORsmDOHNlLgFqwp3w9t5iy1QTK CUgpsn5d482zV X-Sonic-MF: Received: from sonic.gate.mail.ne1.yahoo.com by sonic307.consmr.mail.ir2.yahoo.com with HTTP; Wed, 16 Mar 2022 07:12:08 +0000 Received: by kubenode501.mail-prod1.omega.ir2.yahoo.com (VZM Hermes SMTP Server) with ESMTPA ID 9732eed36402bf6f98ff1ef09bcdfed6; Wed, 16 Mar 2022 07:12:05 +0000 (UTC) Message-ID: Date: Wed, 16 Mar 2022 08:12:04 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH v2] newlib: fix build with <20220315032550.16502-1-vapier@gentoo.org> <2c68b0f8-03ad-d93d-dd35-002a66576ff8@foss.arm.com> From: "R. Diez" Cc: Richard Earnshaw , newlib@sourceware.org To: Mike Frysinger In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Mailer: WebService/1.1.19878 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo X-Spam-Status: No, score=-1.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: newlib@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Newlib mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 16 Mar 2022 07:12:12 -0000 > __builtin_mul_overflow showed up with gcc-5, so stub it out for older > versions. > [...] > +#if !__GNUC_PREREQ__(5, 0) > +#define __builtin_mul_overflow(a, b, size) ({ *(size) = (a) * (b); 0; }) I do not understand why Newlib needs to "stub it out" like this. According to the GCC documentation, this kind of built-in routines allow the caller to check whether the operations overflowes. But the code above performs no overflow checking at all. Therefore, compiling your code with GCC < 5 will silently break your application. After all, the only reason to use __builtin_mul_overflow() is that you need to check for overflow, is it? Regards, rdiez