From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.fibranet.cat (www.fibranet.cat [88.99.13.26]) by sourceware.org (Postfix) with ESMTPS id D0A043858D20 for ; Tue, 18 Jul 2023 07:08:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D0A043858D20 Authentication-Results: sourceware.org; dmarc=pass (p=reject dis=none) header.from=fibranet.cat Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=fibranet.cat Received: from [192.168.1.11] (34.red-176-83-116.dynamicip.rima-tde.net [176.83.116.34]) (authenticated bits=0) by mail.fibranet.cat (8.15.2/8.15.2) with ESMTPSA id 36I78E4G3563129 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT); Tue, 18 Jul 2023 09:08:17 +0200 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.fibranet.cat 36I78E4G3563129 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fibranet.cat; s=default; t=1689664098; bh=fqg0p6R2BUW0Tjil+PpihRRrov6XKyCjWKD5ka6EtAM=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=UZwF8NVBYtLqJLrhcqlDnDWNvkhPSZFolHpxYJcOQrxpLuAFoK0dSgsZNIPhJG4BC ehYTFXLyqPMuLmv3Jz4ojOF9alDrr3WU/JgbotcgXK41AdgRqyclTckgB/LPdrKbDp gjCk4uCTVUHj1u4fEi/S6K2X/MaqNoGw/39rUcC4= Message-ID: Date: Tue, 18 Jul 2023 09:08:14 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH] Fix getlogin() to check only stdin to get a valid tty Content-Language: en-US To: Jeff Johnston Cc: newlib@sourceware.org References: <1de3b3ee-7dd8-db16-6e17-365dbd9fde84@fibranet.cat> From: Jordi Sanfeliu Organization: Fibranet NSP, SL In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.6.2 (mail.fibranet.cat [88.99.13.26]); Tue, 18 Jul 2023 09:08:18 +0200 (CEST) X-FibraNet-MailScanner-Information: FibraNet E-Mail Virus Protection Service X-FibraNet-MailScanner-ID: 36I78E4G3563129 X-FibraNet-MailScanner: Found to be clean X-FibraNet-MailScanner-SpamCheck: X-FibraNet-MailScanner-From: jordi@fibranet.cat X-FibraNet-MailScanner-Watermark: 1690268898.28703@Uy2iMQcOroWYU1CM9xsYeg X-Spam-Status: No, score=-3.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hello Jeff, I'm reviewing the patch you applied to getlogin.c and it seems to me that there is an extra opening parenthesis. You forgot the diff line: + if ((tty = ttyname (0)) == 0) Can you confirm it? Regards. On 7/17/23 21:06, Jeff Johnston wrote: > Original patch pushed, thanks. > > -- Jeff J. > -- Jordi Sanfeliu FIBRANET Network Services Provider https://www.fibranet.cat