From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dedi548.your-server.de (dedi548.your-server.de [85.10.215.148]) by sourceware.org (Postfix) with ESMTPS id 35D973858418 for ; Wed, 13 Jul 2022 08:19:53 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 35D973858418 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=embedded-brains.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=embedded-brains.de Received: from sslproxy03.your-server.de ([88.198.220.132]) by dedi548.your-server.de with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1oBXb5-000G2z-Ez for newlib@sourceware.org; Wed, 13 Jul 2022 10:19:51 +0200 Received: from [82.100.198.138] (helo=mail.embedded-brains.de) by sslproxy03.your-server.de with esmtpsa (TLSv1.3:TLS_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oBXb5-000XDI-LU for newlib@sourceware.org; Wed, 13 Jul 2022 10:19:51 +0200 Received: from localhost (localhost [127.0.0.1]) by mail.embedded-brains.de (Postfix) with ESMTP id 5CE2048005B for ; Wed, 13 Jul 2022 10:19:51 +0200 (CEST) Received: from mail.embedded-brains.de ([127.0.0.1]) by localhost (zimbra.eb.localhost [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id fWcA74Doores for ; Wed, 13 Jul 2022 10:19:51 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by mail.embedded-brains.de (Postfix) with ESMTP id 19273480142 for ; Wed, 13 Jul 2022 10:19:51 +0200 (CEST) X-Virus-Scanned: amavisd-new at zimbra.eb.localhost Received: from mail.embedded-brains.de ([127.0.0.1]) by localhost (zimbra.eb.localhost [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id J3nxizIdKkrx for ; Wed, 13 Jul 2022 10:19:51 +0200 (CEST) Received: from [10.10.171.6] (unknown [10.10.171.6]) by mail.embedded-brains.de (Postfix) with ESMTPSA id E292A48005B for ; Wed, 13 Jul 2022 10:19:50 +0200 (CEST) Message-ID: Date: Wed, 13 Jul 2022 10:19:49 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: Fw: [PATCH 03/14] Add _REENT_ERRNO(ptr) Content-Language: en-US To: newlib@sourceware.org References: <20220621124931.36450-1-sebastian.huber@embedded-brains.de> <20220621124931.36450-4-sebastian.huber@embedded-brains.de> <29672b0c-34bf-6015-ea8d-9fb8c3c09f2e@embedded-brains.de> <82b5a844-34b6-c983-fac8-a0b9a48ebc40@embedded-brains.de> From: Sebastian Huber In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Authenticated-Sender: smtp-embedded@poldinet.de X-Virus-Scanned: Clear (ClamAV 0.103.6/26599/Tue Jul 12 10:00:48 2022) X-Spam-Status: No, score=-5.4 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, NICE_REPLY_A, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: newlib@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Newlib mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 Jul 2022 08:19:54 -0000 On 13/07/2022 09:50, Corinna Vinschen wrote: > On Jul 13 09:17, Sebastian Huber wrote: >> On 12/07/2022 20:25, Corinna Vinschen wrote: >>>> What about renaming the existing __errno_r() uses in Newlib to >>>> _REENT_ERRNO() with a definition of __errno_r() in for >>>> potential users outside of Newlib? >>> Sounds good to me. >> Attached is a new version of this patch. In this patch the uses of >> __errno_r() were replaced with _REENT_ERRNO(). > In future, would you mind to send followup patches as v2, v3, the same > way as the first patch, please? It's not required as such, but it make= s > applying a series easier. Ok, sorry. >=20 > Having said that, the patchset looks good to me. AFAICS this also > uncovered a minor bug in Cygwin in the errno handling, but that's > something for us Cygwin folks to patch after you applied your set. Thanks for the review, I checked it in. --=20 embedded brains GmbH Herr Sebastian HUBER Dornierstr. 4 82178 Puchheim Germany email: sebastian.huber@embedded-brains.de phone: +49-89-18 94 741 - 16 fax: +49-89-18 94 741 - 08 Registergericht: Amtsgericht M=C3=BCnchen Registernummer: HRB 157899 Vertretungsberechtigte Gesch=C3=A4ftsf=C3=BChrer: Peter Rasmussen, Thomas= D=C3=B6rfler Unsere Datenschutzerkl=C3=A4rung finden Sie hier: https://embedded-brains.de/datenschutzerklaerung/