From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from deimos.uberspace.de (deimos.uberspace.de [185.26.156.152]) by sourceware.org (Postfix) with ESMTPS id F3AF53858C54 for ; Thu, 7 Apr 2022 16:18:45 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org F3AF53858C54 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=jdoubleu.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=jdoubleu.de Received: (qmail 22118 invoked by uid 989); 7 Apr 2022 16:18:44 -0000 Authentication-Results: deimos.uberspace.de; auth=pass (plain) Message-ID: Date: Thu, 7 Apr 2022 18:18:43 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Content-Language: de-DE To: newlib@sourceware.org References: <20220405040358.18332-1-Brian.Inglis@SystematicSW.ab.ca> <20220405040358.18332-3-Brian.Inglis@SystematicSW.ab.ca> From: jdoubleu Autocrypt: addr=hi@jdoubleu.de; keydata= xsFNBF9PazYBEACbGULPi2q0/BLIc4q814xtbiB2miLoi0NjZR3JyQ1+VGx/noQr9or3mO9O O96I8RdWq5Mj/aL0f6oMQEZOvZSpcgDAEVRRuGA0GLmxf/2bODc3YL3nLrrVHC+vjJv4gVZA GnJeXtR+wNQdt00WtpE2//NrSrgAwmhpJiErmY3m0Y8NaKFNwKqUSpda0lvu1y17EyQejuNy CabAWs3+n9vV8WiGau+drxMlHKrzMPn5KGddjTAgRogFqNGC1RxRRgi9WY9QiNCjvnEV/emC ZGMCKRlRp8TD5rQl4tEACnIeDvY2hdt/xjySIRTASfHi59M2DcJ/Dzd40rO+Byj+BcCX+6fK jlEl5A51V0GnjW6boz9k1KZ3OyQuA8ZFc8lcQ10YRYRRosPHkdch5uLbJX8MnP3bj/a4fmBN sr6zHPj106uCUOvpcJ/gkSIlIvvg4MH3KvnLwoFeesz75UNYjbQ03kSp7F0i+8g8HNQ0KofT tKvBEoOEdy8LNd4+dTHM66FUW8g39+hgoOa9lLC3B2kaK9601HaI9Gyuv0e02Qbcd7IG+ogn dv3m+NIu4hvkiXy3o5UKWPAy4XHbkKSzxLM8uIq4ct3nDzCqo8gNVtTu4EgGOmg/StkubFbs udXG8NC3Lt8xQwt16H9K51HOmsbTLkwRQDdtUNcwQZVsZ4IVtQARAQABzSNKb3NodWEgV2Vz dGVyaGVpZGUgPGhpQGpkb3VibGV1LmRlPsLBlAQTAQgAPhYhBBWN1CFVVXC4dtD3LRg08EDM i8GMBQJfT2s2AhsDBQkDv8QABQsJCAcCBhUKCQgLAgQWAgMBAh4BAheAAAoJEBg08EDMi8GM VqEP/22QybfAAbRfbuVtdSRDpaAJHuuhN+pwVeML8Ce1s1WInFejJdSikAzJKxgPxAdx1ZT3 Nj7pt6Jp1j0/BpDqjszgQu5rkHE71+3f99lOv4Tjhg4WoMsKzJ7Mj+bjIowWzL3Yw4eNMnGt OBAFiB2AbKqJy+NApFk140Kv6bie8+zr5E5MF2RrDc7oETL5CXo5necalmD8woIIYS5LKPSU 4YCzpzF5NgDIgZ9/20qdve9h2w4x/Uxi9GAp37df284n0jCQ2M4WIi4bZ7qwxlBc9x6U1bDZ BFX+wCMWZNjZwzfs5Yc/8ifGxe1eOb/w5fskWAXFHlwUv4fe3mQz9m8oED7LsKIdbhpkqH4J ctYKvumtVc8mBV6lzt/zad7WEsMGQPEMld3BUIbpgrb1dGgFoAy8Cb84HJGjfQFGuPMdgriA AaWFu6TqMrMMsInlRbbd/bELOzFCWXQaDSKQ8gM2dnIzTt7OFsc4h2ZosoF80eWzzs5wK6Aq mnTI8MdMwx22kZHDXBi6fJkspGMVpKzG3wAmnQUvi1mLYF2KoIaJUEZgKZUPFofYPJXy1EvL +e9Th8qJ7O/nk7mGsWohNmaYaYJLVMLxuNXN1w6C32r72lJ2hqX2mgMRtKIaoOu+9UiAtXtO ugcihmaVRBy2C21XGItVhqqSWS/KbwhoMo7o1xa8zsFNBF9PazYBEACmBJ6pIMF/souET+sb +IOO7/H+aDSgFJaI2d306F/LJUz2oPlHKaEGrPc9/yN4mDDfY5ciuY7qPs7ytKcOaGWD27/W 5/3h52t/Dv8XKGAFvlCWYO06u/DdKZ/sV7xqVlXM7EAjBdsRMoSDOBt6GHMyIdocbESIrKod 9BHIVDal5cTCuS98eSYg70kMJ0qAdNqO882qUiDMONCgru4ssN8UBpzcJR2NWX1dRhEzZf2z 10ZjDv59QTUOLytGFZOw6qzgdSdq1llXO7XdpGWlyUUOye96KJemSBpS6YpSIUYHcppIQkG+ 3bYoMGJZ0epAgElgnX5WcGnrFo/btH6FA+Fe0+TBoTxo16kL2OOuhpOQMOHUF7/shHmTzMd/ M0kTSJ/X5pzLKt4Rb0Q5zAx9QFa/bH2GF20w87VfAlsAv75tiYpj4omWRr/ZlbSeJXoVWjht igqTWZ/skmwQj9G3viktnhgntj2RpYW6uVVkNVw08VYm6AoSttgD0uIwjxegUuAC1Igxco42 vEe0C6M1Qv4BNOCYdMJxOAJYpPqWILjugbKl21Tu8wFUlUEmTVYCAFvYhVggj/d73yv2ecRw NI/Y+dD7Krkjjn3GC2KzoQy40Q+QcWPjevuTm+QRcNug+1kcKD03Ahp2eePv1CkCNPGPyU1q ZTNxihvtuUNOKUc1KQARAQABwsF8BBgBCAAmFiEEFY3UIVVVcLh20PctGDTwQMyLwYwFAl9P azYCGwwFCQO/xAAACgkQGDTwQMyLwYzZvw//W9iMcQpb3xWmpePmgtTWaJ3Cu1TXafBrHAY3 few7TOFhsm7n28Xv87WM/PCD9MbvTMccuVe2lrApF7osgy0FeMQaWuBQghBjfR1bnhMQPIRU 985y/uoLy5N02ey66K5FaPldQG0MRJrMYf5f9x5zB8j37DlJjk5idbBFg4NejEYQwuVMwhFt ZFyUoGmtvTT89Gbvmz3zKHZDUwWQXsqQxjUHW3YhNijl/i1NH/apXTHJXIJTypUaw1VbVjSp 2yBK5s/VFyBowyW5zvCa9qNBUVFOCuVotQxgeGQaLN29vVOmbg0NC/xIUVKV5WqVXhfIhDNA uwh88Wut3ox9TSc9kJX3RZOcsiJemgHSNPzX8Cz4C8AsA1ksoX76OD/xJ10oaGcR+PipWA9b IeQRxQo7WiWcLDPKINw4qTIyEn3DB5Y6pzI4RrYHsX+ij27zo1DVYKk7a1IOsQyYbYRdpfXJ 0NJP909EpB7fKrEWX9LILTf3UvA4mS2vcOMiuFUcgMwdHHi+TpRR2exzxIiA38Yz3lBZgiwm scyMHHBupSHKkkQ89dchXdR7lUV49EsYoCM6q+j0q7dnbvm9GUjXEg7pjJY0Ve/NNXDwrCW0 DYeWdUvlCVWKv/++LC0O35Rk2NUVT13LpY2FAK59ZfOnDXoUfgrntbR58t8UPngo7Pe1hvM= Subject: Re: [PATCH 2/2] tzset_r.c(_tzset_unlocked_r): POSIX angle bracket <> support In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Bar: --- X-Rspamd-Report: BAYES_HAM(-2.991382) MIME_GOOD(-0.1) X-Rspamd-Score: -3.091382 Received: from unknown (HELO unkown) (::1) by deimos.uberspace.de (Haraka/2.8.28) with ESMTPSA; Thu, 07 Apr 2022 18:18:44 +0200 X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00, BODY_8BITS, KAM_DMARC_STATUS, MSGID_FROM_MTA_HEADER, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: newlib@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Newlib mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Apr 2022 16:18:47 -0000 > [..] we are no longer using those predefined values, just those used locally in the code Yes, got that. The comment just confused me. Can it be removed? > Feel free to look at tzset_t.log attached to my ...testing post Great work! Should we actually generate these values with glibc and check whether they match? In the meantime, I've also created some test vectors: [PATCH] add tests for tzset(3) https://sourceware.org/pipermail/newlib/2022/019536.html All tests pass so far. Cheers --- 🙎🏻‍♂️ jdoubleu On 4/7/2022 6:07 PM, Brian Inglis wrote: > On 2022-04-07 03:56, jdoubleu wrote: >>> +#include     /* {,_POSIX_}TZNAME_MAX */ >>> ... > +#define TZNAME_MIN    3    /* POSIX min TZ abbr size local def */ >>> +#define TZNAME_MAX    10    /* POSIX max TZ abbr size local def */ >> >> The comment suggests, that `TZNAME_MAX` is coming from `limits.h`, >> isn't it? > > From previous comments, we are no longer using those predefined values, > just those used locally in the code, and the minimum from the POSIX spec. > >> Everything else looks good to me. >> Unfortunately, I wasn't able to test these changes, yet. I cannot >> easily build newlib for my project. However, I've prepared some tests >> vectors (see >> https://github.com/jdoubleu/newlib-posix-tzset-tests/blob/main/timezones.h), >> which I plan to integrate with the newlib testsuite. > > Feel free to look at tzset_t.log attached to my ...testing post: > >     tzset/_r POSIX tz abbr angle bracket <> support testing >     https://sourceware.org/pipermail/newlib/2022/019529.html > > and add the 103 unique TZ=... values used there, extracted from the end > of the latest tzdb tzdata /usr/share/zoneinfo/ files, as they include > actual exceptional times and offsets to achieve the required transitions > and challenge implementation parsers and calculations. > See the tzcode/tzdata project zic(8)/zdump(8)/tzfile(5) implementation > limits for how wide those limits need to extend. > >> 🙎🏻‍♂️ jdoubleu >> On 4/5/2022 6:03 AM, Brian Inglis wrote: >>> >>> local defines for POSIX minimum TZ abbr size 3 TZNAME_MIN and >>> maximum TZ abbr size supported 10 TZNAME_MAX >>> allow POSIX angle bracket < > quoted signed alphanumeric tz abbr e.g. >>> >>> allow POSIX unquoted alphabetic tz abbr e.g. MESZ >>> allow same suuport for DST tz abbr >>> --- >>>   newlib/libc/time/tzset_r.c | 67 +++++++++++++++++++++++++++++++------- >>>   1 file changed, 55 insertions(+), 12 deletions(-) >