From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from deimos.uberspace.de (deimos.uberspace.de [185.26.156.152]) by sourceware.org (Postfix) with ESMTPS id 8288B3858C50 for ; Thu, 7 Apr 2022 09:38:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 8288B3858C50 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=jdoubleu.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=jdoubleu.de Received: (qmail 1736 invoked by uid 989); 7 Apr 2022 09:38:29 -0000 Authentication-Results: deimos.uberspace.de; auth=pass (plain) Content-Type: multipart/mixed; boundary="------------ZSWdiEb00r0nmCn0N5n4Dtpb" Message-ID: Date: Thu, 7 Apr 2022 11:38:21 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [PATCH] fix testsuite Content-Language: de-DE To: newlib@sourceware.org References: <15d2933b-defd-f5d2-c402-7882dc20271c@jdoubleu.de> From: jdoubleu In-Reply-To: X-Rspamd-Bar: - X-Rspamd-Report: BAYES_HAM(-2.906057) MIME_GOOD(-0.1) MIME_BASE64_TEXT_BOGUS(1) MIME_BASE64_TEXT(0.1) X-Rspamd-Score: -1.906057 Received: from unknown (HELO unkown) (::1) by deimos.uberspace.de (Haraka/2.8.28) with ESMTPSA; Thu, 07 Apr 2022 11:38:28 +0200 X-Spam-Status: No, score=-10.6 required=5.0 tests=BAYES_00, BODY_8BITS, GIT_PATCH_0, KAM_DMARC_STATUS, MSGID_FROM_MTA_HEADER, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: newlib@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Newlib mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Apr 2022 09:38:32 -0000 This is a multi-part message in MIME format. --------------ZSWdiEb00r0nmCn0N5n4Dtpb Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Wasn't sure what to write, since the fix was rather trivial. Appended a patch with some more description. Please feel free to change the commit message, if you think something is still missing. Thanks --- 🙎🏻‍♂️ jdoubleu On 4/1/2022 3:02 PM, Corinna Vinschen wrote: > Hi J, > > On Mar 24 17:54, jdoubleu wrote: >> I found the issue: newlib/testsuite/lib/passfail.exp was using a the >> function `newlib_target_compile` which is defined in newlib.exp but hasn't >> been included yet. >> >> I attached a patch. >> >> Still some tests fail to compile, but that seems more like an issue with the >> host environment or target board. > > Could you please add the description of the error you're seeing to the > commit message of your patch, kind of as in your below first mail? > Just "Fix testsuite" is a bit on the terse side :) > > > Thanks, > Corinna > --------------ZSWdiEb00r0nmCn0N5n4Dtpb Content-Type: text/plain; charset=UTF-8; name="0001-fix-testsuite-cannot-compile-tests.patch" Content-Disposition: attachment; filename="0001-fix-testsuite-cannot-compile-tests.patch" Content-Transfer-Encoding: base64 RnJvbSA2MmEwNGYzYTYxNWQ2YzJkYTIyNzczMzlkM2RjNjBiMzRiNmFjMWM3IE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBqZG91YmxldSA8aGlAamRvdWJsZXUuZGU+CkRhdGU6 IFRodSwgNyBBcHIgMjAyMiAxMTozMTo0MCArMDIwMApTdWJqZWN0OiBbUEFUQ0hdIGZpeCB0 ZXN0c3VpdGUgY2Fubm90IGNvbXBpbGUgdGVzdHMKCkRFSkFHTlUgY291bGQgbm90IGZpbmQg dGhlIGZ1bmN0aW9uICduZXdsaWJfdGFyZ2V0X2NvbXBpbGUnLCBiZWNhdXNlIGl0IHdhcyBk ZWZpbmVkIGluIGFub3RoZXIgZmlsZS4KLS0tCiBuZXdsaWIvdGVzdHN1aXRlL2xpYi9wYXNz ZmFpbC5leHAgfCAyICsrCiAxIGZpbGUgY2hhbmdlZCwgMiBpbnNlcnRpb25zKCspCgpkaWZm IC0tZ2l0IGEvbmV3bGliL3Rlc3RzdWl0ZS9saWIvcGFzc2ZhaWwuZXhwIGIvbmV3bGliL3Rl c3RzdWl0ZS9saWIvcGFzc2ZhaWwuZXhwCmluZGV4IDVlN2ViMjEuLjJjOWFiZjYgMTAwNjQ0 Ci0tLSBhL25ld2xpYi90ZXN0c3VpdGUvbGliL3Bhc3NmYWlsLmV4cAorKysgYi9uZXdsaWIv dGVzdHN1aXRlL2xpYi9wYXNzZmFpbC5leHAKQEAgLTQsNiArNCw4IEBACiAjIGlzIGZyZWVs eSBncmFudGVkLCBwcm92aWRlZCB0aGF0IHRoaXMgbm90aWNlIGlzIHByZXNlcnZlZC4KICMK IAorbG9hZF9saWIgbmV3bGliLmV4cAorCiAjIG5ld2xpYl9wYXNzX2ZhaWxfYWxsIGNvbXBp bGVzIGFuZCBydW5zIGFsbCB0aGUgc291cmNlIGZpbGVzIGluIHRoZQogIyB0ZXN0IGRpcmVj dG9yeS4gSWYgZmxhZyBpcyAteCwgdGhlbiB0aGUgc291cmNlcyB3aG9zZSBiYXNlbmFtZXMg YXJlCiAjIGxpc3RlZCBpbiBleGNsdWRlX2xpc3QgYXJlIG5vdCBjb21waWxlZCBhbmQgcnVu LgotLSAKMi4zNS4xCgo= --------------ZSWdiEb00r0nmCn0N5n4Dtpb--