From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 128309 invoked by alias); 5 Jul 2017 06:06:23 -0000 Mailing-List: contact newlib-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: newlib-owner@sourceware.org Received: (qmail 128267 invoked by uid 89); 5 Jul 2017 06:06:22 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=3.3 required=5.0 tests=AWL,BAYES_00,FOREIGN_BODY,RCVD_IN_DNSWL_NONE,SPF_PASS,T_FILL_THIS_FORM_SHORT autolearn=no version=3.3.2 spammy=geschftliche, mitteilung, Mitteilung, Fax X-HELO: dedi548.your-server.de Received: from dedi548.your-server.de (HELO dedi548.your-server.de) (85.10.215.148) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 05 Jul 2017 06:06:21 +0000 Received: from [88.198.220.130] (helo=sslproxy01.your-server.de) by dedi548.your-server.de with esmtpsa (TLSv1.2:DHE-RSA-AES256-GCM-SHA384:256) (Exim 4.85_2) (envelope-from ) id 1dSdS7-000392-7p for newlib@sourceware.org; Wed, 05 Jul 2017 08:06:19 +0200 Received: from [82.135.62.35] (helo=mail.embedded-brains.de) by sslproxy01.your-server.de with esmtpsa (TLSv1.2:DHE-RSA-AES256-GCM-SHA384:256) (Exim 4.84_2) (envelope-from ) id 1dSdS7-0002Fj-0J for newlib@sourceware.org; Wed, 05 Jul 2017 08:06:19 +0200 Received: from localhost (localhost.localhost [127.0.0.1]) by mail.embedded-brains.de (Postfix) with ESMTP id 42C1F2A004F for ; Wed, 5 Jul 2017 08:06:27 +0200 (CEST) Received: from mail.embedded-brains.de ([127.0.0.1]) by localhost (zimbra.eb.localhost [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id Ab9LCYUYpDw0 for ; Wed, 5 Jul 2017 08:06:25 +0200 (CEST) Received: from localhost (localhost.localhost [127.0.0.1]) by mail.embedded-brains.de (Postfix) with ESMTP id 592892A1677 for ; Wed, 5 Jul 2017 08:06:25 +0200 (CEST) Received: from mail.embedded-brains.de ([127.0.0.1]) by localhost (zimbra.eb.localhost [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id 7ZFNP8yDHTjr for ; Wed, 5 Jul 2017 08:06:25 +0200 (CEST) Received: from [192.168.96.129] (unknown [192.168.96.129]) by mail.embedded-brains.de (Postfix) with ESMTPSA id 36CA92A004F for ; Wed, 5 Jul 2017 08:06:25 +0200 (CEST) Subject: Re: [PATCH 3/3] Add ffsl(), ffsll(), fls(), flsl(), flsll() From: Sebastian Huber To: newlib@sourceware.org References: <20170704133435.9840-1-sebastian.huber@embedded-brains.de> <20170704133435.9840-3-sebastian.huber@embedded-brains.de> Message-ID: Date: Wed, 05 Jul 2017 06:06:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20170704133435.9840-3-sebastian.huber@embedded-brains.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2017/txt/msg00553.txt.bz2 On 04/07/17 15:34, Sebastian Huber wrote: > +int > +fls(int i) > +{ > + > + return (sizeof(i) * CHAR_BIT - __builtin_clz(i)); > +} I just realized that the result of __builtin_clz(i) is undefined if i =3D= =3D=20 0. However, fls(0) should return 0. So this must be changed to: int fls(int i) { if (i =3D=3D 0) return (0); return (sizeof(i) * CHAR_BIT - __builtin_clz(i)); } Similar for flsl() and flsll(). --=20 Sebastian Huber, embedded brains GmbH Address : Dornierstr. 4, D-82178 Puchheim, Germany Phone : +49 89 189 47 41-16 Fax : +49 89 189 47 41-09 E-Mail : sebastian.huber@embedded-brains.de PGP : Public key available on request. Diese Nachricht ist keine gesch=C3=A4ftliche Mitteilung im Sinne des EHUG.