From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from deimos.uberspace.de (deimos.uberspace.de [185.26.156.152]) by sourceware.org (Postfix) with ESMTPS id 0E3113858C50 for ; Thu, 7 Apr 2022 09:56:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 0E3113858C50 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=jdoubleu.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=jdoubleu.de Received: (qmail 15965 invoked by uid 989); 7 Apr 2022 09:56:10 -0000 Authentication-Results: deimos.uberspace.de; auth=pass (plain) Message-ID: Date: Thu, 7 Apr 2022 11:56:02 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [PATCH 2/2] tzset_r.c(_tzset_unlocked_r): POSIX angle bracket <> support Content-Language: de-DE To: newlib@sourceware.org References: <20220405040358.18332-1-Brian.Inglis@SystematicSW.ab.ca> <20220405040358.18332-3-Brian.Inglis@SystematicSW.ab.ca> From: jdoubleu In-Reply-To: <20220405040358.18332-3-Brian.Inglis@SystematicSW.ab.ca> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Bar: -- X-Rspamd-Report: BAYES_HAM(-2.840288) MIME_GOOD(-0.1) X-Rspamd-Score: -2.940288 Received: from unknown (HELO unkown) (::1) by deimos.uberspace.de (Haraka/2.8.28) with ESMTPSA; Thu, 07 Apr 2022 11:56:09 +0200 X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00, BODY_8BITS, KAM_DMARC_STATUS, MSGID_FROM_MTA_HEADER, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: newlib@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Newlib mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Apr 2022 09:56:12 -0000 Hi Brian > +#include /* {,_POSIX_}TZNAME_MAX */ > ... > +#define TZNAME_MIN 3 /* POSIX min TZ abbr size local def */ > +#define TZNAME_MAX 10 /* POSIX max TZ abbr size local def */ The comment suggests, that `TZNAME_MAX` is coming from `limits.h`, isn't it? Everything else looks good to me. Unfortunately, I wasn't able to test these changes, yet. I cannot easily build newlib for my project. However, I've prepared some tests vectors (see https://github.com/jdoubleu/newlib-posix-tzset-tests/blob/main/timezones.h), which I plan to integrate with the newlib testsuite. Cheers --- 🙎🏻‍♂️ jdoubleu On 4/5/2022 6:03 AM, Brian Inglis wrote: > > local defines for POSIX minimum TZ abbr size 3 TZNAME_MIN and > maximum TZ abbr size supported 10 TZNAME_MAX > allow POSIX angle bracket < > quoted signed alphanumeric tz abbr e.g. > allow POSIX unquoted alphabetic tz abbr e.g. MESZ > allow same suuport for DST tz abbr > --- > newlib/libc/time/tzset_r.c | 67 +++++++++++++++++++++++++++++++------- > 1 file changed, 55 insertions(+), 12 deletions(-) >