* [PATCH] really change time_t to 64-bit by default
@ 2017-09-26 9:49 Michael Haubenwallner
2017-09-26 10:04 ` Sebastian Huber
0 siblings, 1 reply; 7+ messages in thread
From: Michael Haubenwallner @ 2017-09-26 9:49 UTC (permalink / raw)
To: newlib; +Cc: sebastian.huber, Michael Haubenwallner
Fix typo for newlib-long-time_t to leave newlib-nano-malloc alone.
---
newlib/configure | 2 +-
newlib/configure.in | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/newlib/configure b/newlib/configure
index eb4b3b2..51b645a 100755
--- a/newlib/configure
+++ b/newlib/configure
@@ -2513,7 +2513,7 @@ if test "${enable_newlib_long_time_t+set}" = set; then :
esac
fi
else
- newlib_nano_malloc=
+ newlib_long_time_t=yes
fi
diff --git a/newlib/configure.in b/newlib/configure.in
index 9d30481..af9b02e 100644
--- a/newlib/configure.in
+++ b/newlib/configure.in
@@ -247,7 +247,7 @@ AC_ARG_ENABLE(newlib-long-time_t,
no) newlib_long_time_t=no ;;
*) AC_MSG_ERROR(bad value ${enableval} for newlib-long-time_t option) ;;
esac
- fi], [newlib_nano_malloc=])dnl
+ fi], [newlib_long_time_t=yes])dnl
NEWLIB_CONFIGURE(.)
--
2.10.2
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] really change time_t to 64-bit by default
2017-09-26 9:49 [PATCH] really change time_t to 64-bit by default Michael Haubenwallner
@ 2017-09-26 10:04 ` Sebastian Huber
2017-09-26 10:31 ` Freddie Chopin
2017-09-26 10:53 ` [PATCH] Fix typo with newlib-long-time_t default value. (WAS: really change time_t to 64-bit by default) Michael Haubenwallner
0 siblings, 2 replies; 7+ messages in thread
From: Sebastian Huber @ 2017-09-26 10:04 UTC (permalink / raw)
To: Michael Haubenwallner, newlib
On 26/09/17 11:07, Michael Haubenwallner wrote:
> Fix typo for newlib-long-time_t to leave newlib-nano-malloc alone.
> ---
> newlib/configure | 2 +-
> newlib/configure.in | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/newlib/configure b/newlib/configure
> index eb4b3b2..51b645a 100755
> --- a/newlib/configure
> +++ b/newlib/configure
> @@ -2513,7 +2513,7 @@ if test "${enable_newlib_long_time_t+set}" = set; then :
> esac
> fi
> else
> - newlib_nano_malloc=
> + newlib_long_time_t=yes
> fi
The default should be:
newlib_long_time_t=no
--
Sebastian Huber, embedded brains GmbH
Address : Dornierstr. 4, D-82178 Puchheim, Germany
Phone : +49 89 189 47 41-16
Fax : +49 89 189 47 41-09
E-Mail : sebastian.huber@embedded-brains.de
PGP : Public key available on request.
Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] really change time_t to 64-bit by default
2017-09-26 10:04 ` Sebastian Huber
@ 2017-09-26 10:31 ` Freddie Chopin
2017-09-26 11:15 ` Sebastian Huber
2017-09-26 10:53 ` [PATCH] Fix typo with newlib-long-time_t default value. (WAS: really change time_t to 64-bit by default) Michael Haubenwallner
1 sibling, 1 reply; 7+ messages in thread
From: Freddie Chopin @ 2017-09-26 10:31 UTC (permalink / raw)
To: newlib
On Tue, 2017-09-26 at 11:49 +0200, Sebastian Huber wrote:
> The default should be:
>
> newlib_long_time_t=no
See - I told you that the name is confusing, implying that previously
the time was "not-long".
Regards,
FCh
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] really change time_t to 64-bit by default
2017-09-26 10:31 ` Freddie Chopin
@ 2017-09-26 11:15 ` Sebastian Huber
2017-09-29 5:35 ` Freddie Chopin
0 siblings, 1 reply; 7+ messages in thread
From: Sebastian Huber @ 2017-09-26 11:15 UTC (permalink / raw)
To: Freddie Chopin, newlib
On 26/09/17 12:03, Freddie Chopin wrote:
> On Tue, 2017-09-26 at 11:49 +0200, Sebastian Huber wrote:
>> The default should be:
>>
>> newlib_long_time_t=no
> See - I told you that the name is confusing, implying that previously
> the time was "not-long".
Previously, the time_t was long. This is exactly what this option enforces.
--
Sebastian Huber, embedded brains GmbH
Address : Dornierstr. 4, D-82178 Puchheim, Germany
Phone : +49 89 189 47 41-16
Fax : +49 89 189 47 41-09
E-Mail : sebastian.huber@embedded-brains.de
PGP : Public key available on request.
Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] really change time_t to 64-bit by default
2017-09-26 11:15 ` Sebastian Huber
@ 2017-09-29 5:35 ` Freddie Chopin
0 siblings, 0 replies; 7+ messages in thread
From: Freddie Chopin @ 2017-09-29 5:35 UTC (permalink / raw)
To: newlib
On Tue, 2017-09-26 at 12:53 +0200, Sebastian Huber wrote:
> Previously, the time_t was long. This is exactly what this option
> enforces.
Sure. I know it, you know it, but other people probably won't. That's
why it is extremely confusing - as you see - and that's why I proposed
to have sth like "--disable-long-long-time_t" or "--disable-int64_t-
time_t" or "--disable-64-bit-time_t" instead, which would possibly be
less confusing. These ./configure options are also meant for casual
users, which don't read newlib's mailing list.
Regards,
FCh
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] Fix typo with newlib-long-time_t default value. (WAS: really change time_t to 64-bit by default)
2017-09-26 10:04 ` Sebastian Huber
2017-09-26 10:31 ` Freddie Chopin
@ 2017-09-26 10:53 ` Michael Haubenwallner
2017-10-09 16:12 ` Corinna Vinschen
1 sibling, 1 reply; 7+ messages in thread
From: Michael Haubenwallner @ 2017-09-26 10:53 UTC (permalink / raw)
To: Sebastian Huber; +Cc: newlib
[-- Attachment #1: Type: text/plain, Size: 965 bytes --]
On 09/26/2017 11:49 AM, Sebastian Huber wrote:
> On 26/09/17 11:07, Michael Haubenwallner wrote:
>
>> Fix typo for newlib-long-time_t to leave newlib-nano-malloc alone.
>> ---
>>  newlib/configure   | 2 +-
>> Â newlib/configure.in | 2 +-
>> Â 2 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/newlib/configure b/newlib/configure
>> index eb4b3b2..51b645a 100755
>> --- a/newlib/configure
>> +++ b/newlib/configure
>> @@ -2513,7 +2513,7 @@ if test "${enable_newlib_long_time_t+set}" = set; then :
>> Â Â Â esac
>> Â Â fi
>> Â else
>> -Â newlib_nano_malloc=
>> +Â newlib_long_time_t=yes
>> Â fi
>
> The default should be:
>
> newlib_long_time_t=no
>
I've just followed your title "Change time_t to 64-bit by default", but indeed
was confused by "can be forced to long with the --enable-newlib-long-time_t" in
your commit message.
However, I do not really care except for the typo.
Thanks!
/haubi/
[-- Attachment #2: 0001-Fix-typo-with-newlib-long-time_t-default-value.patch --]
[-- Type: text/x-patch, Size: 1121 bytes --]
From 53fa5ed5461788adf3ff04ee7eb05643c1b73c79 Mon Sep 17 00:00:00 2001
From: Michael Haubenwallner <michael.haubenwallner@ssi-schaefer.com>
Date: Tue, 26 Sep 2017 10:38:12 +0200
Subject: [PATCH] Fix typo with newlib-long-time_t default value.
Fix typo for newlib-long-time_t to leave newlib-nano-malloc alone.
---
newlib/configure | 2 +-
newlib/configure.in | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/newlib/configure b/newlib/configure
index eb4b3b2..9613214 100755
--- a/newlib/configure
+++ b/newlib/configure
@@ -2513,7 +2513,7 @@ if test "${enable_newlib_long_time_t+set}" = set; then :
esac
fi
else
- newlib_nano_malloc=
+ newlib_long_time_t=no
fi
diff --git a/newlib/configure.in b/newlib/configure.in
index 9d30481..adce036 100644
--- a/newlib/configure.in
+++ b/newlib/configure.in
@@ -247,7 +247,7 @@ AC_ARG_ENABLE(newlib-long-time_t,
no) newlib_long_time_t=no ;;
*) AC_MSG_ERROR(bad value ${enableval} for newlib-long-time_t option) ;;
esac
- fi], [newlib_nano_malloc=])dnl
+ fi], [newlib_long_time_t=no])dnl
NEWLIB_CONFIGURE(.)
--
2.10.2
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] Fix typo with newlib-long-time_t default value. (WAS: really change time_t to 64-bit by default)
2017-09-26 10:53 ` [PATCH] Fix typo with newlib-long-time_t default value. (WAS: really change time_t to 64-bit by default) Michael Haubenwallner
@ 2017-10-09 16:12 ` Corinna Vinschen
0 siblings, 0 replies; 7+ messages in thread
From: Corinna Vinschen @ 2017-10-09 16:12 UTC (permalink / raw)
To: newlib
[-- Attachment #1: Type: text/plain, Size: 1375 bytes --]
On Sep 26 12:31, Michael Haubenwallner wrote:
> >From 53fa5ed5461788adf3ff04ee7eb05643c1b73c79 Mon Sep 17 00:00:00 2001
> From: Michael Haubenwallner <michael.haubenwallner@ssi-schaefer.com>
> Date: Tue, 26 Sep 2017 10:38:12 +0200
> Subject: [PATCH] Fix typo with newlib-long-time_t default value.
>
> Fix typo for newlib-long-time_t to leave newlib-nano-malloc alone.
> ---
> newlib/configure | 2 +-
> newlib/configure.in | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/newlib/configure b/newlib/configure
> index eb4b3b2..9613214 100755
> --- a/newlib/configure
> +++ b/newlib/configure
> @@ -2513,7 +2513,7 @@ if test "${enable_newlib_long_time_t+set}" = set; then :
> esac
> fi
> else
> - newlib_nano_malloc=
> + newlib_long_time_t=no
> fi
>
>
> diff --git a/newlib/configure.in b/newlib/configure.in
> index 9d30481..adce036 100644
> --- a/newlib/configure.in
> +++ b/newlib/configure.in
> @@ -247,7 +247,7 @@ AC_ARG_ENABLE(newlib-long-time_t,
> no) newlib_long_time_t=no ;;
> *) AC_MSG_ERROR(bad value ${enableval} for newlib-long-time_t option) ;;
> esac
> - fi], [newlib_nano_malloc=])dnl
> + fi], [newlib_long_time_t=no])dnl
>
> NEWLIB_CONFIGURE(.)
>
> --
> 2.10.2
>
Pushed.
Thanks,
Corinna
--
Corinna Vinschen
Cygwin Maintainer
Red Hat
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2017-10-09 16:10 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-09-26 9:49 [PATCH] really change time_t to 64-bit by default Michael Haubenwallner
2017-09-26 10:04 ` Sebastian Huber
2017-09-26 10:31 ` Freddie Chopin
2017-09-26 11:15 ` Sebastian Huber
2017-09-29 5:35 ` Freddie Chopin
2017-09-26 10:53 ` [PATCH] Fix typo with newlib-long-time_t default value. (WAS: really change time_t to 64-bit by default) Michael Haubenwallner
2017-10-09 16:12 ` Corinna Vinschen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).