From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from re-prd-fep-042.btinternet.com (mailomta20-re.btinternet.com [213.120.69.113]) by sourceware.org (Postfix) with ESMTPS id CA2393858D37 for ; Sun, 23 Aug 2020 19:41:31 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org CA2393858D37 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=dronecode.org.uk Authentication-Results: sourceware.org; spf=none smtp.mailfrom=jon.turney@dronecode.org.uk Received: from re-prd-rgout-004.btmx-prd.synchronoss.net ([10.2.54.7]) by re-prd-fep-042.btinternet.com with ESMTP id <20200823194130.YAXQ13627.re-prd-fep-042.btinternet.com@re-prd-rgout-004.btmx-prd.synchronoss.net>; Sun, 23 Aug 2020 20:41:30 +0100 Authentication-Results: btinternet.com; auth=pass (PLAIN) smtp.auth=jonturney@btinternet.com X-Originating-IP: [86.141.129.205] X-OWM-Source-IP: 86.141.129.205 (GB) X-OWM-Env-Sender: jonturney@btinternet.com X-VadeSecure-score: verdict=clean score=0/300, class=clean X-RazorGate-Vade: gggruggvucftvghtrhhoucdtuddrgeduiedrudduiedgudegtdcutefuodetggdotefrodftvfcurfhrohhfihhlvgemuceutffkvffkuffjvffgnffgvefqofdpqfgfvfenuceurghilhhouhhtmecufedtudenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhepuffvfhfhkffffgggjggtgfesthekredttdefjeenucfhrhhomheplfhonhcuvfhurhhnvgihuceojhhonhdrthhurhhnvgihsegurhhonhgvtghouggvrdhorhhgrdhukheqnecuggftrfgrthhtvghrnhepleeigeehgefhveefvefhvdeiudfgvdeuhfejheetjefffefhueduteehuefgfffhnecukfhppeekiedrudeguddruddvledrvddtheenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhephhgvlhhopegludelvddrudeikedruddrudduudgnpdhinhgvthepkeeirddugedurdduvdelrddvtdehpdhmrghilhhfrhhomhepoehjohhnrdhtuhhrnhgvhiesughrohhnvggtohguvgdrohhrghdruhhkqecuuefqffgjpeekuefkvffokffogfdprhgtphhtthhopeeokhgsrhhofihnsegtohhrnhgvlhhlrdgvughuqedprhgtphhtthhopeeonhgvfihlihgssehsohhurhgtvgifrghrvgdrohhrgheq X-RazorGate-Vade-Verdict: clean 0 X-RazorGate-Vade-Classification: clean Received: from [192.168.1.111] (86.141.129.205) by re-prd-rgout-004.btmx-prd.synchronoss.net (5.8.340) (authenticated as jonturney@btinternet.com) id 5ED9C5060D35C535; Sun, 23 Aug 2020 20:41:30 +0100 Subject: Re: [PATCH] doc: Various fixes to makedocbook for python3.8 To: "newlib@sourceware.org" References: <20200822184520.57006-1-jon.turney@dronecode.org.uk> From: Jon Turney Message-ID: Date: Sun, 23 Aug 2020 20:41:30 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-9.7 required=5.0 tests=BAYES_00, FORGED_SPF_HELO, GIT_PATCH_0, KAM_DMARC_STATUS, KAM_LAZY_DOMAIN_SECURITY, KAM_NUMSUBJECT, NICE_REPLY_A, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_PASS, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: newlib@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Newlib mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 23 Aug 2020 19:41:33 -0000 On 23/08/2020 16:23, Ken Brown wrote: > On 8/22/2020 2:45 PM, Jon Turney wrote: >> --- >>   newlib/doc/makedocbook.py | 8 +++++--- >>   1 file changed, 5 insertions(+), 3 deletions(-) >> >> diff --git a/newlib/doc/makedocbook.py b/newlib/doc/makedocbook.py >> index 92d0f279d..3fab26f1a 100755 >> --- a/newlib/doc/makedocbook.py >> +++ b/newlib/doc/makedocbook.py [...] > Would it make sense to also change the shebang line so that > makedocbook.py uses python3?  Currently the build of Cygwin on Fedora > uses python3, but the build of Cygwin on Cygwin uses python2.  This is > of no great importance, but a recent IRC discussion shows that it can be > confusing. Yeah, I guess that would make some sense, given that python2 is now EOL. Otoh, making it gratuitously not work with python2 seems a bit harsh. On the gripping hand, reading PEP 0394, I see it doesn't actually require that 'python' exist at all, so I guess changing the shebang as you suggest is the right thing to do.