From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from esa2.mentor.iphmx.com (esa2.mentor.iphmx.com [68.232.141.98]) by sourceware.org (Postfix) with ESMTPS id 2AB5D3858C50 for ; Wed, 6 Apr 2022 05:11:49 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 2AB5D3858C50 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=codesourcery.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mentor.com X-IronPort-AV: E=Sophos;i="5.90,239,1643702400"; d="scan'208";a="74124011" Received: from orw-gwy-02-in.mentorg.com ([192.94.38.167]) by esa2.mentor.iphmx.com with ESMTP; 05 Apr 2022 21:11:46 -0800 IronPort-SDR: valb9C5LsVEm9iS0DzpugaLJ/W//ja6s7XYWeCIZoZVetyciU2sb5OOZ7Ho1kvi33a6fiUhy32 B+Ig4jGXcglLomI9cpcWapL9wX4TQZJhRaZSt5yAZnWLIySvjVAj9HHBV7KW2EUYEWDiBZIPQd O9h8qDI8/+KmL2PR7IwS4VCQkIJBLzTQ0cbW2izF/aPzCoiuYVMYsLgv2KqywD2ZChkZEsLmBu CINNBXPo4YG6SP6QkiHBd92YnTqM13eeaQHrG3BTGs60Jpgj/pOO1KK10k85sXSSWPLcUGOkpo 3qk= Message-ID: Date: Wed, 6 Apr 2022 07:11:29 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: *ping* [Patch] (2/n) newlib: Move vasniprintf.c to ELIX 1 (was: Build-dependency issues with ELIX_LEVEL) Content-Language: en-US From: Tobias Burnus To: References: <0e04b11a-1b6d-c70a-c0fe-4ece59996461@codesourcery.com> <974300f4-f4cc-2645-ae6e-75514a93a8b4@codesourcery.com> In-Reply-To: <974300f4-f4cc-2645-ae6e-75514a93a8b4@codesourcery.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: quoted-printable X-Originating-IP: [137.202.0.90] X-ClientProxiedBy: SVR-IES-MBX-08.mgc.mentorg.com (139.181.222.8) To svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1) X-Spam-Status: No, score=-5.4 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: newlib@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Newlib mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 06 Apr 2022 05:11:50 -0000 *ping* On 30.03.22 12:56, Tobias Burnus wrote: > Attached is a revised version of the patch in the first email in the > thread. > Found when looking for referenced but not provided functions > with nvptx, which sets ELIX Level to 1. > > > libc/stdio/vdiprintf.c's _vdiprintf_r calls _vasniprintf_r > The file is compiled with ELIX Level 1. > > The function _vasniprintf_r is provided either via > * libc/stdio/vasniprintf.c which calls _svfiprintf_r > * libc/stdio/vasnprintf.c (only '#ifdef _NANO_FORMATTED_IO') > which calls _svfprintf_r > > We can ignore the second file as no NANO function calls > it. Thus, only the first file (vasniprintf.c) remains. > > The _svfiprintf_r / _svfiprintf_r are provided by > libc/stdio/(nano-)vfprintf.c > Those files are also available with ELIX Level 1. > > > Solution: Also build vasniprintf.c with ELIX Level 1 > instead of building it with ELIX Level 4. > > The change should be save as the only library call I see > in that file (vasniprintf.c) is to vfprintf.c. And on the > caller side, the call to _vasniprintf_r is not guarded by > any #if. Thus, no new dependencies should get introduced > by this change. > > > OK? Comments? > > Tobias > (Makefile.inc patch + regenerated Makefile.in as separate patch) ----------------- Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstra=C3=9Fe 201= , 80634 M=C3=BCnchen; Gesellschaft mit beschr=C3=A4nkter Haftung; Gesch=C3= =A4ftsf=C3=BChrer: Thomas Heurung, Frank Th=C3=BCrauf; Sitz der Gesellschaf= t: M=C3=BCnchen; Registergericht M=C3=BCnchen, HRB 106955