From: Paul Zimmermann <Paul.Zimmermann@inria.fr>
To: Andoni Arregi <andoni.arregui@gtd-gmbh.de>
Cc: newlib@sourceware.org, andoni.arregui@gtd-gmbh.de
Subject: Re: [PATCH 0/4] Fix huge error for pow detected by Paul Zimmermann
Date: Thu, 13 Apr 2023 14:16:31 +0200 [thread overview]
Message-ID: <p9u0edoo6kps.fsf@coriandre.loria.fr> (raw)
In-Reply-To: <20230412153445.161047-1-andoni.arregui@gtd-gmbh.de> (message from Andoni Arregi on Wed, 12 Apr 2023 17:34:41 +0200)
Hi Andoni,
I had time to check this patch series on top of be2749c.
I confirm the issue I reported is fixed.
In addition, the maximal known error, which was 636 ulps
apart from the above issue, has dropped to less than 1 ulp:
pow 0 -1 0x1.4c3064d46aef3p-851,-0x1.cef4118ed50c2p-10 [0.893] 0.892119 0.8921192373561432
Thank you, great work!
Paul
> From: Andoni Arregi <andoni.arregui@gtd-gmbh.de>
> Cc: Andoni Arregi <andoni.arregui@gtd-gmbh.de>
> Date: Wed, 12 Apr 2023 17:34:41 +0200
>
> This patch series fixes in pow the huge error detected by Paul
> Zimmermann where x is negative and y is a large odd integer.
>
> There is also an accuracy fix for cases where x is close to 1 and y is
> large.
>
> Andoni Arregi (4):
> Fix missing sign for overflow/underflow where x is negative and y is
> large odd integer
> Fix x close to 1, y between 2^31 and 2^64
> Compare j as unsigned
> Replace always true if with else
>
> newlib/libm/math/e_pow.c | 48 +++++++++++++++++++++-------------------
> 1 file changed, 25 insertions(+), 23 deletions(-)
>
> --
> 2.40.0
>
>
>
next prev parent reply other threads:[~2023-04-13 12:21 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-12 15:34 Andoni Arregi
2023-04-12 15:34 ` [PATCH 1/4] Fix missing sign for overflow/underflow where x is negative and y is large odd integer Andoni Arregi
2023-04-12 15:34 ` [PATCH 2/4] Fix x close to 1, y between 2^31 and 2^64 Andoni Arregi
2023-04-12 15:34 ` [PATCH 3/4] Compare j as unsigned Andoni Arregi
2023-04-12 15:34 ` [PATCH 4/4] Replace always true if with else Andoni Arregi
2023-04-13 5:46 ` [PATCH 0/4] Fix huge error for pow detected by Paul Zimmermann Paul Zimmermann
2023-04-13 12:16 ` Paul Zimmermann [this message]
2023-04-13 14:39 ` Andoni Arregi
2023-04-13 17:37 ` Jeff Johnston
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=p9u0edoo6kps.fsf@coriandre.loria.fr \
--to=paul.zimmermann@inria.fr \
--cc=andoni.arregui@gtd-gmbh.de \
--cc=newlib@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).