From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gnu.wildebeest.org (wildebeest.demon.nl [212.238.236.112]) by sourceware.org (Postfix) with ESMTPS id CFB5C385F02A for ; Fri, 20 Mar 2020 18:03:15 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org CFB5C385F02A Received: from tarox.wildebeest.org (tarox.wildebeest.org [172.31.17.39]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by gnu.wildebeest.org (Postfix) with ESMTPSA id 84F7230447E4; Fri, 20 Mar 2020 19:03:14 +0100 (CET) Received: by tarox.wildebeest.org (Postfix, from userid 1000) id 6AB674000866; Fri, 20 Mar 2020 19:03:14 +0100 (CET) Message-ID: <0022ee64ca48b6f8f64458c81a5fab0021318744.camel@klomp.org> Subject: Re: list From mangling and git am From: Mark Wielaard To: "Frank Ch. Eigler" , Overseers mailing list Cc: Matthias Maennich Date: Fri, 20 Mar 2020 19:03:14 +0100 In-Reply-To: <20200316130654.GK79471@elastic.org> References: <20200316121624.GC39901@wildebeest.org> <20200316123210.GC211970@google.com> <20200316130654.GK79471@elastic.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Mailer: Evolution 3.28.5 (3.28.5-5.el7) Mime-Version: 1.0 X-Spam-Status: No, score=-1.4 required=5.0 tests=BAYES_00, JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS, SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: overseers@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Overseers mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 Mar 2020 18:03:17 -0000 Hi, On Mon, 2020-03-16 at 09:06 -0400, Frank Ch. Eigler wrote: > The mailinglist From/Reply-To mangling doesn't interact nicely > > > with git am. [...] >=20 > As you know, increasing mail security/spam measures are what is > driving cleanliness with respect to mailing list systems. Even as we > speak, we have outgoing email from sourceware to important receivers > like gmail -blocked- because the receiver doesn't think we are clean > enough. So I suspect we'll need to retain/enhance these measures > rather than roll them back. Rolling things back is probably not a good idea. There are two ways you can go, strip dkim headers and rewrite From/Reply-To, or make sure you keep the original headers and body in tact (no Reply-to mangling, no subject rewriting, no body or attachment rewriting/removing) so the dkim signature is correct. The first is probably less work and they easiest way to comply with any dmarc policy. The second is probably more work since you have to make sure that no part of the mailing-list pipeline mangles the original email in any way. > For git am workflows, consider: >=20 > - running "git amend --author=3D<....>" after "git am" to fix things Yes, this is what I am using now. But it is slightly inconvenient since it is easy to forget and you cannot easily script it. > - asking submitters to use "git format-patch --from=3D"Real Name git > <...>" > where the enclosed name is different enough that git format-patch > includes a second From: header in the body, which git-am prefers This works but only if the "real from" (Author) is slightly different from the normal From. So if I do --from=3D"Mark J. Wielaard " while the Author is "Mark Wielaard " then the Body of the email will start with a From: Mark Wielaard < mark@klomp.org> which git am will pick up correctly. This should be possible to script (on the sender side). But it is odd there is no git send-email option to always generate this extra "Body From:". That would be ideal. Maybe it is something that upstream git could consider adding for mailing-lists that mangle From headers? Cheers, Mark