From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6630 invoked by alias); 29 Jul 2003 20:57:07 -0000 Mailing-List: contact overseers-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Archive: List-Post: List-Help: , Sender: overseers-owner@sources.redhat.com Received: (qmail 6623 invoked from network); 29 Jul 2003 20:57:06 -0000 Received: from unknown (HELO disaster.jaj.com) (66.93.21.106) by sources.redhat.com with SMTP; 29 Jul 2003 20:57:06 -0000 Received: from disaster.jaj.com (localhost.localhost [127.0.0.1]) by disaster.jaj.com (8.12.9/8.12.9) with ESMTP id h6TKv0w4025338 for ; Tue, 29 Jul 2003 16:57:00 -0400 Received: (from phil@localhost) by disaster.jaj.com (8.12.9/8.12.9/Submit) id h6TKv0vf025337 for overseers@sources.redhat.com; Tue, 29 Jul 2003 16:57:00 -0400 Date: Tue, 29 Jul 2003 20:57:00 -0000 From: Phil Edwards To: overseers@sources.redhat.com Subject: commit_prep perl question Message-ID: <20030729205700.GA23614@disaster.jaj.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.3i X-SW-Source: 2003-q3/txt/msg00107.txt.bz2 Okay, actually two questions: 1) How do I test changes to commit_prep before presenting them for approval? 2) In the generalized commit_prep, there is basically this code: sub check_version { local($filename, $cvsversion) = @_; .... $cvsversion{...} .... } .... $cvsversion{...} = ....; foreach $arg (@files) { &check_version($arg); } check_version is passed one argument, but accepts two, and the second local formal parameter name is the same as a global hash variable name. Is this a bug, or does perl actually work like that? Phil -- If ye love wealth greater than liberty, the tranquility of servitude greater than the animating contest for freedom, go home and leave us in peace. We seek not your counsel, nor your arms. Crouch down and lick the hand that feeds you; and may posterity forget that ye were our countrymen. - Samuel Adams