From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22340 invoked by alias); 2 Apr 2004 16:17:45 -0000 Mailing-List: contact overseers-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Archive: List-Post: List-Help: , Sender: overseers-owner@sources.redhat.com Received: (qmail 22300 invoked from network); 2 Apr 2004 16:17:43 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sources.redhat.com with SMTP; 2 Apr 2004 16:17:43 -0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.12.10/8.12.10) with ESMTP id i32GHhjj011409 for ; Fri, 2 Apr 2004 11:17:43 -0500 Received: from pobox.toronto.redhat.com (pobox.toronto.redhat.com [172.16.14.4]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id i32GHgj07986; Fri, 2 Apr 2004 11:17:42 -0500 Received: from touchme.toronto.redhat.com (IDENT:postfix@touchme.toronto.redhat.com [172.16.14.9]) by pobox.toronto.redhat.com (8.12.8/8.12.8) with ESMTP id i32GHgf7032466; Fri, 2 Apr 2004 11:17:42 -0500 Received: from toenail.toronto.redhat.com (toenail.toronto.redhat.com [172.16.14.211]) by touchme.toronto.redhat.com (Postfix) with ESMTP id DC84D80008E; Fri, 2 Apr 2004 11:17:41 -0500 (EST) Received: from toenail.toronto.redhat.com (localhost.localdomain [127.0.0.1]) by toenail.toronto.redhat.com (8.12.10/8.12.5) with ESMTP id i32GHfHl029338; Fri, 2 Apr 2004 11:17:41 -0500 Received: (from fche@localhost) by toenail.toronto.redhat.com (8.12.10/8.12.10/Submit) id i32GHfPT029336; Fri, 2 Apr 2004 11:17:41 -0500 Date: Fri, 02 Apr 2004 16:17:00 -0000 From: "Frank Ch. Eigler" To: overseers@sources.redhat.com Cc: rmathew@hotmail.com Subject: Re: Error trying to get CVS write access via web-form Message-ID: <20040402161740.GH26117@redhat.com> References: <20040402155707.GC1144@coc.bosbc.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20040402155707.GC1144@coc.bosbc.com> User-Agent: Mutt/1.4.1i X-SW-Source: 2004-q2/txt/msg00006.txt.bz2 cgf wrote: > [...] > >I think this regex should either be corrected or the page should > >explain that the comment can only be of this form. > > You have the source, right? Does anything suggest itself to you? Would committing this patch bother anyone? Index: ps_form.cgi =================================================================== RCS file: /cvs/sourceware/cgi-bin/pdw/ps_form.cgi,v retrieving revision 1.41 diff -u -r1.41 ps_form.cgi --- ps_form.cgi 30 Sep 2003 15:27:04 -0000 1.41 +++ ps_form.cgi 2 Apr 2004 16:16:21 -0000 @@ -87,7 +87,7 @@ &start_html; if ($ssh_key !~ /^\s*\d{3,}\s+\d+\s+\d{100,}(\s+[^\n]*)?$/ - && $ssh_key !~ /^ssh-[rd]s[as]\s+\S+\s+\S+\@\S+$/o + && $ssh_key !~ /^ssh-[rd]s[as]\s+\S+(\s+[^\n]*)?$/o && $ssh_key !~ /gnats only/o) { print "Your identity.pub entry is incorrectly formatted. Please press Back on your browser and copy the contents of your identity.pub file into the form. If you believe you have gotten this message erroneously, please submit a complete bug report to overseers\@sources.redhat.com.

"; - FChE