From: Christopher Faylor <cgf@alum.bu.edu>
To: "Frank Ch. Eigler" <fche@redhat.com>
Cc: overseers@sources.redhat.com, rmathew@hotmail.com
Subject: Re: Error trying to get CVS write access via web-form
Date: Fri, 02 Apr 2004 16:41:00 -0000 [thread overview]
Message-ID: <20040402164058.GH1144@coc.bosbc.com> (raw)
In-Reply-To: <20040402161740.GH26117@redhat.com>
On Fri, Apr 02, 2004 at 11:17:40AM -0500, Frank Ch. Eigler wrote:
>cgf wrote:
>> [...]
>> >I think this regex should either be corrected or the page should
>> >explain that the comment can only be of this form.
>>
>> You have the source, right? Does anything suggest itself to you?
>
>Would committing this patch bother anyone?
Doesn't the comment part have to include something with an '@' in it?
Doesn't your change essentially make the validity check "See if there
is something following a space at the end of the line. If there is
then that's good, otherwise, that's good too."
Of course, that's what the previous line does, too, so I guess it's in
good company.
cgf
>Index: ps_form.cgi
>===================================================================
>RCS file: /cvs/sourceware/cgi-bin/pdw/ps_form.cgi,v
>retrieving revision 1.41
>diff -u -r1.41 ps_form.cgi
>--- ps_form.cgi 30 Sep 2003 15:27:04 -0000 1.41
>+++ ps_form.cgi 2 Apr 2004 16:16:21 -0000
>@@ -87,7 +87,7 @@
> &start_html;
>
> if ($ssh_key !~ /^\s*\d{3,}\s+\d+\s+\d{100,}(\s+[^\n]*)?$/
>- && $ssh_key !~ /^ssh-[rd]s[as]\s+\S+\s+\S+\@\S+$/o
>+ && $ssh_key !~ /^ssh-[rd]s[as]\s+\S+(\s+[^\n]*)?$/o
> && $ssh_key !~ /gnats only/o)
> {
> print "Your identity.pub entry is incorrectly formatted. Please press Back on your browser and copy the contents of your identity.pub file into the form. If you believe you have gotten this message erroneously, please submit a complete bug report to <a href=\"mailto:overseers\@sources.redhat.com\">overseers\@sources.redhat.com</a>.<p>";
>
>
>- FChE
next prev parent reply other threads:[~2004-04-02 16:41 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-04-02 12:37 Ranjit Mathew
2004-04-02 15:57 ` Christopher Faylor
2004-04-02 16:17 ` Frank Ch. Eigler
2004-04-02 16:41 ` Christopher Faylor [this message]
2004-04-02 16:45 ` Frank Ch. Eigler
2004-04-02 16:57 ` Christopher Faylor
2004-04-02 17:08 ` Frank Ch. Eigler
2004-04-02 17:23 ` Christopher Faylor
2004-04-02 17:29 ` Frank Ch. Eigler
2004-04-02 17:40 ` Christopher Faylor
2004-04-02 18:06 ` Christopher Faylor
2004-04-02 18:15 ` Frank Ch. Eigler
2004-04-02 19:16 ` Christopher Faylor
-- strict thread matches above, loose matches on Subject: below --
2004-04-01 6:59 Ranjit Mathew
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040402164058.GH1144@coc.bosbc.com \
--to=cgf@alum.bu.edu \
--cc=fche@redhat.com \
--cc=overseers@sources.redhat.com \
--cc=rmathew@hotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).