From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9079 invoked by alias); 2 Apr 2004 16:41:02 -0000 Mailing-List: contact overseers-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Archive: List-Post: List-Help: , Sender: overseers-owner@sources.redhat.com Received: (qmail 9002 invoked from network); 2 Apr 2004 16:40:58 -0000 Received: from unknown (HELO bosbc.com) (66.30.22.40) by sources.redhat.com with SMTP; 2 Apr 2004 16:40:58 -0000 Received: by bosbc.com (Postfix, from userid 201) id 5631C400023; Fri, 2 Apr 2004 11:40:58 -0500 (EST) Date: Fri, 02 Apr 2004 16:41:00 -0000 From: Christopher Faylor To: "Frank Ch. Eigler" Cc: overseers@sources.redhat.com, rmathew@hotmail.com Subject: Re: Error trying to get CVS write access via web-form Message-ID: <20040402164058.GH1144@coc.bosbc.com> Mail-Followup-To: "Frank Ch. Eigler" , overseers@sources.redhat.com, rmathew@hotmail.com References: <20040402155707.GC1144@coc.bosbc.com> <20040402161740.GH26117@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20040402161740.GH26117@redhat.com> User-Agent: Mutt/1.4.1i X-SW-Source: 2004-q2/txt/msg00007.txt.bz2 On Fri, Apr 02, 2004 at 11:17:40AM -0500, Frank Ch. Eigler wrote: >cgf wrote: >> [...] >> >I think this regex should either be corrected or the page should >> >explain that the comment can only be of this form. >> >> You have the source, right? Does anything suggest itself to you? > >Would committing this patch bother anyone? Doesn't the comment part have to include something with an '@' in it? Doesn't your change essentially make the validity check "See if there is something following a space at the end of the line. If there is then that's good, otherwise, that's good too." Of course, that's what the previous line does, too, so I guess it's in good company. cgf >Index: ps_form.cgi >=================================================================== >RCS file: /cvs/sourceware/cgi-bin/pdw/ps_form.cgi,v >retrieving revision 1.41 >diff -u -r1.41 ps_form.cgi >--- ps_form.cgi 30 Sep 2003 15:27:04 -0000 1.41 >+++ ps_form.cgi 2 Apr 2004 16:16:21 -0000 >@@ -87,7 +87,7 @@ > &start_html; > > if ($ssh_key !~ /^\s*\d{3,}\s+\d+\s+\d{100,}(\s+[^\n]*)?$/ >- && $ssh_key !~ /^ssh-[rd]s[as]\s+\S+\s+\S+\@\S+$/o >+ && $ssh_key !~ /^ssh-[rd]s[as]\s+\S+(\s+[^\n]*)?$/o > && $ssh_key !~ /gnats only/o) > { > print "Your identity.pub entry is incorrectly formatted. Please press Back on your browser and copy the contents of your identity.pub file into the form. If you believe you have gotten this message erroneously, please submit a complete bug report to overseers\@sources.redhat.com.

"; > > >- FChE