* Re: [PATCH] Fix value-dynamic-type
[not found] ` <87d24ozysg.fsf@igalia.com>
@ 2015-03-06 16:51 ` Doug Evans
2015-03-06 16:56 ` Frank Ch. Eigler
0 siblings, 1 reply; 2+ messages in thread
From: Doug Evans @ 2015-03-06 16:51 UTC (permalink / raw)
To: Andy Wingo; +Cc: overseers
Ah, righto, you need an account on sourceware.org.
I believe the procedure is to send a message to overseers@sourceware.org, cc'd,
with your key.
On Wed, Mar 4, 2015 at 5:18 AM, Andy Wingo <wingo@igalia.com> wrote:
> Greets :)
>
> I don't think I have commit rights, though I'm happy to do that if it's
> the right thing. (We are off-list; happy to go on-list as
> appropriate).
>
> My SSH key fingerprint:
>
> ssh-rsa AAAAB3NzaC1yc2EAAAABIwAAAgEAniIBKe3+toYN/4MtEnN8osjwkrlYlXfdRU1vXtjE1MRbPyiQ2D1MVFx6VWRz7VAKXToUeRqAqSm5jS+34r5erKbNGJnRcyOjryyDGCvwAHcVeAg0dbR75uwesw+0Bymhqw8CSCjauySWusMmB1is6Bow7G+tv9I91Pkky1WrgYu/JQDRpN00GCGbhrS2h2JaqIlgXRuzj9/ls8iJnPDNMi1qGoQBWXOhPFxURZMBPdUgFQeayQ96NvZdSHDlKCEgv9Nu1zvfpKsR34gwuC/V3/+DRvsRERXb3gLRQaZAPEAkAn/Qwu/SAMe7shgdKRiQqnpNsDGRWHCVX3E7QpSjqqmfbWaoKG1MITmm+4B/b+OWNThANCNxmkw+YSgqPnXcwfot5pBNGL/2MwdYLr9shidRrd2s2Sy+vLdaBlaaKSMuCIWt3JtVmj+yxXjJmHrnaj+oiNLTI/++La52smRgU9mk+0888Uz852p9WjeQ9C3dd07sdx96pGWDSkmUmoOaLxyn1ypIm5PvOoSZXs9/82sE5JUPmlVgPr9mF2vDYmydAo56uk9qUXD/4pdddzlWfmldsIoo4cAYFG+4tTcwOG/6TDeSWv0sS+9Gw1BBGvYLMpXBBn8TtRRt+jEDyvV2u7U5VK/h/wcPIVyiVXQkdOrkAOC3THVb8CUo+yWevHU= wingo@harpy.local
>
> Thanks for the tip about commit messages, will fix.
>
> Andy
>
> On Wed 04 Mar 2015 09:42, Doug Evans <xdje42@gmail.com> writes:
>
>> Hi.
>> Once a patch has been approved people generally commit their own patches.
>> But we're happy to commit them for contributors if necessary/desired.
>>
>> For reference sake, in addition to the rules for submitting a patch,
>> there are also rules for how to format the commit message.
>>
>> https://sourceware.org/gdb/wiki/ContributionChecklist#Properly_formatted_commit_messages
>>
>> On Wed, Mar 4, 2015 at 12:02 AM, Andy Wingo <wingo@igalia.com> wrote:
>>> Hi Doug,
>>>
>>> What's the process for landing patches? I don't see this one in
>>> origin/master.
>>>
>>> Thanks,
>>>
>>> Andy
>>>
>>> On Sun 22 Feb 2015 18:36, Doug Evans <xdje42@gmail.com> writes:
>>>
>>>> Andy Wingo <wingo@igalia.com> writes:
>>>>> Hi,
>>>>>
>>>>> The attached patch fixes a typo in value-dynamic-type that could cause
>>>>> it to return #<undefined>.
>>>>>
>>>>> Andy
>>>>>
>>>>>
>>>>> From c428975bbbf4521766e13d158b12f41392c6bc5e Mon Sep 17 00:00:00 2001
>>>>> From: Andy Wingo <wingo@igalia.com>
>>>>> Date: Fri, 20 Feb 2015 09:55:25 +0100
>>>>> Subject: [PATCH] Fix typo in value-dynamic-type
>>>>>
>>>>> gdb/ChangeLog:
>>>>> 2015-02-20 Andy Wingo <wingo@igalia.com>
>>>>>
>>>>> * guile/scm-value.c (gdbscm_value_dynamic_type): Fix typo in which
>>>>> we were checking the cached type, not the cached dynamic type.
>>>>
>>>> LGTM
^ permalink raw reply [flat|nested] 2+ messages in thread