From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-x436.google.com (mail-wr1-x436.google.com [IPv6:2a00:1450:4864:20::436]) by sourceware.org (Postfix) with ESMTPS id 78F6F385E000 for ; Sun, 22 Mar 2020 21:15:22 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 78F6F385E000 Received: by mail-wr1-x436.google.com with SMTP id z15so14487984wrl.1 for ; Sun, 22 Mar 2020 14:15:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=cV6ewn10ou5o/YTCV6TSM7MNAHm9o7kth6kXVDJi+Xg=; b=K8MtyGEFwOzMgexP+6c0jOe6ahFCUN5oGTFI20KTShRBeLKffGMbdQQgiM6Ig0JExL QXZYw2jfxSC7phEzJ8/x3p/neX822v7+RRe2pDYzG1hnStCuFoH9dLngGVnU9HEryLft CL8wEyCoMEujTjciq55Wca01cu3yEYRnH7VMgZXA3O6w2k/rGHbAoBv1bX3giS+Z8frj fBjnDnHMkCCWN9A40z6ORWk53p7h0HgiHadjMcEarY/i3rds/WFACZtOTDzv28UuvLs7 WxB2jYg/FPldwKSF0s7HqRJ2QapOBbwFWxwbFgk8FDtFRyUWpMxah6G0MUXVBTnoQ1/9 QVWw== X-Gm-Message-State: ANhLgQ3NFiV24DdCAY8ynw6Dydss/Ako7oeXXcEMVi1hxQaa0BVKV2Eb un120NuAgMzI+EN+35cZPfEvKg== X-Google-Smtp-Source: ADFU+vsoUWK1q9DLaci/YCfl+atSrfAaIkcEQHWUN96dqzXSuCGI+Qv5fCrMNB0ULvwGyVQ03zx0hQ== X-Received: by 2002:a5d:4246:: with SMTP id s6mr3930491wrr.321.1584911721158; Sun, 22 Mar 2020 14:15:21 -0700 (PDT) Received: from google.com ([2a00:79e0:d:210:e8f7:125b:61e9:733d]) by smtp.gmail.com with ESMTPSA id u204sm18254957wmg.40.2020.03.22.14.15.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 22 Mar 2020 14:15:20 -0700 (PDT) Date: Sun, 22 Mar 2020 22:15:20 +0100 From: Matthias Maennich To: Mark Wielaard Cc: "Frank Ch. Eigler" , Overseers mailing list Subject: Re: list From mangling and git am Message-ID: <20200322211520.GD254272@google.com> References: <20200316121624.GC39901@wildebeest.org> <20200316123210.GC211970@google.com> <20200316130654.GK79471@elastic.org> <0022ee64ca48b6f8f64458c81a5fab0021318744.camel@klomp.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <0022ee64ca48b6f8f64458c81a5fab0021318744.camel@klomp.org> User-Agent: Mutt/1.12.2 (2019-09-21) X-Spam-Status: No, score=-19.7 required=5.0 tests=BAYES_00, DKIMWL_WL_MED, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, ENV_AND_HDR_SPF_MATCH, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, USER_IN_DEF_DKIM_WL, USER_IN_DEF_SPF_WL autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: overseers@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Overseers mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 22 Mar 2020 21:15:24 -0000 Hi! On Fri, Mar 20, 2020 at 07:03:14PM +0100, Mark Wielaard wrote: >Hi, > >On Mon, 2020-03-16 at 09:06 -0400, Frank Ch. Eigler wrote: >> The mailinglist From/Reply-To mangling doesn't interact nicely >> > > with git am. [...] >> >> As you know, increasing mail security/spam measures are what is >> driving cleanliness with respect to mailing list systems. Even as we >> speak, we have outgoing email from sourceware to important receivers >> like gmail -blocked- because the receiver doesn't think we are clean >> enough. So I suspect we'll need to retain/enhance these measures >> rather than roll them back. > >Rolling things back is probably not a good idea. There are two ways you >can go, strip dkim headers and rewrite From/Reply-To, or make sure you >keep the original headers and body in tact (no Reply-to mangling, no >subject rewriting, no body or attachment rewriting/removing) so the >dkim signature is correct. The first is probably less work and they >easiest way to comply with any dmarc policy. The second is probably >more work since you have to make sure that no part of the mailing-list >pipeline mangles the original email in any way. > >> For git am workflows, consider: >> >> - running "git amend --author=<....>" after "git am" to fix things > >Yes, this is what I am using now. But it is slightly inconvenient since >it is easy to forget and you cannot easily script it. > >> - asking submitters to use "git format-patch --from="Real Name git >> <...>" >> where the enclosed name is different enough that git format-patch >> includes a second From: header in the body, which git-am prefers > >This works but only if the "real from" (Author) is slightly different >from the normal From. So if I do --from="Mark J. Wielaard >" while the Author is "Mark Wielaard " >then the Body of the email will start with a From: Mark Wielaard < >mark@klomp.org> which git am will pick up correctly. > >This should be possible to script (on the sender side). But it is odd >there is no git send-email option to always generate this extra "Body >From:". That would be ideal. Maybe it is something that upstream git >could consider adding for mailing-lists that mangle From headers? It is the second condition (ident_cmp) in https://github.com/git/git/blob/master/pretty.c#L459 that one would need to target via a command line option. Not sure upstream would accept yet another option like --always-from. Cheers, Matthias > >Cheers, > >Mark