From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate.crashing.org (gate.crashing.org [63.228.1.57]) by sourceware.org (Postfix) with ESMTP id 25BCC385DC1B; Sat, 2 May 2020 12:50:50 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 25BCC385DC1B Received: from gate.crashing.org (localhost.localdomain [127.0.0.1]) by gate.crashing.org (8.14.1/8.14.1) with ESMTP id 042CoeiQ009733; Sat, 2 May 2020 07:50:40 -0500 Received: (from segher@localhost) by gate.crashing.org (8.14.1/8.14.1/Submit) id 042CoaeC009727; Sat, 2 May 2020 07:50:37 -0500 X-Authentication-Warning: gate.crashing.org: segher set sender to segher@kernel.crashing.org using -f Date: Sat, 2 May 2020 07:50:36 -0500 From: Segher Boessenkool To: Jeff Law Cc: Tom Tromey , Tamar Christina , "overseers@gcc.gnu.org" , Jonathan Wakely via Gcc , Overseers mailing list , Alexander Monakov , "Frank Ch. Eigler" , "Frank Ch. Eigler" , Florian Weimer Subject: Re: Not usable email content encoding Message-ID: <20200502125036.GG31009@gate.crashing.org> References: <87zhccsdfd.fsf@tromey.com> <87imj0pjbr.fsf@mid.deneb.enyo.de> <87blosphsw.fsf@mid.deneb.enyo.de> <20200423114627.GG26902@gate.crashing.org> <20200423202708.GR26902@gate.crashing.org> <87zhb1nbue.fsf@tromey.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.2.3i X-Spam-Status: No, score=-11.1 required=5.0 tests=BAYES_00, JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS, RCVD_IN_DNSWL_NONE, TXREP, T_SPF_HELO_PERMERROR, T_SPF_PERMERROR autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: overseers@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Overseers mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 02 May 2020 12:50:52 -0000 On Fri, May 01, 2020 at 09:51:53AM -0600, Jeff Law wrote: > On Thu, 2020-04-23 at 15:14 -0600, Tom Tromey wrote: > > > > > > > "Segher" == Segher Boessenkool writes: > > > > Segher> My point was that this should *never* be part of patches, already. > > > > FWIW, I use a few scripts so that I can keep ChangeLogs as files. > > That's what I do when working on gdb. > > > > https://github.com/tromey/git-gnu-changelog > > > > This is easier on the whole, IME, because it means there is no extra > > manual step before pushing. > Right. And that's really my goal here -- eliminate the manual steps. Ideally I > want to be able to git am; git push on a good patch. Manual steps for good > patches need to be excised from the workflow. The ChangeLog file is a major > problem in that regard. I still almost always write the changelog not before sending a patch series to the mailing list. This is good *anyway*, it isn't a bad idea to look at your creation from a high level first, then; and it is also not a bad idea to look at the details, to see if you missed something. A "self-review", if you want. This of course also completely side-steps the issues with keeping the changelog up-to-date that so many people struggle with (that probably is what made me start doing this, heh). (I also have the changelogs in files of course, that way: the email series I send out I keep as files). > > Of course, better would be to remove ChangeLogs entirely (including not > > putting anything like them into a commit message), because they are > > largely not useful and are just make-work. Again IMNSHO -- I know there > > are some folks who read them, but I basically never have since switching > > to git. > I read them less and less. At this point I think I read them to see if a > particular patch in my queue has already been applied. Otherwise I'm using the > git info. It helps reviewing tremendously. Having very good patch factoring would help; having very good commit messages would help. Together they are much better than a changelog is. Without either (i.e., *the current status quo*), there is real value lost. And making it easier to shove in garbage is not an advantage :-/ Segher