* [rfa] %&^%*()) MOZILLA
@ 2003-02-01 1:08 Andrew Cagney
2003-02-01 2:05 ` Christopher Faylor
0 siblings, 1 reply; 4+ messages in thread
From: Andrew Cagney @ 2003-02-01 1:08 UTC (permalink / raw)
To: overseers
[-- Attachment #1: Type: text/plain, Size: 305 bytes --]
Hello,
The attached path to gnatsweb.pl:
- gets around a bug in mozilla where the list of interested parties
e-mailed to included half the subject line
- filters out /*-prs@/ from the list of interested parties (can't mail
that anyway).
Can I commit it?
you can test it using xgnatsweb.pl.
Andrew
[-- Attachment #2: diffs --]
[-- Type: text/plain, Size: 2387 bytes --]
? diffs
Index: ChangeLog
===================================================================
RCS file: /cvs/sourceware/cgi-bin/ChangeLog,v
retrieving revision 1.36
diff -u -r1.36 ChangeLog
--- ChangeLog 10 Jan 2002 02:07:52 -0000 1.36
+++ ChangeLog 1 Feb 2003 01:03:40 -0000
@@ -1,3 +1,10 @@
+2003-01-31 Andrew Cagney <ac131313@redhat.com>
+
+ * gnatsweb.pl (get_mailto_link): Do not escape the e-mail list.
+ Work around mozilla bug.
+ (interested_parties): Strip out /*-prs@/ as that doesn't accept
+ e-mail. Don't include spaces in list of e-mail addresses.
+
2002-01-09 Christopher Faylor <cgf@redhat.com>
* gnatsweb.pl: Updated from gcc.gnu.org version.
Index: gnatsweb.pl
===================================================================
RCS file: /cvs/sourceware/cgi-bin/gnatsweb.pl,v
retrieving revision 1.38
diff -u -r1.38 gnatsweb.pl
--- gnatsweb.pl 10 Jan 2002 02:11:00 -0000 1.38
+++ gnatsweb.pl 1 Feb 2003 01:03:41 -0000
@@ -843,7 +843,14 @@
sub get_mailto_link
{
my($pr,%fields) = @_;
- my $mailto = $q->escape(scalar(interested_parties($pr, 1, %fields)));
+
+ # NOTE: cagney/2003-01-31: Don't escape the interested parties
+ # e-mail list. MOZILLA has a nasty bug were it doesn't re-adjust
+ # the e-mail list length after de-escaping it. This causes MOZILLA
+ # to use "?Sub..." in the list of e-mail addresses.
+
+ # my $mailto = $q->escape(scalar(interested_parties($pr, 1, %fields)));
+ my $mailto = interested_parties($pr, 1, %fields);
my $subject = $q->escape("Re: $fields{'Category'}/$pr: $fields{'Synopsis'}");
my $body = $q->escape(get_viewpr_url($pr));
@@ -3182,7 +3189,15 @@
foreach $list (@prospect_list) {
if (defined($list)) {
foreach $person (split_csl ($list)) {
- push(@people, $person) if $person;
+
+ # Weed out *-prs. On sware the gdb-prs@ address is read only.
+ # Besides, when gdb-gnats@ gets the PR, it will quickly
+ # forward it onto the Submitter-Id's submitter contact
+ # gdb-prs@.
+
+ if ($person !~ /-prs@/) {
+ push(@people, $person) if $person;
+ }
}
}
}
@@ -3195,7 +3210,9 @@
$addr = praddr($person) || $person;
$addrs{$addr} = 1;
}
- return wantarray ? %addrs : join(', ', keys(%addrs));
+
+ # Do not include spaces. Keeps the mailto: line simpler.
+ return wantarray ? %addrs : join(',', keys(%addrs));
}
# Split comma-separated list.
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [rfa] %&^%*()) MOZILLA
2003-02-01 1:08 [rfa] %&^%*()) MOZILLA Andrew Cagney
@ 2003-02-01 2:05 ` Christopher Faylor
2003-02-01 7:44 ` Andrew Cagney
0 siblings, 1 reply; 4+ messages in thread
From: Christopher Faylor @ 2003-02-01 2:05 UTC (permalink / raw)
To: Andrew Cagney; +Cc: overseers
On Fri, Jan 31, 2003 at 08:08:06PM -0500, Andrew Cagney wrote:
>Hello,
>
>The attached path to gnatsweb.pl:
>
>- gets around a bug in mozilla where the list of interested parties
>e-mailed to included half the subject line
>
>- filters out /*-prs@/ from the list of interested parties (can't mail
>that anyway).
>
>Can I commit it?
>
>you can test it using xgnatsweb.pl.
It's ok with me. Would you be willing to make similar changes to gcc's
copy of this file? It sounds like it needs similar surgery.
Sigh. I see we have code drift between the two versions again. Oh well.
cgf
>Index: ChangeLog
>===================================================================
>RCS file: /cvs/sourceware/cgi-bin/ChangeLog,v
>retrieving revision 1.36
>diff -u -r1.36 ChangeLog
>--- ChangeLog 10 Jan 2002 02:07:52 -0000 1.36
>+++ ChangeLog 1 Feb 2003 01:03:40 -0000
>@@ -1,3 +1,10 @@
>+2003-01-31 Andrew Cagney <ac131313@redhat.com>
>+
>+ * gnatsweb.pl (get_mailto_link): Do not escape the e-mail list.
>+ Work around mozilla bug.
>+ (interested_parties): Strip out /*-prs@/ as that doesn't accept
>+ e-mail. Don't include spaces in list of e-mail addresses.
>+
> 2002-01-09 Christopher Faylor <cgf@redhat.com>
>
> * gnatsweb.pl: Updated from gcc.gnu.org version.
>Index: gnatsweb.pl
>===================================================================
>RCS file: /cvs/sourceware/cgi-bin/gnatsweb.pl,v
>retrieving revision 1.38
>diff -u -r1.38 gnatsweb.pl
>--- gnatsweb.pl 10 Jan 2002 02:11:00 -0000 1.38
>+++ gnatsweb.pl 1 Feb 2003 01:03:41 -0000
>@@ -843,7 +843,14 @@
> sub get_mailto_link
> {
> my($pr,%fields) = @_;
>- my $mailto = $q->escape(scalar(interested_parties($pr, 1, %fields)));
>+
>+ # NOTE: cagney/2003-01-31: Don't escape the interested parties
>+ # e-mail list. MOZILLA has a nasty bug were it doesn't re-adjust
>+ # the e-mail list length after de-escaping it. This causes MOZILLA
>+ # to use "?Sub..." in the list of e-mail addresses.
>+
>+ # my $mailto = $q->escape(scalar(interested_parties($pr, 1, %fields)));
>+ my $mailto = interested_parties($pr, 1, %fields);
> my $subject = $q->escape("Re: $fields{'Category'}/$pr: $fields{'Synopsis'}");
> my $body = $q->escape(get_viewpr_url($pr));
>
>@@ -3182,7 +3189,15 @@
> foreach $list (@prospect_list) {
> if (defined($list)) {
> foreach $person (split_csl ($list)) {
>- push(@people, $person) if $person;
>+
>+ # Weed out *-prs. On sware the gdb-prs@ address is read only.
>+ # Besides, when gdb-gnats@ gets the PR, it will quickly
>+ # forward it onto the Submitter-Id's submitter contact
>+ # gdb-prs@.
>+
>+ if ($person !~ /-prs@/) {
>+ push(@people, $person) if $person;
>+ }
> }
> }
> }
>@@ -3195,7 +3210,9 @@
> $addr = praddr($person) || $person;
> $addrs{$addr} = 1;
> }
>- return wantarray ? %addrs : join(', ', keys(%addrs));
>+
>+ # Do not include spaces. Keeps the mailto: line simpler.
>+ return wantarray ? %addrs : join(',', keys(%addrs));
> }
>
> # Split comma-separated list.
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [rfa] %&^%*()) MOZILLA
2003-02-01 2:05 ` Christopher Faylor
@ 2003-02-01 7:44 ` Andrew Cagney
2003-02-01 18:53 ` Christopher Faylor
0 siblings, 1 reply; 4+ messages in thread
From: Andrew Cagney @ 2003-02-01 7:44 UTC (permalink / raw)
To: Christopher Faylor; +Cc: overseers
> On Fri, Jan 31, 2003 at 08:08:06PM -0500, Andrew Cagney wrote:
>
>>Hello,
>>
>>The attached path to gnatsweb.pl:
>>
>>- gets around a bug in mozilla where the list of interested parties
>>e-mailed to included half the subject line
>>
>>- filters out /*-prs@/ from the list of interested parties (can't mail
>>that anyway).
>>
>>Can I commit it?
>>
>>you can test it using xgnatsweb.pl.
>
>
> It's ok with me. Would you be willing to make similar changes to gcc's
> copy of this file? It sounds like it needs similar surgery.
>
> Sigh. I see we have code drift between the two versions again. Oh well.
Where is GCC's equivalent CVS?
Andrew
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [rfa] %&^%*()) MOZILLA
2003-02-01 7:44 ` Andrew Cagney
@ 2003-02-01 18:53 ` Christopher Faylor
0 siblings, 0 replies; 4+ messages in thread
From: Christopher Faylor @ 2003-02-01 18:53 UTC (permalink / raw)
To: Andrew Cagney; +Cc: overseers
On Sat, Feb 01, 2003 at 02:44:39AM -0500, Andrew Cagney wrote:
>>On Fri, Jan 31, 2003 at 08:08:06PM -0500, Andrew Cagney wrote:
>>
>>>Hello,
>>>
>>>The attached path to gnatsweb.pl:
>>>
>>>- gets around a bug in mozilla where the list of interested parties
>>>e-mailed to included half the subject line
>>>
>>>- filters out /*-prs@/ from the list of interested parties (can't mail
>>>that anyway).
>>>
>>>Can I commit it?
>>>
>>>you can test it using xgnatsweb.pl.
>>
>>
>>It's ok with me. Would you be willing to make similar changes to gcc's
>>copy of this file? It sounds like it needs similar surgery.
>>
>>Sigh. I see we have code drift between the two versions again. Oh well.
>
>Where is GCC's equivalent CVS?
/cvs/gcc/wwwdocs/cgi-bin
cgf
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2003-02-01 18:53 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2003-02-01 1:08 [rfa] %&^%*()) MOZILLA Andrew Cagney
2003-02-01 2:05 ` Christopher Faylor
2003-02-01 7:44 ` Andrew Cagney
2003-02-01 18:53 ` Christopher Faylor
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).