public inbox for overseers@sourceware.org
 help / color / mirror / Atom feed
* Work around mozilla
@ 2003-02-02  3:49 Andrew Cagney
  0 siblings, 0 replies; only message in thread
From: Andrew Cagney @ 2003-02-02  3:49 UTC (permalink / raw)
  To: overseers

[-- Attachment #1: Type: text/plain, Size: 81 bytes --]

FYI,

I double committed the attached.  Gets rid of the mozilla problem.

Andrew

[-- Attachment #2: diffs --]
[-- Type: text/plain, Size: 1460 bytes --]

2003-02-01  Andrew Cagney  <ac131313@redhat.com>

	* gnatsweb.pl (get_mailto_link): Do not escape the e-mail list.
	Work around mozilla bug.
	(interested_parties): Don't include spaces in list of e-mail
	addresses.

Index: gnatsweb.pl
===================================================================
RCS file: /cvs/sourceware/cgi-bin/gnatsweb.pl,v
retrieving revision 1.38
diff -u -r1.38 gnatsweb.pl
--- gnatsweb.pl	10 Jan 2002 02:11:00 -0000	1.38
+++ gnatsweb.pl	2 Feb 2003 03:35:57 -0000
@@ -843,6 +843,15 @@
 sub get_mailto_link
 {
   my($pr,%fields) = @_;
+
+  # NOTE: cagney/2003-01-31: Don't escape the interested parties
+  # e-mail list.  MOZILLA has a nasty bug were it doesn't re-adjust
+  # the e-mail list length after de-escaping it.  This causes MOZILLA
+  # to use "?Sub..." in the list of e-mail addresses.
+
+  # my $mailto  = $q->escape(scalar(interested_parties($pr, 1, %fields)));
+  my $mailto  = interested_parties($pr, 1, %fields);
+
   my $mailto  = $q->escape(scalar(interested_parties($pr, 1, %fields)));
   my $subject = $q->escape("Re: $fields{'Category'}/$pr: $fields{'Synopsis'}");
   my $body    = $q->escape(get_viewpr_url($pr));
@@ -2400,7 +2409,11 @@
     (@val) = site_callback($reason, @args);
   }
 
-  return wantarray ? @val : $val[0];
+  
+  # Do not include spaces.  Avoids having to encode them - encoded
+  # spaces confuse MOZILLA.
+
+  return wantarray ? %addrs : join(',', keys(%addrs));
 }
 
 # print_header -

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2003-02-02  3:49 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2003-02-02  3:49 Work around mozilla Andrew Cagney

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).