From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <overseers-return-5450-listarch-overseers=sources.redhat.com@sources.redhat.com>
Received: (qmail 26597 invoked by alias); 2 Feb 2003 03:49:02 -0000
Mailing-List: contact overseers-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Archive: <http://sources.redhat.com/ml/overseers/>
List-Post: <mailto:overseers@sources.redhat.com>
List-Help: <mailto:overseers-help@sources.redhat.com>,
	<http://sources.redhat.com/ml/#faqs>
Sender: overseers-owner@sources.redhat.com
Received: (qmail 26590 invoked from network); 2 Feb 2003 03:49:01 -0000
Received: from unknown (HELO localhost.redhat.com) (24.157.209.173)
  by 172.16.49.205 with SMTP; 2 Feb 2003 03:49:01 -0000
Received: from redhat.com (localhost [127.0.0.1])
	by localhost.redhat.com (Postfix) with ESMTP id 97DA73CB0
	for <overseers@sources.redhat.com>; Sat,  1 Feb 2003 22:48:48 -0500 (EST)
Message-ID: <3E3C9520.7040108@redhat.com>
Date: Sun, 02 Feb 2003 03:49:00 -0000
From: Andrew Cagney <ac131313@redhat.com>
User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:1.0.1) Gecko/20021211
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: overseers@sources.redhat.com
Subject: Work around mozilla
Content-Type: multipart/mixed;
 boundary="------------070201000302050601080106"
X-SW-Source: 2003-q1/txt/msg00243.txt.bz2

This is a multi-part message in MIME format.
--------------070201000302050601080106
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
Content-length: 81

FYI,

I double committed the attached.  Gets rid of the mozilla problem.

Andrew

--------------070201000302050601080106
Content-Type: text/plain;
 name="diffs"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline;
 filename="diffs"
Content-length: 1460

2003-02-01  Andrew Cagney  <ac131313@redhat.com>

	* gnatsweb.pl (get_mailto_link): Do not escape the e-mail list.
	Work around mozilla bug.
	(interested_parties): Don't include spaces in list of e-mail
	addresses.

Index: gnatsweb.pl
===================================================================
RCS file: /cvs/sourceware/cgi-bin/gnatsweb.pl,v
retrieving revision 1.38
diff -u -r1.38 gnatsweb.pl
--- gnatsweb.pl	10 Jan 2002 02:11:00 -0000	1.38
+++ gnatsweb.pl	2 Feb 2003 03:35:57 -0000
@@ -843,6 +843,15 @@
 sub get_mailto_link
 {
   my($pr,%fields) = @_;
+
+  # NOTE: cagney/2003-01-31: Don't escape the interested parties
+  # e-mail list.  MOZILLA has a nasty bug were it doesn't re-adjust
+  # the e-mail list length after de-escaping it.  This causes MOZILLA
+  # to use "?Sub..." in the list of e-mail addresses.
+
+  # my $mailto  = $q->escape(scalar(interested_parties($pr, 1, %fields)));
+  my $mailto  = interested_parties($pr, 1, %fields);
+
   my $mailto  = $q->escape(scalar(interested_parties($pr, 1, %fields)));
   my $subject = $q->escape("Re: $fields{'Category'}/$pr: $fields{'Synopsis'}");
   my $body    = $q->escape(get_viewpr_url($pr));
@@ -2400,7 +2409,11 @@
     (@val) = site_callback($reason, @args);
   }
 
-  return wantarray ? @val : $val[0];
+  
+  # Do not include spaces.  Avoids having to encode them - encoded
+  # spaces confuse MOZILLA.
+
+  return wantarray ? %addrs : join(',', keys(%addrs));
 }
 
 # print_header -

--------------070201000302050601080106--