From: Brendan Conoboy <blc@redhat.com>
To: overseers@sources.redhat.com
Subject: patch for cvs modules parsing bug
Date: Tue, 07 Oct 2003 01:19:00 -0000 [thread overview]
Message-ID: <3F8214C7.5050103@redhat.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 485 bytes --]
Hi there. Attached is a patch to fix inadvertent substring matches in
excluded module directories. The problem manifests itself when a short
directory name, say "f" is excluded. If there are other directories
which start with "f" they also are excluded. This happens in the gcc
sources with "fixinc". The below patch fixes the problem:
ChangeLog:
Tue Oct 7 00:22:31 UTC 2003 Brendan Conoboy
* ignore.c (ignore_directory): Disallow substring directory
matches.
[-- Attachment #2: cvs-substringnomatch.patch --]
[-- Type: text/plain, Size: 691 bytes --]
Index: ignore.c
===================================================================
RCS file: /cvs/cvsfiles/coolo-cvs/src/ignore.c,v
retrieving revision 1.1.1.6
diff -c -r1.1.1.6 ignore.c
*** ignore.c 1 Apr 2002 09:18:34 -0000 1.1.1.6
--- ignore.c 7 Oct 2003 00:19:45 -0000
***************
*** 351,357 ****
i = dir_ign_current;
while (i--)
{
! if (strncmp (name, dir_ign_list[i], strlen (dir_ign_list[i])) == 0)
return 1;
}
--- 351,358 ----
i = dir_ign_current;
while (i--)
{
! if ((strlen (dir_ign_list[i]) == strlen (name) ) &&
! (strncmp (name, dir_ign_list[i], strlen (dir_ign_list[i])) == 0))
return 1;
}
next reply other threads:[~2003-10-07 1:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-10-07 1:19 Brendan Conoboy [this message]
2003-10-07 2:49 ` Christopher Faylor
2003-10-07 15:20 ` Brendan Conoboy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3F8214C7.5050103@redhat.com \
--to=blc@redhat.com \
--cc=overseers@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).