From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15785 invoked by alias); 7 Oct 2003 01:19:25 -0000 Mailing-List: contact overseers-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Archive: List-Post: List-Help: , Sender: overseers-owner@sources.redhat.com Received: (qmail 15772 invoked from network); 7 Oct 2003 01:19:24 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sources.redhat.com with SMTP; 7 Oct 2003 01:19:24 -0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.11.6/8.11.6) with ESMTP id h971JO112399 for ; Mon, 6 Oct 2003 21:19:24 -0400 Received: from pobox.corp.redhat.com (pobox.corp.redhat.com [172.16.52.156]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id h971JOc07261 for ; Mon, 6 Oct 2003 21:19:24 -0400 Received: from redhat.com (blc.cipe.redhat.com [10.0.2.152]) by pobox.corp.redhat.com (8.12.8/8.12.8) with ESMTP id h971JNbe009312 for ; Mon, 6 Oct 2003 21:19:23 -0400 Message-ID: <3F8214C7.5050103@redhat.com> Date: Tue, 07 Oct 2003 01:19:00 -0000 From: Brendan Conoboy User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.2.1) Gecko/20030225 X-Accept-Language: en-us, en MIME-Version: 1.0 To: overseers@sources.redhat.com Subject: patch for cvs modules parsing bug Content-Type: multipart/mixed; boundary="------------040402040603090503010506" X-SW-Source: 2003-q4/txt/msg00035.txt.bz2 This is a multi-part message in MIME format. --------------040402040603090503010506 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Content-length: 485 Hi there. Attached is a patch to fix inadvertent substring matches in excluded module directories. The problem manifests itself when a short directory name, say "f" is excluded. If there are other directories which start with "f" they also are excluded. This happens in the gcc sources with "fixinc". The below patch fixes the problem: ChangeLog: Tue Oct 7 00:22:31 UTC 2003 Brendan Conoboy * ignore.c (ignore_directory): Disallow substring directory matches. --------------040402040603090503010506 Content-Type: text/plain; name="cvs-substringnomatch.patch" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="cvs-substringnomatch.patch" Content-length: 691 Index: ignore.c =================================================================== RCS file: /cvs/cvsfiles/coolo-cvs/src/ignore.c,v retrieving revision 1.1.1.6 diff -c -r1.1.1.6 ignore.c *** ignore.c 1 Apr 2002 09:18:34 -0000 1.1.1.6 --- ignore.c 7 Oct 2003 00:19:45 -0000 *************** *** 351,357 **** i = dir_ign_current; while (i--) { ! if (strncmp (name, dir_ign_list[i], strlen (dir_ign_list[i])) == 0) return 1; } --- 351,358 ---- i = dir_ign_current; while (i--) { ! if ((strlen (dir_ign_list[i]) == strlen (name) ) && ! (strncmp (name, dir_ign_list[i], strlen (dir_ign_list[i])) == 0)) return 1; } --------------040402040603090503010506--