From: Florian Weimer <fweimer@redhat.com>
To: overseers@sourceware.org
Cc: Siddhesh Poyarekar <siddhesh@redhat.com>
Subject: Patchwork issue: Reviewed-by not picked up correctly
Date: Tue, 17 Jan 2023 11:54:09 +0100 [thread overview]
Message-ID: <874jsp77ou.fsf@oldenburg.str.redhat.com> (raw)
Not sure where to report this, there's no patchwork component on
Bugzilla AFAICS.
This patch:
<https://patchwork.sourceware.org/project/glibc/patch/20230115183715.1278363-1-martin.joerg@gmail.com/mbox/>
has an injected Reviewed-by:, but it's not in the right place:
| ---
| manual/string.texi | 2 +-
| 1 file changed, 1 insertion(+), 1 deletion(-)
| Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
|
| diff --git a/manual/string.texi b/manual/string.texi
| index 0b60b3fbb4..7578aa1c26 100644
It must come before the ---, so that “git am” picks it up.
The original message is here:
[PATCH] manual: Fix typo
<https://sourceware.org/pipermail/libc-alpha/2023-January/144739.html>
Thanks,
Florian
next reply other threads:[~2023-01-17 10:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-17 10:54 Florian Weimer [this message]
2023-01-17 13:06 ` Siddhesh Poyarekar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874jsp77ou.fsf@oldenburg.str.redhat.com \
--to=fweimer@redhat.com \
--cc=overseers@sourceware.org \
--cc=siddhesh@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).