commit_prep perl question

commit_prep perl question

[Phil Edwards]

Okay, actually two questions:

1) How do I test changes to commit_prep before presenting them for approval?

2) In the generalized commit_prep, there is basically this code:

    sub check_version {
        local($filename, $cvsversion) = @_;

        .... $cvsversion{...} ....
    }

    ....
    $cvsversion{...} = ....;

    foreach $arg (@files) {
        &check_version($arg);
    }

check_version is passed one argument, but accepts two, and the second
local formal parameter name is the same as a global hash variable name.
Is this a bug, or does perl actually work like that?


Phil

-- 
If ye love wealth greater than liberty, the tranquility of servitude greater
than the animating contest for freedom, go home and leave us in peace.  We seek
not your counsel, nor your arms.  Crouch down and lick the hand that feeds you;
and may posterity forget that ye were our countrymen.            - Samuel Adams

Re: commit_prep perl question

[Tom Tromey]

Phil> 1) How do I test changes to commit_prep before presenting them
Phil> for approval?

Make a dummy repository somewhere and try it there.

Phil> 2) In the generalized commit_prep, there is basically this code:
Phil> [ ... ]

Looks like a bug to me.  I didn't look at the code, just your
extraction.

Tom