From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9744 invoked by alias); 29 Jul 2003 21:01:14 -0000 Mailing-List: contact overseers-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Archive: List-Post: List-Help: , Sender: overseers-owner@sources.redhat.com Received: (qmail 9737 invoked from network); 29 Jul 2003 21:01:14 -0000 Received: from unknown (HELO gash2.peakpeak.com) (207.174.178.17) by sources.redhat.com with SMTP; 29 Jul 2003 21:01:14 -0000 Received: from fleche.redhat.com (te0185.peakpeak.com [204.144.238.185]) by gash2.peakpeak.com (8.9.3/8.9.3.1) with ESMTP id PAA14580; Tue, 29 Jul 2003 15:01:06 -0600 Received: by fleche.redhat.com (Postfix, from userid 1000) id D4C744F8746; Tue, 29 Jul 2003 14:50:43 -0600 (MDT) To: Phil Edwards Cc: overseers@sources.redhat.com Subject: Re: commit_prep perl question References: <20030729205700.GA23614@disaster.jaj.com> From: Tom Tromey Reply-To: tromey@redhat.com X-Attribution: Tom X-Zippy: I put aside my copy of ``BOWLING WORLD'' and think about GUN CONTROL legislation.. Date: Tue, 29 Jul 2003 21:01:00 -0000 In-Reply-To: <20030729205700.GA23614@disaster.jaj.com> Message-ID: <87isplukf0.fsf@fleche.redhat.com> User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3.50 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-SW-Source: 2003-q3/txt/msg00108.txt.bz2 Phil> 1) How do I test changes to commit_prep before presenting them Phil> for approval? Make a dummy repository somewhere and try it there. Phil> 2) In the generalized commit_prep, there is basically this code: Phil> [ ... ] Looks like a bug to me. I didn't look at the code, just your extraction. Tom