From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ot1-x32a.google.com (mail-ot1-x32a.google.com [IPv6:2607:f8b0:4864:20::32a]) by sourceware.org (Postfix) with ESMTPS id 635723847725; Wed, 3 Apr 2024 14:42:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 635723847725 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 635723847725 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::32a ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712155339; cv=none; b=q635n9aPbtZjhP1znRF/EscT0vX1h4A8cRVMmz2ZVfvdSLQgDZJSpLHMtfpV4mWNoj+E5PavR5WifNKydi/uUBrwRmdm6zDLz627AJUlWHSQ/YfI4p2/Eyo7DYmwFRUhTshNwBTCHI4zJGgB5M9p7sTqefjhgpuKK9dM1EXX1E0= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712155339; c=relaxed/simple; bh=6wJ3faOVCS0fyKZxaThk9FD0B4MCy3V0FNKFWnMP1xM=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=Rm2cO0gvJ8vIhNPz+O84HnH+FIMIUDl4ZgkWDoJn57UXDjUPCpS9RFFwJX+DC4NdPOD5tZqvvctI8lTzz9tEZ31xbJT/Tn2EcOhks0FWbHlvZFPuz1S1jkERM6zA/u1EZxPAVcCYm+BjW4s/jIF83jqHVrfWfc2l94zLVIkN+rA= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-ot1-x32a.google.com with SMTP id 46e09a7af769-6e6b582d266so3963822a34.3; Wed, 03 Apr 2024 07:42:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1712155335; x=1712760135; darn=sourceware.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=K11PSmvLxUgWO8GyCxGTPv8raE1oT1yCfTUFYmzduV8=; b=c8NDtOUAVZfDZze8hYvMlo+9ZUXCCeaC11Jq9+bf4nSabFtmpRgoSKjpR9DgXnD/Et 3cd+mjRWHXeKmMiQY+r6Jh2R37SUAPHfklQL65i8DifoCvoX7hGr4Bi/HlKLgtLWwVbn oYAvY2j33FZAhguA7y8mRiS/qq/JVSJx7FDDyfMLh85mvX/ja1Rx0LJMJ5TJLETSjsGF mn3Twvna+c0Tcx9QVpmc3W5wNwc6d37HRbF4vCuoi0ty6XX61dBC4BdJhYhzUIiU+C6o LGnU6Wc2Yz5L+B0bgMpGDHvwLHG2/HxS3Ea7Gj5VQK9C/w5YTTVvmeWhCbo8RYipVqK3 Jtdw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712155335; x=1712760135; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=K11PSmvLxUgWO8GyCxGTPv8raE1oT1yCfTUFYmzduV8=; b=U0aLwyMhWuCfzTlOAg0KtlArjppJJwfWpFYoADL4HIhuN+AP3Vr4i5pLp+ECY1knhY mQ5oQkJYB2Xmm29+UxqQjpI84fgm5x5c+qB7dwmx/2ngQ8Fo2D8JSpOcYsfljuXFUng8 9mMKswhuOKLcHh6UTZdq1nYN1plDpTqbRHJVuo5rWwrKHMEtslWQ43QPuZwsQd+w+QmY BZ6zsLC3DmMru2kk5kWL7aeK1NY4W5ktnOkd48kDS5oe/szYh4WnWHFxr3m22PEdpCVi dly/khqaddZKsQ0CBjxKdP867IEkVHOg6XS3b4E/KSWr2n5f7MucFLWcAC5zbBvGaPig gXxg== X-Forwarded-Encrypted: i=1; AJvYcCXe+FROrxPCWkyWZzR83/RuVLfu7se86omwXIFfh1OQ/P9EB7OKcSNxMIH2/7eAz3BEZlfzvzb6o6R6YIZhyfcNh5vUbTlFRoAtRB/OC15ttlVI0PXKTUfSakic3FHk0lz2izuo/I833XNkxsc313H7zuJimZ13 X-Gm-Message-State: AOJu0YyVBRX+yTXI2hoXQ13e6XD90CxUXm9IwHvr1U30TOs4oZ+5K/Ks /sugZ3SUX/uoSPtj82RFps8cvcCeZ8SBXhZAylwvFv/BnWouxH1B X-Google-Smtp-Source: AGHT+IE1n9AJ3RJmjBKWHTe0InCX9P/AK1FkRWiJfSzGuKCbcJ0PUQgtFvjmrahYvDPzl2eFEdXrzw== X-Received: by 2002:a05:6830:100d:b0:6e9:e442:1584 with SMTP id a13-20020a056830100d00b006e9e4421584mr828394otp.33.1712155335581; Wed, 03 Apr 2024 07:42:15 -0700 (PDT) Received: from [172.31.0.109] ([136.36.72.243]) by smtp.gmail.com with ESMTPSA id g8-20020a056830308800b006e67fcd0ff1sm2652240ots.10.2024.04.03.07.42.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 03 Apr 2024 07:42:14 -0700 (PDT) Message-ID: <8bb160e6-d66a-41fa-8c5e-13e236c21919@gmail.com> Date: Wed, 3 Apr 2024 08:42:13 -0600 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta Subject: Re: Sourceware mitigating and preventing the next xz-backdoor Content-Language: en-US To: Tom Tromey , Florian Weimer Cc: Guinevere Larsen via Overseers , Sandra Loosemore , Mark Wielaard , Guinevere Larsen , gcc@gcc.gnu.org, binutils@sourceware.org, gdb@sourceware.org, libc-alpha@sourceware.org References: <20240329203909.GS9427@gnu.wildebeest.org> <20240401150617.GF19478@gnu.wildebeest.org> <077b9dd5-0df1-4384-a9d1-58e4283caf09@redhat.com> <87il0ykgw5.fsf@oldenburg.str.redhat.com> <87o7aq8ruc.fsf@tromey.com> From: Jeff Law In-Reply-To: <87o7aq8ruc.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 4/3/24 8:04 AM, Tom Tromey wrote: >>>>>> "Florian" == Florian Weimer writes: > > Florian> Everyone still pushes their own patches, and there are no > Florian> technical countermeasures in place to ensure that the pushed version is > Florian> the reviewed version. > > This is a problem for gdb as well. > > Probably we should switch to some kind of pull-request model, where > patches can only be landed via the UI, after sufficient review; and > where all generated files are regenerated by the robot before checkin. > (Or alternatively some CI runs and rejects patches where they don't > match.) I've very much prefer to move to a pull-request model. jeff