public inbox for overseers@sourceware.org
 help / color / mirror / Atom feed
* Patchwork issue: Reviewed-by not picked up correctly
@ 2023-01-17 10:54 Florian Weimer
  2023-01-17 13:06 ` Siddhesh Poyarekar
  0 siblings, 1 reply; 2+ messages in thread
From: Florian Weimer @ 2023-01-17 10:54 UTC (permalink / raw)
  To: overseers; +Cc: Siddhesh Poyarekar

Not sure where to report this, there's no patchwork component on
Bugzilla AFAICS.

This patch:

<https://patchwork.sourceware.org/project/glibc/patch/20230115183715.1278363-1-martin.joerg@gmail.com/mbox/>

has an injected Reviewed-by:, but it's not in the right place:

| ---
|  manual/string.texi | 2 +-
|  1 file changed, 1 insertion(+), 1 deletion(-)
| Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
| 
| diff --git a/manual/string.texi b/manual/string.texi
| index 0b60b3fbb4..7578aa1c26 100644

It must come before the ---, so that “git am” picks it up.

The original message is here:

  [PATCH] manual: Fix typo
  <https://sourceware.org/pipermail/libc-alpha/2023-January/144739.html>

Thanks,
Florian


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: Patchwork issue: Reviewed-by not picked up correctly
  2023-01-17 10:54 Patchwork issue: Reviewed-by not picked up correctly Florian Weimer
@ 2023-01-17 13:06 ` Siddhesh Poyarekar
  0 siblings, 0 replies; 2+ messages in thread
From: Siddhesh Poyarekar @ 2023-01-17 13:06 UTC (permalink / raw)
  To: Florian Weimer; +Cc: overseers

On Tue, Jan 17, 2023 at 5:54 AM Florian Weimer <fweimer@redhat.com> wrote:
>
> Not sure where to report this, there's no patchwork component on
> Bugzilla AFAICS.
>
> This patch:
>
> <https://patchwork.sourceware.org/project/glibc/patch/20230115183715.1278363-1-martin.joerg@gmail.com/mbox/>
>
> has an injected Reviewed-by:, but it's not in the right place:
>

I've filed this upstream:

https://github.com/getpatchwork/patchwork/issues/516

Sid


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-01-17 13:07 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-01-17 10:54 Patchwork issue: Reviewed-by not picked up correctly Florian Weimer
2023-01-17 13:06 ` Siddhesh Poyarekar

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).