From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 104200 invoked by alias); 6 Mar 2015 16:51:11 -0000 Mailing-List: contact overseers-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: , Sender: overseers-owner@sourceware.org Received: (qmail 104189 invoked by uid 89); 6 Mar 2015 16:51:11 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=0.4 required=5.0 tests=AWL,BAYES_00,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,KAM_FROM_URIBL_PCCC,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=no version=3.3.2 X-HELO: mail-qc0-f170.google.com Received: from mail-qc0-f170.google.com (HELO mail-qc0-f170.google.com) (209.85.216.170) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Fri, 06 Mar 2015 16:51:10 +0000 Received: by qcwb13 with SMTP id b13so14224172qcw.12 for ; Fri, 06 Mar 2015 08:51:08 -0800 (PST) MIME-Version: 1.0 X-Received: by 10.55.23.71 with SMTP id i68mr24085041qkh.79.1425660667958; Fri, 06 Mar 2015 08:51:07 -0800 (PST) Received: by 10.229.119.10 with HTTP; Fri, 6 Mar 2015 08:51:07 -0800 (PST) In-Reply-To: <87d24ozysg.fsf@igalia.com> References: <87mw490xm8.fsf@igalia.com> <877fux198m.fsf@igalia.com> <87d24ozysg.fsf@igalia.com> Date: Fri, 06 Mar 2015 16:51:00 -0000 Message-ID: Subject: Re: [PATCH] Fix value-dynamic-type From: Doug Evans To: Andy Wingo Cc: overseers@sourceware.org Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-SW-Source: 2015-q1/txt/msg00102.txt.bz2 Ah, righto, you need an account on sourceware.org. I believe the procedure is to send a message to overseers@sourceware.org, c= c'd, with your key. On Wed, Mar 4, 2015 at 5:18 AM, Andy Wingo wrote: > Greets :) > > I don't think I have commit rights, though I'm happy to do that if it's > the right thing. (We are off-list; happy to go on-list as > appropriate). > > My SSH key fingerprint: > > ssh-rsa AAAAB3NzaC1yc2EAAAABIwAAAgEAniIBKe3+toYN/4MtEnN8osjwkrlYlXfdRU1vX= tjE1MRbPyiQ2D1MVFx6VWRz7VAKXToUeRqAqSm5jS+34r5erKbNGJnRcyOjryyDGCvwAHcVeAg0= dbR75uwesw+0Bymhqw8CSCjauySWusMmB1is6Bow7G+tv9I91Pkky1WrgYu/JQDRpN00GCGbhrS= 2h2JaqIlgXRuzj9/ls8iJnPDNMi1qGoQBWXOhPFxURZMBPdUgFQeayQ96NvZdSHDlKCEgv9Nu1z= vfpKsR34gwuC/V3/+DRvsRERXb3gLRQaZAPEAkAn/Qwu/SAMe7shgdKRiQqnpNsDGRWHCVX3E7Q= pSjqqmfbWaoKG1MITmm+4B/b+OWNThANCNxmkw+YSgqPnXcwfot5pBNGL/2MwdYLr9shidRrd2s= 2Sy+vLdaBlaaKSMuCIWt3JtVmj+yxXjJmHrnaj+oiNLTI/++La52smRgU9mk+0888Uz852p9Wje= Q9C3dd07sdx96pGWDSkmUmoOaLxyn1ypIm5PvOoSZXs9/82sE5JUPmlVgPr9mF2vDYmydAo56uk= 9qUXD/4pdddzlWfmldsIoo4cAYFG+4tTcwOG/6TDeSWv0sS+9Gw1BBGvYLMpXBBn8TtRRt+jEDy= vV2u7U5VK/h/wcPIVyiVXQkdOrkAOC3THVb8CUo+yWevHU=3D wingo@harpy.local > > Thanks for the tip about commit messages, will fix. > > Andy > > On Wed 04 Mar 2015 09:42, Doug Evans writes: > >> Hi. >> Once a patch has been approved people generally commit their own patches. >> But we're happy to commit them for contributors if necessary/desired. >> >> For reference sake, in addition to the rules for submitting a patch, >> there are also rules for how to format the commit message. >> >> https://sourceware.org/gdb/wiki/ContributionChecklist#Properly_formatted= _commit_messages >> >> On Wed, Mar 4, 2015 at 12:02 AM, Andy Wingo wrote: >>> Hi Doug, >>> >>> What's the process for landing patches? I don't see this one in >>> origin/master. >>> >>> Thanks, >>> >>> Andy >>> >>> On Sun 22 Feb 2015 18:36, Doug Evans writes: >>> >>>> Andy Wingo writes: >>>>> Hi, >>>>> >>>>> The attached patch fixes a typo in value-dynamic-type that could cause >>>>> it to return #. >>>>> >>>>> Andy >>>>> >>>>> >>>>> From c428975bbbf4521766e13d158b12f41392c6bc5e Mon Sep 17 00:00:00 2001 >>>>> From: Andy Wingo >>>>> Date: Fri, 20 Feb 2015 09:55:25 +0100 >>>>> Subject: [PATCH] Fix typo in value-dynamic-type >>>>> >>>>> gdb/ChangeLog: >>>>> 2015-02-20 Andy Wingo >>>>> >>>>> * guile/scm-value.c (gdbscm_value_dynamic_type): Fix typo in whi= ch >>>>> we were checking the cached type, not the cached dynamic type. >>>> >>>> LGTM