cgi-bin/gnatsweb.pl patched

cgi-bin/gnatsweb.pl patched

[Gerald Pfeifer]

I usually try not to interfere with sources.redhat.com admin issues,
but cgi-bin/gnatsweb.pl urgently needed the following patch, and Tom is
heavily loaded with other stuff and didn't have the time to address this,
so I went ahead and installed the following.

Phil, it should work now, I hope.

Gerald

Generate proper cookies paths.
By Mark Kuchel <mark@kuchel.net>.

Index: gnatsweb.pl
===================================================================
RCS file: /cvs/gcc/wwwdocs/cgi-bin/gnatsweb.pl,v
retrieving revision 1.19
retrieving revision 1.20
diff -u -3 -p -r1.19 -r1.20
--- gnatsweb.pl	2001/01/11 01:11:36	1.19
+++ gnatsweb.pl	2001/01/19 01:30:42	1.20
@@ -3143,6 +3143,7 @@ sub main
                                -expires => $global_cookie_expires);
     my $expire_old_cookie = $q->cookie(-name => 'gnatsweb',
                                -value => 'does not matter',
+                               -path => $global_cookie_path,
                                #-path was not used for gnatsweb 2.5 cookies
                                -expires => '-1d');
     my $url = $q->param('return_url');

Re: cgi-bin/gnatsweb.pl patched

[Christopher Faylor]

On Fri, Feb 02, 2001 at 09:12:20PM +0100, Gerald Pfeifer wrote:
>I usually try not to interfere with sources.redhat.com admin issues,
>but cgi-bin/gnatsweb.pl urgently needed the following patch, and Tom is
>heavily loaded with other stuff and didn't have the time to address this,
>so I went ahead and installed the following.

Your efforts are appreciated, Gerald.  I don't know about Tom or Jeff, but
I have very little experience with gnatsweb so any help you offer is great.

cgf

Re: cgi-bin/gnatsweb.pl patched

[Phil Edwards]

On Fri, Feb 02, 2001 at 09:12:20PM +0100, Gerald Pfeifer wrote:
> I usually try not to interfere with sources.redhat.com admin issues,
> but cgi-bin/gnatsweb.pl urgently needed the following patch, and Tom is
> heavily loaded with other stuff and didn't have the time to address this,
> so I went ahead and installed the following.
> 
> Phil, it should work now, I hope.

I no longer get the error message, so everything should be fine now.
Thanks so much!

Hopefully this weekend I can close out most of the old v3 database,
and maybe run Tom's PR-copying script to get the remaining ones into the
current database.


Phil

-- 
pedwards at disaster dot jaj dot com  |  pme at sources dot redhat dot com
devphil at several other less interesting addresses in various dot domains
The gods do not protect fools.  Fools are protected by more capable fools.

Re: cgi-bin/gnatsweb.pl patched

[Tom Tromey]

>>>>> "Gerald" == Gerald Pfeifer <pfeifer@dbai.tuwien.ac.at> writes:

Gerald> I usually try not to interfere with sources.redhat.com admin
Gerald> issues, but cgi-bin/gnatsweb.pl urgently needed the following
Gerald> patch, and Tom is heavily loaded with other stuff and didn't
Gerald> have the time to address this, so I went ahead and installed
Gerald> the following.

Thanks Gerald.
Actually I was waiting for the final set of patches from you before
hacking the sourceware gnatsweb.  Is gnatsweb ready for a full
re-import into the sourceware cvs?

Tom

Re: cgi-bin/gnatsweb.pl patched

[Gerald Pfeifer]

On 2 Feb 2001, Tom Tromey wrote:
> Actually I was waiting for the final set of patches from you before
> hacking the sourceware gnatsweb.  Is gnatsweb ready for a full
> re-import into the sourceware cvs?

I wouldn't recommend doing so for the official gnatsweb sources (yet), but
I have now committed a final, important patch, such that I can recommend
synching from what we have at gcc.gnu.org.

(Nearly) all changes peculiar to the gcc.gnu.org site should be marked
properly (similiar to what Redhat does with the internal GCC tree), so
you should be able to just copy gnatsweb.pl and manually review these
local changes in less than 10 minutes.

If you noticed any problems/omissions, please let me know!

Gerald
-- 
Gerald "Jerry" pfeifer@dbai.tuwien.ac.at http://www.dbai.tuwien.ac.at/~pfeifer/

Re: cgi-bin/gnatsweb.pl patched

[Phil Edwards]

On Fri, Feb 02, 2001 at 09:12:20PM +0100, Gerald Pfeifer wrote:
> I usually try not to interfere with sources.redhat.com admin issues,
> but cgi-bin/gnatsweb.pl urgently needed the following patch, and Tom is
> heavily loaded with other stuff and didn't have the time to address this,
> so I went ahead and installed the following.
> 
> Phil, it should work now, I hope.

I no longer get the error message, so everything should be fine now.
Thanks so much!

Hopefully this weekend I can close out most of the old v3 database,
and maybe run Tom's PR-copying script to get the remaining ones into the
current database.


Phil

-- 
pedwards at disaster dot jaj dot com  |  pme at sources dot redhat dot com
devphil at several other less interesting addresses in various dot domains
The gods do not protect fools.  Fools are protected by more capable fools.

Re: cgi-bin/gnatsweb.pl patched

[Christopher Faylor]

On Fri, Feb 02, 2001 at 09:12:20PM +0100, Gerald Pfeifer wrote:
>I usually try not to interfere with sources.redhat.com admin issues,
>but cgi-bin/gnatsweb.pl urgently needed the following patch, and Tom is
>heavily loaded with other stuff and didn't have the time to address this,
>so I went ahead and installed the following.

Your efforts are appreciated, Gerald.  I don't know about Tom or Jeff, but
I have very little experience with gnatsweb so any help you offer is great.

cgf

cgi-bin/gnatsweb.pl patched

[Gerald Pfeifer]

I usually try not to interfere with sources.redhat.com admin issues,
but cgi-bin/gnatsweb.pl urgently needed the following patch, and Tom is
heavily loaded with other stuff and didn't have the time to address this,
so I went ahead and installed the following.

Phil, it should work now, I hope.

Gerald

Generate proper cookies paths.
By Mark Kuchel <mark@kuchel.net>.

Index: gnatsweb.pl
===================================================================
RCS file: /cvs/gcc/wwwdocs/cgi-bin/gnatsweb.pl,v
retrieving revision 1.19
retrieving revision 1.20
diff -u -3 -p -r1.19 -r1.20
--- gnatsweb.pl	2001/01/11 01:11:36	1.19
+++ gnatsweb.pl	2001/01/19 01:30:42	1.20
@@ -3143,6 +3143,7 @@ sub main
                                -expires => $global_cookie_expires);
     my $expire_old_cookie = $q->cookie(-name => 'gnatsweb',
                                -value => 'does not matter',
+                               -path => $global_cookie_path,
                                #-path was not used for gnatsweb 2.5 cookies
                                -expires => '-1d');
     my $url = $q->param('return_url');

Re: cgi-bin/gnatsweb.pl patched

[Tom Tromey]

>>>>> "Gerald" == Gerald Pfeifer <pfeifer@dbai.tuwien.ac.at> writes:

Gerald> I usually try not to interfere with sources.redhat.com admin
Gerald> issues, but cgi-bin/gnatsweb.pl urgently needed the following
Gerald> patch, and Tom is heavily loaded with other stuff and didn't
Gerald> have the time to address this, so I went ahead and installed
Gerald> the following.

Thanks Gerald.
Actually I was waiting for the final set of patches from you before
hacking the sourceware gnatsweb.  Is gnatsweb ready for a full
re-import into the sourceware cvs?

Tom

Re: cgi-bin/gnatsweb.pl patched

[Gerald Pfeifer]

On 2 Feb 2001, Tom Tromey wrote:
> Actually I was waiting for the final set of patches from you before
> hacking the sourceware gnatsweb.  Is gnatsweb ready for a full
> re-import into the sourceware cvs?

I wouldn't recommend doing so for the official gnatsweb sources (yet), but
I have now committed a final, important patch, such that I can recommend
synching from what we have at gcc.gnu.org.

(Nearly) all changes peculiar to the gcc.gnu.org site should be marked
properly (similiar to what Redhat does with the internal GCC tree), so
you should be able to just copy gnatsweb.pl and manually review these
local changes in less than 10 minutes.

If you noticed any problems/omissions, please let me know!

Gerald
-- 
Gerald "Jerry" pfeifer@dbai.tuwien.ac.at http://www.dbai.tuwien.ac.at/~pfeifer/